Displaying 8 results from an estimated 8 matches for "mapping_matrix_c".
Did you mean:
mapping_matrix
2017 Nov 03
1
[PATCH] Support for Channel Mapping 253.
...jmvalin.ca> wrote:
> Hi Drew,
>
> We're getting there... Some minor comments:
>
> 1) The public header file should not have an
> #ifdef ENABLE_EXPERIMENTAL_AMBISONICS
> since that would require the user code to define it.
>
> Done
> 2) Why do you have #define MAPPING_MATRIX_C ?
>
> No idea. Fixed.
> 3) Looks like MAPPING_MATRIX_MAX_SIZE is not longer useful, right?
>
> Yup. Removed.
> 4) Even though it's not strictly necessary here, please add parentheses
> to the definition of MATRIX_INDEX() to avoid nasty surprises in the
> future (e.g....
2017 Oct 31
7
[PATCH] Support for Channel Mapping 253.
Hi Jean-Marc,
Thanks so much for your review. Attached are my comments and an updated
patch.
On Mon, Oct 30, 2017 at 5:48 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:
> Hi Drew,
>
> I've had some time to dig more deeply into your patch. Here's some more
> in-depth comments:
>
> 1) I note that your OpusMSEncoder struct in private.h adds a
> subframe_mem[]
2017 Nov 02
0
[PATCH] Support for Channel Mapping 253.
Hi Drew,
We're getting there... Some minor comments:
1) The public header file should not have an
#ifdef ENABLE_EXPERIMENTAL_AMBISONICS
since that would require the user code to define it.
2) Why do you have #define MAPPING_MATRIX_C ?
3) Looks like MAPPING_MATRIX_MAX_SIZE is not longer useful, right?
4) Even though it's not strictly necessary here, please add parentheses
to the definition of MATRIX_INDEX() to avoid nasty surprises in the
future (e.g. MATRIX_INDEX(...)*sizeof(foo) would be really bad).
Cheers,
Jean-Mar...
2017 Nov 07
0
[PATCH] Support for Channel Mapping 253.
...> 1) The public header file should not have an
> > #ifdef ENABLE_EXPERIMENTAL_AMBISONICS
> > since that would require the user code to define it.
> >
> > Done
> >
> > 2) Why do you have #define MAPPING_MATRIX_C ?
> >
> > No idea. Fixed.
> >
> >
> > 3) Looks like MAPPING_MATRIX_MAX_SIZE is not longer useful, right?
> >
> > Yup. Removed.
> >
> >
> > 4) Even...
2017 Nov 09
2
[PATCH] Support for Channel Mapping 253.
...PERIMENTAL_AMBISONICS
> > > > since that would require the user code to define
> it.
> > > >
> > > > Done
> > > >
> > > > 2) Why do you have #define MAPPING_MATRIX_C ?
> > > >
> > > > No idea. Fixed.
> > > >
> > > >
> > > > 3) Looks like MAPPING_MATRIX_MAX_SIZE is not
> > longer useful, right?
> >...
2017 Nov 09
0
[PATCH] Support for Channel Mapping 253.
... > #ifdef ENABLE_EXPERIMENTAL_AMBISONICS
> > > since that would require the user code to define it.
> > >
> > > Done
> > >
> > > 2) Why do you have #define MAPPING_MATRIX_C ?
> > >
> > > No idea. Fixed.
> > >
> > >
> > > 3) Looks like MAPPING_MATRIX_MAX_SIZE is not
> longer useful, right?
> > >
>...
2017 Nov 09
0
[PATCH] Support for Channel Mapping 253.
...t;> > > > since that would require the user code to
>> define it.
>> > > >
>> > > > Done
>> > > >
>> > > > 2) Why do you have #define MAPPING_MATRIX_C ?
>> > > >
>> > > > No idea. Fixed.
>> > > >
>> > > >
>> > > > 3) Looks like MAPPING_MATRIX_MAX_SIZE is not
>> > longer use...
2017 Nov 10
2
[PATCH] Support for Channel Mapping 253.
...gt; since that would require the user code
> to define it.
> > > >
> > > > Done
> > > >
> > > > 2) Why do you have #define
> MAPPING_MATRIX_C ?
> > > >
> > > > No idea. Fixed.
> > > >
> > > >
> > > > 3) Looks like MAPPING_MATRIX_MAX_SIZE
> is n...