search for: mapping_matrix

..._alloc (os_support.h:49) > by 0x10006AC1F: opus_projection_ambisonics_encoder_create > (opus_projection_encoder.c:252) > by 0x1000013D9: test_creation_arguments (test_opus_projection.c:268) > by 0x100001D06: main (test_opus_projection.c:396) > > Another issue occurs in mapping_matrix_dot_short(). It attempts to > read beyond the end of the input buffer and may cause a segmentation > fault. It appears that the input buffer contains only 2 channels of > 480 samples each, but 16 channels of 960 samples each are being read > from the buffer. Valgrind reports the foll...

Hello all, Attached is the initial proposed implementation for ch.mapping 253/3, based on the IETF proposal: https://tools.ietf.org/html/draft-ietf-codec-ambisonics-03 A brief overview of the patch, as it is slightly lengthy: After discussion with Jean-Marc, we determined that ch.253/3 will need the demixing matrix as part of the encoder/decoder struct stack and thus will require a new

...0006AC1F: opus_projection_ambisonics_encoder_create >>> (opus_projection_encoder.c:252) >>> by 0x1000013D9: test_creation_arguments (test_opus_projection.c:268) >>> by 0x100001D06: main (test_opus_projection.c:396) >>> >>> Another issue occurs in mapping_matrix_dot_short(). It attempts to >>> read beyond the end of the input buffer and may cause a segmentation >>> fault. It appears that the input buffer contains only 2 channels of >>> 480 samples each, but 16 channels of 960 samples each are being read >>> from the bu...

...302) by 0x10006AB84: opus_alloc (os_support.h:49) by 0x10006AC1F: opus_projection_ambisonics_encoder_create (opus_projection_encoder.c:252) by 0x1000013D9: test_creation_arguments (test_opus_projection.c:268) by 0x100001D06: main (test_opus_projection.c:396) Another issue occurs in mapping_matrix_dot_short(). It attempts to read beyond the end of the input buffer and may cause a segmentation fault. It appears that the input buffer contains only 2 channels of 480 samples each, but 16 channels of 960 samples each are being read from the buffer. Valgrind reports the following: Invalid rea...

...>> by 0x10006AC1F: opus_projection_ambisonics_encoder_create >> (opus_projection_encoder.c:252) >> by 0x1000013D9: test_creation_arguments (test_opus_projection.c:268) >> by 0x100001D06: main (test_opus_projection.c:396) >> >> Another issue occurs in mapping_matrix_dot_short(). It attempts to >> read beyond the end of the input buffer and may cause a segmentation >> fault. It appears that the input buffer contains only 2 channels of >> 480 samples each, but 16 channels of 960 samples each are being read >> from the buffer. Valgrind...

On Mon, Jul 9, 2018 at 9:39 PM, Joshua Bowman <silverbacknet at gmail.com> wrote: > Most projects don't even bother to include *.vcxproj.filters, relying on > cmake or default behavior, but since it'd be referenced in there, sure, I > think so. Want an updated patch? Sure, preferably in "git format-patch" format. - Mark

Hello, Attached is a patch to resolve a memory issue using the Projection API when compiling using a psuedo-stack / limited memory. Please let me any ?s you might have. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20171120/84e36e1b/attachment-0001.html> -------------- next part --------------

...ride;j++) > { > float_dst[i*dst_stride+j] = 0; > } > } > That looks wrong, since you'll be overwriting all channels instead of > just the one you're copying. That should have come up in testing, no? > > 4) You might want to have a look at > mapping_matrix_multiply_channel_out_short(). I can't quite follow what > it's doing, but it seems wrong since the whole point of adding the "tmp" > is to avoid rounding multiple times. > > I haven't had time to thoroughly review the changes to mapping_matrix.c, > but I'll...

...j] = 0; > > } > > } > > That looks wrong, since you'll be overwriting all channels instead of > > just the one you're copying. That should have come up in testing, no? > > > > 4) You might want to have a look at > > mapping_matrix_multiply_channel_out_short(). I can't quite follow > what > > it's doing, but it seems wrong since the whole point of adding the > "tmp" > > is to avoid rounding multiple times. > > > > I haven't had time to thoroughly review the chang...

got it. actually that patch i sent you has something wrong with the mapping_matrix_multiply_short_out... let me fix that and will send you another patch soon. Cheers, Drew On Thu, Nov 23, 2017 at 10:34 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > On 11/23/2017 01:28 PM, Drew Allen wrote: > > To your first point, I was only trying to copy how _multistream_...

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

...ating point (#else case), you shouldn't need shifting since you're > already doing the scaling through a float multiply. > > Jean-Marc > > On 11/23/2017 01:39 PM, Drew Allen wrote: > > got it. actually that patch i sent you has something wrong with the > > mapping_matrix_multiply_short_out... let me fix that and will send you > > another patch soon. > > > > Cheers, > > Drew > > > > On Thu, Nov 23, 2017 at 10:34 AM Jean-Marc Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: > > > &g...

...ome time ago), but can > you confirm/fix the issue? > Done. Yes, this is a merge conflict. > > 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only meant for functions exposed to the API (and in the include/ > directory), but I see several of these in mapping_matrix.h, which I > think is incorrect. > > Done. > 3) opus_projection_ambisonics_encoder_init() (which should be > OPUS_EXPORT) is missing from opus_projection.h > > Done. > 4) I believe mapping_matrix_get_size() should be returning > align(sizeof(MappingMatrix)) + rows * c...

...e_size;i++) { for (j=0;j<dst_stride;j++) { float_dst[i*dst_stride+j] = 0; } } That looks wrong, since you'll be overwriting all channels instead of just the one you're copying. That should have come up in testing, no? 4) You might want to have a look at mapping_matrix_multiply_channel_out_short(). I can't quite follow what it's doing, but it seems wrong since the whole point of adding the "tmp" is to avoid rounding multiple times. I haven't had time to thoroughly review the changes to mapping_matrix.c, but I'll do that on your revised...

...jmvalin.ca> wrote: > Hi Drew, > > We're getting there... Some minor comments: > > 1) The public header file should not have an > #ifdef ENABLE_EXPERIMENTAL_AMBISONICS > since that would require the user code to define it. > > Done > 2) Why do you have #define MAPPING_MATRIX_C ? > > No idea. Fixed. > 3) Looks like MAPPING_MATRIX_MAX_SIZE is not longer useful, right? > > Yup. Removed. > 4) Even though it's not strictly necessary here, please add parentheses > to the definition of MATRIX_INDEX() to avoid nasty surprises in the > future (e....

...        float_dst[i*dst_stride+j] = 0; >       } >     } > That looks wrong, since you'll be overwriting all channels instead of > just the one you're copying. That should have come up in testing, no? > > 4) You might want to have a look at > mapping_matrix_multiply_channel_out_short(). I can't quite follow what > it's doing, but it seems wrong since the whole point of adding the "tmp" > is to avoid rounding multiple times. > > I haven't had time to thoroughly review the changes to mapping_matrix.c, >...

...I assume it's due to a merge problem (that field was removed some time ago), but can you confirm/fix the issue? 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT is only meant for functions exposed to the API (and in the include/ directory), but I see several of these in mapping_matrix.h, which I think is incorrect. 3) opus_projection_ambisonics_encoder_init() (which should be OPUS_EXPORT) is missing from opus_projection.h 4) I believe mapping_matrix_get_size() should be returning align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16) rather than: align(sizeof(MappingM...

...ng since you're > > already doing the scaling through a float multiply. > > > > Jean-Marc > > > > On 11/23/2017 01:39 PM, Drew Allen wrote: > > > got it. actually that patch i sent you has something wrong with the > > > mapping_matrix_multiply_short_out... let me fix that and will send > you > > > another patch soon. > > > > > > Cheers, > > > Drew > > > > > > On Thu, Nov 23, 2017 at 10:34 AM Jean-Marc Valin > > <jmvalin at jmvalin.ca &l...

...ng since you're > > already doing the scaling through a float multiply. > > > > Jean-Marc > > > > On 11/23/2017 01:39 PM, Drew Allen wrote: > > > got it. actually that patch i sent you has something wrong with the > > > mapping_matrix_multiply_short_out... let me fix that and will send > you > > > another patch soon. > > > > > > Cheers, > > > Drew > > > > > > On Thu, Nov 23, 2017 at 10:34 AM Jean-Marc Valin > > <jmvalin at jmvalin.ca &l...

...;         } > >     That looks wrong, since you'll be overwriting all channels > instead of > >     just the one you're copying. That should have come up in > testing, no? > > > >     4) You might want to have a look at > >     mapping_matrix_multiply_channel_out_short(). I can't quite > follow what > >     it's doing, but it seems wrong since the whole point of adding > the "tmp" > >     is to avoid rounding multiple times. > > > >     I haven't had time to tho...