search for: lvivier

When we use virtio-vga with a big-endian guest, the mouse pointer disappears. To fix that, on big-endian use DRM_FORMAT_BGRA8888 instead of DRM_FORMAT_ARGB8888. Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 11288ff..3ed7174 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virt...

When we use virtio-vga with a big-endian guest, the mouse pointer disappears. To fix that, on big-endian use DRM_FORMAT_BGRA8888 instead of DRM_FORMAT_ARGB8888. Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 11288ff..3ed7174 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virt...

...vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to only allocate the buffers if the in_vq has available free slots. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/char/virtio_console.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 7270e7b69262..77105166fe01 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/vi...

...vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to only allocate the buffers if the in_vq has available free slots. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/char/virtio_console.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 7270e7b69262..77105166fe01 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/vi...

VIRTIO_GPU_F_VIRGL is added in features list only for LE kernel, so we must check for it only on LE kernel, otherwise virtio_has_feature() calls BUG() and crashes the kernel. Suggested-by: Gerd Hoffmann <kraxel at redhat.com> Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Note: this patch has been actually written by Gerd, but to post it I don't know if "Suggested-by" is enough or if I should change the "author" field. drivers/gpu/drm/virtio/virtgpu_kms.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff...

VIRTIO_GPU_F_VIRGL is added in features list only for LE kernel, so we must check for it only on LE kernel, otherwise virtio_has_feature() calls BUG() and crashes the kernel. Suggested-by: Gerd Hoffmann <kraxel at redhat.com> Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Note: this patch has been actually written by Gerd, but to post it I don't know if "Suggested-by" is enough or if I should change the "author" field. drivers/gpu/drm/virtio/virtgpu_kms.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff...

...; Rather than that, this patch changes add_port() logic to only allocate the >> buffers if the in_vq has available free slots. >> >> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") >> Cc: mst at redhat.com >> Signed-off-by: Laurent Vivier <lvivier at redhat.com> >> --- >> drivers/char/virtio_console.c | 17 +++++++++++------ >> 1 file changed, 11 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c >> index 7270e7b69262..77105166fe01 100644 >...

...; Rather than that, this patch changes add_port() logic to only allocate the >> buffers if the in_vq has available free slots. >> >> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") >> Cc: mst at redhat.com >> Signed-off-by: Laurent Vivier <lvivier at redhat.com> >> --- >> drivers/char/virtio_console.c | 17 +++++++++++------ >> 1 file changed, 11 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c >> index 7270e7b69262..77105166fe01 100644 >...

When the MAC address is not provided by the vdpa device virtio_net driver assigns a random one without notifying the device. The consequence, in the case of mlx5_vdpa, is the internal routing tables of the device are not updated and this can block the communication between two namespaces. To fix this problem, use virtnet_send_command(VIRTIO_NET_CTRL_MAC) to set the address from virtnet_probe()

...nore ENOSPC > > error in fill_queue(), which means queue has already been filled. > > > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: mst at redhat.com > > Cc: stable at vger.kernel.org > > Signed-off-by: Laurent Vivier <lvivier at redhat.com> > > --- > > > > Notes: > > v2: making fill_queue return int and testing return code for -ENOSPC > > > > drivers/char/virtio_console.c | 24 +++++++++--------------- > > 1 file changed, 9 insertions(+), 15 deletions(-) > > &gt...

...nore ENOSPC > > error in fill_queue(), which means queue has already been filled. > > > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: mst at redhat.com > > Cc: stable at vger.kernel.org > > Signed-off-by: Laurent Vivier <lvivier at redhat.com> > > --- > > > > Notes: > > v2: making fill_queue return int and testing return code for -ENOSPC > > > > drivers/char/virtio_console.c | 24 +++++++++--------------- > > 1 file changed, 9 insertions(+), 15 deletions(-) > > &gt...

...Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v2: making fill_queue return int and testing return code for -ENOSPC drivers/char/virtio_console.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 72...

...Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v2: making fill_queue return int and testing return code for -ENOSPC drivers/char/virtio_console.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 72...

...Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v3: add a comment about ENOSPC error v2: making fill_queue return int and testing return code for -ENOSPC drivers/char/virtio_console.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/char/virtio_cons...

...Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v3: add a comment about ENOSPC error v2: making fill_queue return int and testing return code for -ENOSPC drivers/char/virtio_console.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/char/virtio_cons...

...> ENOSPC > > error in fill_queue(), which means queue has already been filled. > > > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: mst at redhat.com > > Cc: stable at vger.kernel.org > > Signed-off-by: Laurent Vivier <lvivier at redhat.com> > > Reviewed-by: Amit Shah <amit at kernel.org> > > Thanks! Thanks, however this has already been merged by Linus. I can't add the tag retroactively, sorry about that. For bugfix patches like that, I think we can reasonably target a turn around of a coup...

...irtio_read(struct hwrng *rng, void *buf, size_t size, bool wait) > > vi->busy = false; > > - return vi->data_avail; > + return min_t(size_t, size, vi->data_avail); > } > > static void virtio_cleanup(struct hwrng *rng) > Reviewed-by: Laurent Vivier <lvivier at redhat.com>

...irtio_read(struct hwrng *rng, void *buf, size_t size, bool wait) > > vi->busy = false; > > - return vi->data_avail; > + return min_t(size_t, size, vi->data_avail); > } > > static void virtio_cleanup(struct hwrng *rng) > Reviewed-by: Laurent Vivier <lvivier at redhat.com>

...ion Host Unreachable" > > I found the problem with the mlx5 driver as in "it doesn't work when MAC > address is not set"... > > Perhaps Eli can explain what happens when the MAC address is not set? > > > > > > Signed-off-by: Laurent Vivier <lvivier at redhat.com> > > > --- > > > drivers/net/virtio_net.c | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > index 7723b2a49d8e..4bdc8286678b 100644...

On Wed, Apr 05, 2017 at 10:09:15AM +0200, Laurent Vivier wrote: > When we use virtio-vga with a big-endian guest, > the mouse pointer disappears. > > To fix that, on big-endian use DRM_FORMAT_BGRA8888 > instead of DRM_FORMAT_ARGB8888. > > Signed-off-by: Laurent Vivier <lvivier at redhat.com> > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c > index 11288ff..3ed7174 100644 > --- a/drivers/gpu/drm/virtio/virtgpu...