search for: vivier

When we use virtio-vga with a big-endian guest, the mouse pointer disappears. To fix that, on big-endian use DRM_FORMAT_BGRA8888 instead of DRM_FORMAT_ARGB8888. Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 11288ff..3ed7174 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/...

When we use virtio-vga with a big-endian guest, the mouse pointer disappears. To fix that, on big-endian use DRM_FORMAT_BGRA8888 instead of DRM_FORMAT_ARGB8888. Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 11288ff..3ed7174 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/...

On 06/11/2019 14:56, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 06:47:18PM +0200, Laurent Vivier wrote: >> When we hot unplug a virtserialport and then try to hot plug again, >> it fails: >> >> (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait >> (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >> chardev=seri...

On 06/11/2019 14:56, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 06:47:18PM +0200, Laurent Vivier wrote: >> When we hot unplug a virtserialport and then try to hot plug again, >> it fails: >> >> (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait >> (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >> chardev=seri...

[PATCH 2/4] like for cpustat, introduce the "gtime" (guest time of the task= ) and "cgtime" (guest time of the task children) fields for the tasks. Modify signal_struct and task_struct. Modify /proc/<pid>/stat to dis= play these new fields. Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net> -- = ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth -------------- next part -------------- Index: kvm/fs/proc/array.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D...

[PATCH 2/4] like for cpustat, introduce the "gtime" (guest time of the task= ) and "cgtime" (guest time of the task children) fields for the tasks. Modify signal_struct and task_struct. Modify /proc/<pid>/stat to dis= play these new fields. Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net> -- = ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth -------------- next part -------------- Index: kvm/fs/proc/array.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D...

...device in a non-blocking manner like the test program above. > > Fix it by returning available data if a previous hypervisor call has > completed. I tested this patch with the program above, and with rng-tools. > > v2 -> v3: Simplified the implementation as suggested by Laurent Vivier > > Signed-off-by: Martin Wilck <mwilck at suse.com> > --- > drivers/char/hw_random/virtio-rng.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c > index a90001e02b...

...device in a non-blocking manner like the test program above. > > Fix it by returning available data if a previous hypervisor call has > completed. I tested this patch with the program above, and with rng-tools. > > v2 -> v3: Simplified the implementation as suggested by Laurent Vivier > > Signed-off-by: Martin Wilck <mwilck at suse.com> > --- > drivers/char/hw_random/virtio-rng.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c > index a90001e02b...

On Wed, Nov 13, 2019 at 10:21:11AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: > > When we hot unplug a virtserialport and then try to hot plug again, > > it fails: > > > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait > > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ > > chard...

On Wed, Nov 13, 2019 at 10:21:11AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: > > When we hot unplug a virtserialport and then try to hot plug again, > > it fails: > > > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait > > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ > > chard...

...in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to only allocate the buffers if the in_vq has available free slots. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/char/virtio_console.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 7270e7b69262..77105166fe01 100644 --- a/drivers/char/virtio_console.c +++ b/dri...

...in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to only allocate the buffers if the in_vq has available free slots. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/char/virtio_console.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 7270e7b69262..77105166fe01 100644 --- a/drivers/char/virtio_console.c +++ b/dri...

...quot;top(1)" is able to display good cpu user time and cpu guest time by subtracting cpu guest time from cpu user time. Update "gtime" and "cgtime" in signal_struct and task_struct accordingly. [PATCH 4/4] Modify KVM to update guest time accounting. Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net> -- ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth

...quot;top(1)" is able to display good cpu user time and cpu guest time by subtracting cpu guest time from cpu user time. Update "gtime" and "cgtime" in signal_struct and task_struct accordingly. [PATCH 4/4] Modify KVM to update guest time accounting. Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net> -- ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth

On Tue, Jan 24, 2023 at 12:04:24PM +0100, Laurent Vivier wrote: > On 1/24/23 11:15, Michael S. Tsirkin wrote: > > On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote: > > > In virtnet_probe(), if the device doesn't provide a MAC address the > > > driver assigns a random one. > > > As we modify the MAC ad...

On 11/08/2020 15:14, Michael S. Tsirkin wrote: > On Tue, Aug 11, 2020 at 03:00:14PM +0200, Laurent Vivier wrote: >> No problem. This code is tricky and it took me several months to really >> start to understand it ... > > Oh great, we actually have someone who understands the code! > Maybe you can help me understand: virtio_read > takes the buf pointer and puts it in the vq. &g...

On 11/08/2020 14:53, Martin Wilck wrote: > On Tue, 2020-08-11 at 14:39 +0200, Laurent Vivier wrote: >> On 11/08/2020 14:22, Martin Wilck wrote: >>> On Tue, 2020-08-11 at 14:02 +0200, Laurent Vivier wrote: >>>>>> drivers/char/hw_random/virtio-rng.c | 14 ++++++++++++++ >>>>>> 1 file changed, 14 insertions(+) >>>>>> >&g...

On 11/08/2020 15:14, Michael S. Tsirkin wrote: > On Tue, Aug 11, 2020 at 03:00:14PM +0200, Laurent Vivier wrote: >> No problem. This code is tricky and it took me several months to really >> start to understand it ... > > Oh great, we actually have someone who understands the code! > Maybe you can help me understand: virtio_read > takes the buf pointer and puts it in the vq. &g...

On 11/08/2020 14:53, Martin Wilck wrote: > On Tue, 2020-08-11 at 14:39 +0200, Laurent Vivier wrote: >> On 11/08/2020 14:22, Martin Wilck wrote: >>> On Tue, 2020-08-11 at 14:02 +0200, Laurent Vivier wrote: >>>>>> drivers/char/hw_random/virtio-rng.c | 14 ++++++++++++++ >>>>>> 1 file changed, 14 insertions(+) >>>>>> >&g...

VIRTIO_GPU_F_VIRGL is added in features list only for LE kernel, so we must check for it only on LE kernel, otherwise virtio_has_feature() calls BUG() and crashes the kernel. Suggested-by: Gerd Hoffmann <kraxel at redhat.com> Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Note: this patch has been actually written by Gerd, but to post it I don't know if "Suggested-by" is enough or if I should change the "author" field. drivers/gpu/drm/virtio/virtgpu_kms.c | 6 +++++- 1 file changed, 5 insertions(+), 1 delet...