search for: lv_role

When a disk image uses LVM thinp (thin provisioning), the guestfs_lvs API would return the thinp pools. This confused other APIs because thinp pools don't have corresponding /dev/VG/LV device nodes. Filter the LVs that are returned using "lv_role=public". Thanks: Fabian Deutsch --- daemon/lvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/lvm.c b/daemon/lvm.c index d989986..6e201e3 100644 --- a/daemon/lvm.c +++ b/daemon/lvm.c @@ -148,7 +148,9 @@ do_lvs (void) r = command (&out, &err,...

...e -S/--select option used in lvs to filter out only public LVs (see RHBZ#1278878). To make this work again with versions of lvm2 older than that, only on old versions filter out thin layouts and compose the resulting device strings ourselves. The filtering done is much simplier than what "-S lv_role=public" will do, but should be good enough for our need. --- daemon/lvm.c | 150 +++++++++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 140 insertions(+), 10 deletions(-) diff --git a/daemon/lvm.c b/daemon/lvm.c index 979cf63..604e106 100644 --- a/daemon/lvm.c +++ b/daem...

...61). */ if (STRNEQ (p, "unknown device")) { char buf[256]; @@ -260,7 +264,7 @@ do_lvs (void) r = command (&out, &err, str_lvm, "lvs", "-o", "vg_name,lv_name", - "-S", "lv_role=public", + "-S", "lv_role=public && lv_active=active", "--noheadings", "--separator", "/", NULL); if (r == -1) { -- 2.5.0

...e -S/--select option used in lvs to filter out only public LVs (see RHBZ#1278878). To make this work again with versions of lvm2 older than that, only on old versions filter out thin layouts and compose the resulting device strings ourselves. The filtering done is much simplier than what "-S lv_role=public" will do, but should be good enough for our need. --- daemon/lvm.c | 147 ++++++++++++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 136 insertions(+), 11 deletions(-) diff --git a/daemon/lvm.c b/daemon/lvm.c index 979cf63..8bef4d5 100644 --- a/daemon/lvm.c +++ b/daem...

...ichard W.M. Jones wrote: > When a disk image uses LVM thinp (thin provisioning), the guestfs_lvs > API would return the thinp pools. This confused other APIs because > thinp pools don't have corresponding /dev/VG/LV device nodes. > > Filter the LVs that are returned using "lv_role=public". > > Thanks: Fabian Deutsch > --- > daemon/lvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/daemon/lvm.c b/daemon/lvm.c > index d989986..6e201e3 100644 > --- a/daemon/lvm.c > +++ b/daemon/lvm.c > @@ -148,7 +148,9 @@ d...

...daemon/lvm.c index a270b13..c186a5a 100644 --- a/daemon/lvm.c +++ b/daemon/lvm.c @@ -264,7 +264,7 @@ do_lvs (void) r = command (&out, &err, str_lvm, "lvs", "-o", "vg_name,lv_name", - "-S", "lv_role=public && lv_skip_activation!=1", + "-S", "lv_role=public && lv_skip_activation!=yes", "--noheadings", "--separator", "/", NULL); if (r == -1) { -- 2.9.3

...t r; - const int has_S = test_lvs_has_S_opt (); - - if (has_S < 0) - return NULL; - - if (has_S > 0) { - r = command (&out, &err, - str_lvm, "lvs", - "-o", "vg_name,lv_name", - "-S", "lv_role=public && lv_skip_activation!=yes", - "--noheadings", - "--separator", "/", NULL); - if (r == -1) { - reply_with_error ("%s", err); - free (out); - return NULL; - } - - return convert_lvm_ou...

Hi, this series improves the way LVM is used in the appliance: in particular, now lvmetad can eventually run at all, and with the correct configuration. Also improve the listing strategies. Thanks, Pino Toscano (5): daemon: lvm-filter: set also global_filter daemon: lvm-filter: start lvmetad better daemon: lvm: improve filter for LVs with activationskip flag set daemon: lvm: list

Hi, this series improves the way LVM is used in the appliance: in particular, now lvmetad can eventually run at all, and with the correct configuration. Also improve the listing strategies. Changes in v2: - dropped patch #5, will be sent separately - move lvmetad statup in own function (patch #2) Thanks, Pino Toscano (4): daemon: lvm-filter: set also global_filter daemon: lvm-filter:

...free (out); @@ -263,6 +263,7 @@ do_lvs (void) if (has_S > 0) { r = command (&out, &err, str_lvm, "lvs", + "--foreign", "-o", "vg_name,lv_name", "-S", "lv_role=public && lv_skip_activation!=1", "--noheadings", @@ -277,6 +278,7 @@ do_lvs (void) } else { r = command (&out, &err, str_lvm, "lvs", + "--foreign", "-o", &quot...

...e = "xfs" libguestfs: trace: lvs guestfsd: main_loop: proc 198 (vfs_type) took 0.02 seconds guestfsd: main_loop: new request, len 0x28 commandrvf: stdout=y stderr=y flags=0x0 commandrvf: lvm lvs --help commandrvf: stdout=y stderr=y flags=0x0 commandrvf: lvm lvs -o vg_name,lv_name -S "lv_role=public && lv_skip_activation!=yes" --noheadings --separator / libguestfs: trace: lvs = [] libguestfs: trace: list_filesystems = ["/dev/sda1", "xfs"] libguestfs: trace: vfs_type "/dev/sda1" guestfsd: main_loop: proc 11 (lvs) took 0.25 seconds guestfsd: main...

...-1; @@ -262,7 +260,7 @@ do_lvs (void) if (has_S > 0) { r = command (&out, &err, - str_lvm, "lvs", + "lvm", "lvs", "-o", "vg_name,lv_name", "-S", "lv_role=public && lv_skip_activation!=yes", "--noheadings", @@ -276,7 +274,7 @@ do_lvs (void) return convert_lvm_output (out, "/dev/"); } else { r = command (&out, &err, - str_lvm, "lvs", + &qu...

...-1; @@ -262,7 +262,7 @@ do_lvs (void) if (has_S > 0) { r = command (&out, &err, - str_lvm, "lvs", + "lvm", "lvs", "-o", "vg_name,lv_name", "-S", "lv_role=public && lv_skip_activation!=yes", "--noheadings", @@ -276,7 +276,7 @@ do_lvs (void) return convert_lvm_output (out, "/dev/"); } else { r = command (&out, &err, - str_lvm, "lvs", + &qu...

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

...vfs_type) took 0.02 seconds guestfsd: main_loop: new request, len 0x28 commandrvf: stdout=y stderr=y flags=0x0 commandrvf: lvm lvs --help WARNING: Failed to connect to lvmetad. Falling back to device scanning. commandrvf: stdout=y stderr=y flags=0x0 commandrvf: lvm lvs -o vg_name,lv_name -S "lv_role=public && lv_skip_activation!=yes" --noheadings --separator / WARNING: Failed to connect to lvmetad. Falling back to device scanning. libguestfs: trace: lvs = [] libguestfs: trace: list_ldm_volumes guestfsd: main_loop: proc 11 (lvs) took 0.07 seconds guestfsd: main_loop: new request,...

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’