search for: lro

...lt;bhutchings at solarflare.com> > >> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > >> > > > >> > > > If the consensus is still that we must preserve packets exactly (aside > >> > > > from the usual modifications by IP routers) then LRO should be disabled > >> > > > on all devices for which forwarding is enabled. > >> > > > >> > > I believe this is still undoubtedly the consensus. > >> > > >> > With virtio we are getting packets from a linux host, > >&...

...lt;bhutchings at solarflare.com> > >> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > >> > > > >> > > > If the consensus is still that we must preserve packets exactly (aside > >> > > > from the usual modifications by IP routers) then LRO should be disabled > >> > > > on all devices for which forwarding is enabled. > >> > > > >> > > I believe this is still undoubtedly the consensus. > >> > > >> > With virtio we are getting packets from a linux host, > >&...

...> > > From: Ben Hutchings <bhutchings at solarflare.com> > > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > > > If the consensus is still that we must preserve packets exactly (aside > > > > from the usual modifications by IP routers) then LRO should be disabled > > > > on all devices for which forwarding is enabled. > > > > > > I believe this is still undoubtedly the consensus. > > > > With virtio we are getting packets from a linux host, > > so we could thinkably preserve packets exactl...

...> > > From: Ben Hutchings <bhutchings at solarflare.com> > > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > > > If the consensus is still that we must preserve packets exactly (aside > > > > from the usual modifications by IP routers) then LRO should be disabled > > > > on all devices for which forwarding is enabled. > > > > > > I believe this is still undoubtedly the consensus. > > > > With virtio we are getting packets from a linux host, > > so we could thinkably preserve packets exactl...

On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > > I am a bit confu...

On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > > I am a bit confu...

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang <jasowa...

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang <jasowa...

...rom: Ben Hutchings <bhutchings at solarflare.com> >> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 >> > > >> > > > If the consensus is still that we must preserve packets exactly (aside >> > > > from the usual modifications by IP routers) then LRO should be disabled >> > > > on all devices for which forwarding is enabled. >> > > >> > > I believe this is still undoubtedly the consensus. >> > >> > With virtio we are getting packets from a linux host, >> > so we could thinkably...

...07, 2013 at 01:14:20PM -0500, David Miller wrote: > From: Ben Hutchings <bhutchings at solarflare.com> > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > If the consensus is still that we must preserve packets exactly (aside > > from the usual modifications by IP routers) then LRO should be disabled > > on all devices for which forwarding is enabled. > > I believe this is still undoubtedly the consensus. With virtio we are getting packets from a linux host, so we could thinkably preserve packets exactly even with LRO. I am guessing other hardware could be doing...

...07, 2013 at 01:14:20PM -0500, David Miller wrote: > From: Ben Hutchings <bhutchings at solarflare.com> > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > If the consensus is still that we must preserve packets exactly (aside > > from the usual modifications by IP routers) then LRO should be disabled > > on all devices for which forwarding is enabled. > > I believe this is still undoubtedly the consensus. With virtio we are getting packets from a linux host, so we could thinkably preserve packets exactly even with LRO. I am guessing other hardware could be doing...

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang &...

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang &...

...:21 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue at gmail.com wrote: > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > when this interface added to them. Now when disable the LRO, the > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > &...

On Tue, Sep 29, 2020 at 2:23 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 09:58:06AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > Cc: Michael S. Tsirkin &l...

On Tue, Sep 29, 2020 at 2:23 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 09:58:06AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > Cc: Michael S. Tsirkin &l...

...3:32 PM Willem de Bruijn <willemdebruijn.kernel at gmail.com> wrote: > > On Tue, Sep 29, 2020 at 4:00 AM <xiangxia.m.yue at gmail.com> wrote: > > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > I had focused on the code previously. > > The s/w checksum verification cost is significant in a VM with traff...

...<mst at redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 09:58:06AM +0800, xiangxia.m.yue at gmail.com wrote: > > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > > when this interface added to them. Now when disable the LRO, the > > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO&qu...

On Mon, Sep 28, 2020 at 5:41 AM <xiangxia.m.yue at gmail.com> wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Open vSwitch and Linux bridge will disable LRO of the interface > when this interface added to them. Now when disable the LRO, the > virtio-net csum is disable too. That drops the forwarding performance. > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") Patch looks fine to me, but wrong commit here...

On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue at gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Open vSwitch and Linux bridge will disable LRO of the interface > when this interface added to them. Now when disable the LRO, the > virtio-net csum is disable too. That drops the forwarding performance. > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") I am a bit confused by this tag. Did this ch...