search for: local_bh_en

...compiled from source, with 2.6 dom0 and 2.4 domU on a P4 HT 3.2Ghz. Perhaps this helps to track the problem down. Greetings, Martin ---------- The messages : (dom0 hostname is zen, domU hostname is ftp, directory is /xen/mount/ftp) Output from umount: Jun 2 12:13:16 zen kernel: Badness in local_bh_enable at kernel/softirq.c:140 Jun 2 12:13:16 zen kernel: [local_bh_enable+130/144] local_bh_enable+0x82/0x90 Jun 2 12:13:16 zen kernel: [skb_checksum+317/704] skb_checksum+0x13d/0x2c0 Jun 2 12:13:16 zen kernel: [udp_poll+154/352] udp_poll+0x9a/0x160 Jun 2 12:13:16 zen kernel: [sock_poll+41/64...

> Badness in local_bh_enable at kernel/softirq.c:140 > [<c011fb12>] local_bh_enable+0x82/0x90 [<c031fcfd>] > skb_checksum+0x13d/0x2d0 [<c016ac5c>] __pollwait+0x8c/0xd0 > [<c0360d3a>] udp_poll+0x9a/0x160 [<c031af49>] > sock_poll+0x29/0x40 [<c016b635>] do_pollfd+0x95/...

...problem like below: http://www.ussg.iu.edu/hypermail/linux/kernel/0503.1/1622.html http://www.ussg.iu.edu/hypermail/linux/kernel/0503.1/1621.html Not sure if it is xen or linux-iscsi related bug. Any ideas how to cure it will be very appreciated. -- Jul 6 15:20:32 iscsi-test1 kernel: Badness in local_bh_enable at kernel/softirq.c:140 Jul 6 15:20:32 iscsi-test1 kernel: [<c01205a4>] local_bh_enable+0x68/0x83 Jul 6 15:20:32 iscsi-test1 kernel: [<c8973742>] iscsi_queuecommand+0x173/0x1e3 [iscsi_sfnet] Jul 6 15:20:32 iscsi-test1 kernel: [<c02c9e7f>] scsi_dispatch_cmd+0x149/0x264...

...M too). After the OOM killer has done it's job there's about 15MB of RAM free and swap is hardly used at all (1MB at most) I've increased RAM to 64MB and the OOM killer doesn't kick in.. but I am seeing plenty of such messages in the logs ... Dec 2 16:05:21 noc kernel: Badness in local_bh_enable at kernel/softirq.c:141 Dec 2 16:05:21 noc kernel: [<c0121178>] local_bh_enable+0x47/0x6f Dec 2 16:05:21 noc kernel: [<c02177d5>] skb_checksum+0x133/0x25e Dec 2 16:05:21 noc kernel: [<c0250f06>] udp_poll+0x66/0x113 Dec 2 16:05:21 noc kernel: [<c02135fd>] sock_pol...

...itch (act) { > case XDP_REDIRECT: > - get_page(alloc_frag->page); > - alloc_frag->offset += buflen; > err = xdp_do_redirect(tun->dev, &xdp, xdp_prog); > xdp_do_flush_map(); > if (err) > - goto err_redirect; > - rcu_read_unlock(); > - local_bh_enable(); > - return NULL; > + goto err_xdp; > + goto out; > case XDP_TX: > - get_page(alloc_frag->page); > - alloc_frag->offset += buflen; > if (tun_xdp_tx(tun->dev, &xdp) < 0) > - goto err_redirect; > - rcu_read_unlock(); > - loc...

...itch (act) { > case XDP_REDIRECT: > - get_page(alloc_frag->page); > - alloc_frag->offset += buflen; > err = xdp_do_redirect(tun->dev, &xdp, xdp_prog); > xdp_do_flush_map(); > if (err) > - goto err_redirect; > - rcu_read_unlock(); > - local_bh_enable(); > - return NULL; > + goto err_xdp; > + goto out; > case XDP_TX: > - get_page(alloc_frag->page); > - alloc_frag->offset += buflen; > if (tun_xdp_tx(tun->dev, &xdp) < 0) > - goto err_redirect; > - rcu_read_unlock(); > - loc...

Which version of Xen? This usually happens when someone has built a module and forgotten to do "make ARCH=xen" Ian > I was wondering if anyone can make sense of these errors in > the message log: > > Dec 23 14:14:31 localhost kernel: Badness in local_bh_enable > at kernel/softirq. > Dec 23 14:14:31 localhost kernel: [local_bh_enable+130/144] > local_bh_enable+0x Dec 23 14:14:31 localhost kernel: > [skb_checksum+317/704] skb_checksum+0x13d/0x Dec 23 14:14:31 > localhost kernel: [udp_poll+154/352] udp_poll+0x9a/0x160 Dec > 23...

Anybody have any issues running tdmoe on kernel 2.6+? I've got Suse 9.1 + 9.2 running 2.6.5 and 2.6.8 respectively, and when I enable dynamic spans between them, both boxes dump something similar to: Badness in local_bh_enable at kernel/softirq.c:141 [<c0120768>] local_bh_enable+0x48/0x60 [<c02952b0>] dev_queue_xmit+0x230/0x240 [<c02a0980>] eth_header+0x0/0x140 [<f8f12301>] ztdeth_transmit+0x131/0x200 [ztd_eth] [<f8ef17ff>] __ztdynamic_run+0x20f/0x240 [ztdynamic] [<f8ef15e4>]...

...tipath linear ide_generic r8169 uhci_hcd ehci_hcd usbcore thermal processor fan raid0 raid1 md_mod sata_via sd_mod libata scsi_mod via82cxxx ide_core ext3 jbd mbcache EIP: 0060:[<f0872d73>] Not tainted VLI EFLAGS: 00210246 (2.6.17-2-k7 #1) BUG: warning at kernel/softirq.c:141/local_bh_enable() <b0120e27> local_bh_enable+0x25/0x64 <b0218215> lock_sock+0x85/0x8d <b021604b> sock_fasync+0x5c/0x111 <b0216fa1> sock_close+0x1e/0x2a <b0153fcd> __fput+0x87/0x13c <b0151b57> filp_close+0x4e/0x54 <b011e0a1> put_files_struct+0x64/0xa6 &l...

...+0800 > @@ -1283,10 +1314,15 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, > skb_probe_transport_header(skb, 0); > > rxhash = skb_get_hash(skb); > + > #ifndef CONFIG_4KSTACKS > - local_bh_disable(); > - netif_receive_skb(skb); > - local_bh_enable(); > + if (!rx_batched) { > + local_bh_disable(); > + netif_receive_skb(skb); > + local_bh_enable(); > + } else { > + tun_rx_batched(tfile, skb, more); > + } > #else > netif_rx_ni(skb); > #endif If rx_batched has been set, and we are talking to clients not...

...tun_build_skb(struct tun_struct *tun, switch (act) { case XDP_REDIRECT: - get_page(alloc_frag->page); - alloc_frag->offset += buflen; err = xdp_do_redirect(tun->dev, &xdp, xdp_prog); xdp_do_flush_map(); if (err) - goto err_redirect; - rcu_read_unlock(); - local_bh_enable(); - return NULL; + goto err_xdp; + goto out; case XDP_TX: - get_page(alloc_frag->page); - alloc_frag->offset += buflen; if (tun_xdp_tx(tun->dev, &xdp) < 0) - goto err_redirect; - rcu_read_unlock(); - local_bh_enable(); - return NULL; + goto err_xdp...

...+0800 > @@ -1283,10 +1314,15 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, > skb_probe_transport_header(skb, 0); > > rxhash = skb_get_hash(skb); > + > #ifndef CONFIG_4KSTACKS > - local_bh_disable(); > - netif_receive_skb(skb); > - local_bh_enable(); > + if (!rx_batched) { > + local_bh_disable(); > + netif_receive_skb(skb); > + local_bh_enable(); > + } else { > + tun_rx_batched(tfile, skb, more); > + } > #else > netif_rx_ni(skb); > #endif If rx_batched has been set, and we are talking to clients not...

...ECT: >> - get_page(alloc_frag->page); >> - alloc_frag->offset += buflen; >> err = xdp_do_redirect(tun->dev, &xdp, xdp_prog); >> xdp_do_flush_map(); >> if (err) >> - goto err_redirect; >> - rcu_read_unlock(); >> - local_bh_enable(); >> - return NULL; >> + goto err_xdp; >> + goto out; >> case XDP_TX: >> - get_page(alloc_frag->page); >> - alloc_frag->offset += buflen; >> if (tun_xdp_tx(tun->dev, &xdp) < 0) >> - goto err_redirect; >&g...

...tions(+), 7 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index d3677a544b56..372caf7d67d9 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1726,22 +1726,18 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun, goto err_xdp; } } + rcu_read_unlock(); + local_bh_enable(); skb = build_skb(buf, buflen); - if (!skb) { - rcu_read_unlock(); - local_bh_enable(); + if (!skb) return ERR_PTR(-ENOMEM); - } skb_reserve(skb, pad - delta); skb_put(skb, len); get_page(alloc_frag->page); alloc_frag->offset += buflen; - rcu_read_unlock(); - local_b...

...Determining IP information for eth0...NOHZ: local_softirq_pending 08 done. [ OK ] ... Further, receive queue processing might get delayed indefinitely until some interrupt triggers: virtio_net expected napi to be run immediately. One way to cause do_softirq to be executed is by invoking local_bh_enable(). As __napi_schedule is normally called from bh or irq context, this seems to make sense: disable bh before __napi_schedule and enable afterwards. Reported-by: Ulrich Obergfell <uobergfe at redhat.com> Tested-by: Ulrich Obergfell <uobergfe at redhat.com> Signed-off-by: Michael S....

...Determining IP information for eth0...NOHZ: local_softirq_pending 08 done. [ OK ] ... Further, receive queue processing might get delayed indefinitely until some interrupt triggers: virtio_net expected napi to be run immediately. One way to cause do_softirq to be executed is by invoking local_bh_enable(). As __napi_schedule is normally called from bh or irq context, this seems to make sense: disable bh before __napi_schedule and enable afterwards. Reported-by: Ulrich Obergfell <uobergfe at redhat.com> Tested-by: Ulrich Obergfell <uobergfe at redhat.com> Signed-off-by: Michael S....

Hi: This series tries to implement tx batching support for vhost. This was done by using MSG_MORE as a hint for under layer socket. The backend (e.g tap) can then batch the packets temporarily in a list and submit it all once the number of bacthed exceeds a limitation. Tests shows obvious improvement on guest pktgen over over mlx4(noqueue) on host: Mpps -+%

Hi: This series tries to implement tx batching support for vhost. This was done by using MSG_MORE as a hint for under layer socket. The backend (e.g tap) can then batch the packets temporarily in a list and submit it all once the number of bacthed exceeds a limitation. Tests shows obvious improvement on guest pktgen over over mlx4(noqueue) on host: Mpps -+%

...n == rx_batched) { + __skb_queue_head_init(&process_queue); + skb_queue_splice_tail_init(queue, &process_queue); + rcv = true; + } + spin_unlock(&queue->lock); + + if (rcv) { + local_bh_disable(); + while ((skb = __skb_dequeue(&process_queue))) + netif_receive_skb(skb); + local_bh_enable(); + } +} + /* Get packet from user space buffer */ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, void *msg_control, struct iov_iter *from, - int noblock) + int noblock, bool more) { struct tun_pi pi = { 0, cpu_to_be16(ETH_P_IP) }; struct...

Hi, I''m seeing this in the current linux-next tree: ------------[ cut here ]------------ WARNING: at kernel/softirq.c:143 local_bh_enable+0x40/0x87() Modules linked in: xt_state dm_mirror dm_region_hash dm_log microcode [last unloaded: scsi_wait_scan] Pid: 0, comm: swapper Not tainted 2.6.35-rc6-next-20100729+ #29 Call Trace: <IRQ> [<ffffffff81030de3>] warn_slowpath_common+0x80/0x98 [<ffffffff81030e10>] wa...