search for: libvirtxmlsourc

LibVirtXMLSource was subclassing an invalid class, and consequently didn't have copy_storage defined. Fixes RHBZ#670175 --- lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm b/lib/Sys/VirtV2V...

Unless you're lucky, the target volumes won't be in a storage pool, so libvirt will return an error. For libvirtxml we know that the storage is local, so we can inspect it directly. We use qemu-img to determine format and file size. --- lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm | 48 ++++++++++++++++++++--- 1 files changed, 41 insertions(+), 7 deletions(-) diff --git a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm index ffb9309..4bb5eb7 100644 --- a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm +++ b/lib/Sys/VirtV2...

...-- MANIFEST | 12 +- lib/Sys/VirtV2V/Connection/LibVirt.pm | 193 ++------ lib/Sys/VirtV2V/Connection/LibVirtSource.pm | 247 +++++++++ .../LibVirt.pm => Connection/LibVirtTarget.pm} | 228 +++------ .../{LibVirtXML.pm => LibVirtXMLSource.pm} | 81 ++- .../{Target/RHEV.pm => Connection/RHEVTarget.pm} | 520 +++++++++++-------- .../{Connection.pm => Connection/Source.pm} | 116 ++++-- lib/Sys/VirtV2V/Connection/Volume.pm | 179 +++++++ lib/Sys/VirtV2V/Transfer/ESX.pm | 53...

If a volume is not an exact multiple of 512 bytes, qemu-img will report its size rounded down to a 512 byte boundary. However, when copying, the file is still read until EOF, which will return more data than was expected. This change prevents that causing a failure in itself. The situation is still not resolved, however, as there are still situations where this will cause a failure. For example,