Matthew Booth
2011-Jan-17 16:34 UTC
[Libguestfs] [PATCH] Fix subclassing of LibVirtXMLSource
LibVirtXMLSource was subclassing an invalid class, and consequently didn't have copy_storage defined. Fixes RHBZ#670175 --- lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm index e62d996..ffb9309 100644 --- a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm +++ b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm @@ -30,7 +30,7 @@ use Sys::VirtV2V::Util qw(user_message parse_libvirt_volinfo); use Locale::TextDomain 'virt-v2v'; - at Sys::VirtV2V::Connection::Source::LibVirtXMLSource::ISA + at Sys::VirtV2V::Connection::LibVirtXMLSource::ISA qw(Sys::VirtV2V::Connection::Source); =pod -- 1.7.3.4
Richard W.M. Jones
2011-Jan-17 16:47 UTC
[Libguestfs] [PATCH] Fix subclassing of LibVirtXMLSource
On Mon, Jan 17, 2011 at 04:34:08PM +0000, Matthew Booth wrote:> LibVirtXMLSource was subclassing an invalid class, and consequently didn't have > copy_storage defined. > > Fixes RHBZ#670175 > --- > lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm > index e62d996..ffb9309 100644 > --- a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm > +++ b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm > @@ -30,7 +30,7 @@ use Sys::VirtV2V::Util qw(user_message parse_libvirt_volinfo); > > use Locale::TextDomain 'virt-v2v'; > > - at Sys::VirtV2V::Connection::Source::LibVirtXMLSource::ISA > + at Sys::VirtV2V::Connection::LibVirtXMLSource::ISA > qw(Sys::VirtV2V::Connection::Source); > > =podACK. Strong typing FTW ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/
Possibly Parallel Threads
- [PATCH] Don't use libvirt for volume information when converting with libvirtxml
- [PATCH 1/2] Allow reading more data than the reported size of a volume
- [PREVIEW ONLY] Refactor data transfer code
- [PATCH] Display verbose error message when guest storage isn't found
- [PATCH] virt-v2v: Add verbose message logging