search for: levitski

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

virtio-scsi currently has limit of 8 outstanding notifications so when more that 8 LUNs are unplugged, some are missed. Commit 5ff843721467 ("scsi: virtio_scsi: unplug LUNs when events missed") Fixed this by checking the 'event overflow' bit and manually scanned the bus to see which LUNs are still there. However there is a corner case when all LUNs are unplugged. In this case

Hi, Here is my patch queue I accumulated over quite a long time. Patches 1-6 are bugfixes, and rest is mostly RFC. Comments are welcome. Best regards, Maxim Levitsky

On Wed, Jul 15, 2020 at 01:19:55PM +0300, Maxim Levitsky wrote: > On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > > Linux kernel only supports logical block sizes which are power of > > > two, > > > at least 512 bytes and no more that PAGE_SIZE. > > > > > >

This is more or less simplified series of patches that bring power usage on my NV86 close to that of binary blob. Best regards, Maxim Levitsky

On Tue, 2020-07-21 at 22:55 -0400, Martin K. Petersen wrote: > Christoph, > > > Hmm, I wonder if we should simply add the check and warning to > > blk_queue_logical_block_size and add an error in that case. Then > > drivers only have to check the error return, which might add a lot > > less boiler plate code. > > Yep, I agree. > I also agree that this

On Tue, 2020-07-21 at 11:05 +0000, Damien Le Moal wrote: > On 2020/07/21 19:53, Maxim Levitsky wrote: > > Kernel block layer has never supported logical block > > sizes less that SECTOR_SIZE nor larger that PAGE_SIZE. > > > > Some drivers have runtime configurable block size, > > so it makes sense to have common helper for that. > > ...common helper to

On Tue, 2020-07-21 at 11:15 +0000, Damien Le Moal wrote: > On 2020/07/21 19:54, Maxim Levitsky wrote: > > This slightly changes the behavier of the driver, > > s/behavier/behavior Thanks. This is one of the typos I make very consistently. > > > when given invalid block size (non power of two, or below 512 bytes), > > but shoudn't matter. > > > >

On Tue, 2020-07-21 at 11:25 +0000, Damien Le Moal wrote: > On 2020/07/21 19:55, Maxim Levitsky wrote: > > Use blk_is_valid_logical_block_size instead of hardcoded list > > s/hardcoded list/hardcoded checks./ Done, thanks! Best regards, Maxim Levitsky > > > Signed-off-by: Maxim Levitsky <mlevitsk at redhat.com> > > --- > > drivers/scsi/sd.c | 5 +----

Hi, It could be my mistake, but I have uptodate versions of xproto, dri2proto, xserver, nouveau ddx, mesa, libdrm. Still the above commit makes X not load nouveau dri module, and fallback to swrast_dri.so. Nothing in X logs, but that 'Screen is not AIGLX capable' Best regards, Maxim Levitsky

On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote: > On Thu, Jul 5, 2012 at 11:24 PM, Martin Nyhus <martin.nyhus at gmx.com> wrote: > > > > On Mon, 11 Jun 2012 23:18:42 +0200 Martin Nyhus wrote: > > > after resuming from suspend nouveau starts writing Failed to idle > > > channel x (where x is 2 or 3) to the log and X appears to stop and > > >

On Tue, Jul 21, 2020 at 01:52:31PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk already only supports power of two values.

On Tue, Jul 21, 2020 at 01:52:31PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk already only supports power of two values.

Hi, Here I post these 2 misc patches. Best regards, Maxim Levitsky

On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk already only supports power of two values.

This patch series aims to move the logical block size checking to the block code. This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted

This patch series aims to move the logical block size checking to the block code. This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted