search for: levitsky

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check physical block size since...

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check physical block size since...

...and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky <mlevitsk at redhat.com> --- drivers/block/virtio_blk.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 980df853ee497..36dda31cc4e96 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/b...

...and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky <mlevitsk at redhat.com> --- drivers/block/virtio_blk.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 980df853ee497..36dda31cc4e96 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/b...

...s to see which LUNs are still there. However there is a corner case when all LUNs are unplugged. In this case (which is not fully scsi confirmant IMHO), all scsi commands to such device respond with INVALID TARGET. This patch proposes to detect this and remove the LUN in this case as well. Maxim Levitsky (1): scsi: virtio-scsi: handle correctly case when all LUNs were unplugged drivers/scsi/virtio_scsi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.26.2

Hi, Here is my patch queue I accumulated over quite a long time. Patches 1-6 are bugfixes, and rest is mostly RFC. Comments are welcome. Best regards, Maxim Levitsky

On Wed, Jul 15, 2020 at 01:19:55PM +0300, Maxim Levitsky wrote: > On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > > Linux kernel only supports logical block sizes which are power of > > > two, > > > at least 512 bytes and no more that...

This is more or less simplified series of patches that bring power usage on my NV86 close to that of binary blob. Best regards, Maxim Levitsky

...eue_logical_block_size return an error value, and have blk_is_valid_logical_block_size and use either of these checks, depending on the driver with eventual goal of un-exporting blk_is_valid_logical_block_size. Also note that I did add WARN_ON to blk_queue_logical_block_size. Best regards, Maxim Levitsky

On Tue, 2020-07-21 at 11:05 +0000, Damien Le Moal wrote: > On 2020/07/21 19:53, Maxim Levitsky wrote: > > Kernel block layer has never supported logical block > > sizes less that SECTOR_SIZE nor larger that PAGE_SIZE. > > > > Some drivers have runtime configurable block size, > > so it makes sense to have common helper for that. > > ...common helper to c...

On Tue, 2020-07-21 at 11:15 +0000, Damien Le Moal wrote: > On 2020/07/21 19:54, Maxim Levitsky wrote: > > This slightly changes the behavier of the driver, > > s/behavier/behavior Thanks. This is one of the typos I make very consistently. > > > when given invalid block size (non power of two, or below 512 bytes), > > but shoudn't matter. > > > >...

On Tue, 2020-07-21 at 11:25 +0000, Damien Le Moal wrote: > On 2020/07/21 19:55, Maxim Levitsky wrote: > > Use blk_is_valid_logical_block_size instead of hardcoded list > > s/hardcoded list/hardcoded checks./ Done, thanks! Best regards, Maxim Levitsky > > > Signed-off-by: Maxim Levitsky <mlevitsk at redhat.com> > > --- > > drivers/scsi/sd.c | 5 +---...

Hi, It could be my mistake, but I have uptodate versions of xproto, dri2proto, xserver, nouveau ddx, mesa, libdrm. Still the above commit makes X not load nouveau dri module, and fallback to swrast_dri.so. Nothing in X logs, but that 'Screen is not AIGLX capable' Best regards, Maxim Levitsky

...card . > Seems related to this bug: > http://lists.freedesktop.org/archives/nouveau/2011-January/007358.html > . If I can do anything else > to help, I will be glad to. Added nouveau at lists.freedesktop.org> I confirm the same issue here. will try to do dig it. Best regards, Maxim Levitsky

On Tue, Jul 21, 2020 at 01:52:31PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk...

On Tue, Jul 21, 2020 at 01:52:31PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk...

Hi, Here I post these 2 misc patches. Best regards, Maxim Levitsky

On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk...

...it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted few block drivers that I am familiar with to use this interface instead of their own implementation. Best regards, Maxim Levitsky Maxim Levitsky (10): block: introduce blk_is_valid_logical_block_size block: virtio-blk: check logical block size block: loop: use blk_is_valid_logical_block_size block: nbd: use blk_is_valid_logical_block_size block: null: use blk_is_valid_logical_block_size block: ms_block: use blk_i...

...it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted few block drivers that I am familiar with to use this interface instead of their own implementation. Best regards, Maxim Levitsky Maxim Levitsky (10): block: introduce blk_is_valid_logical_block_size block: virtio-blk: check logical block size block: loop: use blk_is_valid_logical_block_size block: nbd: use blk_is_valid_logical_block_size block: null: use blk_is_valid_logical_block_size block: ms_block: use blk_i...