search for: keep_backup

...links and backup. And SUPPORT_HARD_LINKS is true. rsync -avH --delete --backup --backup-dir=/some/backup/dir \ srchost::dir/ dir/ The core says... ------------------------------------------------------------------------ Program terminated with signal 11, Segmentation fault. #0 0x80536c0 in keep_backup (fname=0x808f060 "rsync.core") at backup.c:266 266 if (!kept && preserve_hard_links && file->link_u.links (gdb) where #0 0x80536c0 in keep_backup (fname=0x808f060 "rsync.core") at backup.c:266 #1 0x80537c9 in make_backup (fname=0x808f060 "r...

here (in keep_backup())? --- backup.c.orig Mon Dec 9 17:02:36 2002 +++ backup.c Mon Dec 9 17:03:50 2002 @@ -273,6 +273,7 @@ /* move to keep tree if a file */ if(!kept) { + make_bak_dir(fname,backup_dir); if (!robust_move (fname, keep_name)) rprintf(FERROR, "keep_backup failed %s -> %s : %s...

Rare and intermittent message groups suggest a race condition ... ? Here's the pattern of messages: rsync: make_bak_dir mkdir <path> failed: File exists (17) rsync: keep_backup failed: <path> -> <path>: No such file or directory (2) rsync: stat <path> failed: No such file or directory (2) How rarely? We run a scripted rsync daily on ~50 personal computers and servers, typically backing up /etc, /home, /root and /var. These message groups appear abo...

Yesterday I upgraded rsync from 2.6.9 to 3.0.2 (as part of upgrading Fedora 8 to Fedora 9). Today, I received these unexpected errors: rsync: make_bak_dir mkdir "/backup/server/../server-before-5/var" failed: File exists (17) rsync: keep_backup failed: "/backup/server/var/lib/rpcbind/rpcbind.file" -> "../server-before-5/var/lib/rpcbind/rpcbind.file": Success (0) rsync: stat "/backup/server/../server-before-5/var/lib/rpcbind/rpcbind.file" failed: No such file or directory (2) from a script that had worked...

...7_22-27-43" / /Volumes/Backup I can't seem to figure out how make_bak_dir could be returning this error for a handful of them: rsync: make_bak_dir mkdir "/Volumes/Backup/_Archive_2010_March_07_22-27-43/Users/jsmith/Library/Mail/Mailboxes/ Orchestra" failed: File exists rsync: keep_backup failed: "/Volumes/Backup/Users/jsmith/Library/Mail/Mailboxes/ Orchestra/ * New Mexico Concert/Assistant - John Smith.mbox/Messages/269981.emlx" -> "_Archive_2010_March_07_22-27-43/Users/jsmith/Library/Mail/Mailboxes/ Orchestra/ * New Mexico Concert/Assistant - John Smith...

...y\ Documents/test.file I run the command from the windows box as follows (excluding mail induced word wrap) rsync -axq --modify-window=2 --delete --exclude=Mail/ --backup --backup-dir=/archive ~/My\ Documents/ roo.home::rabbit/backup/My\ Documents/ and get the following error message rsync: keep_backup failed: "/backup/My Documents/test.file" (in rabbit) -> "/archive/test.file": Permission denied (13) rsync: stat "/archive/test.file" (in rabbit) failed: No such file or directory (2) (and pretty much the same thing has been logged at the server end) WHY? - ever...

...errno = ENOTEMPTY; ! } else if (make_backups) ok = make_backup(fname); else ok = do_rmdir(fname) == 0; *** rsync 2.6.6/backup.c Sun Mar 25 20:57:48 2007 --- rsync 2.6.6+/backup.c Tue Apr 3 13:15:32 2007 *************** static int keep_backup(char *fname) *** 204,222 **** } if (!kept && S_ISDIR(file->mode)) { ! /* make an empty directory */ ! if (do_mkdir(buf, file->mode) < 0 ! && (errno != ENOENT || make_bak_dir(buf) < 0 ! ||...

Hi All, I think I am missing something with the backup-dir-dels.diff patch. How does that differ from the original --backup -backup-dir=DIR option? Using the original one works fine (on patched or non-patched rsync), putting deleted source files into the DIR on destination, but when I run --backup -backup-dir-dels=DIR, nothing happens to the deleted files. Rob D

...des.o zlib/inffast.o \ zlib/inflate.o zlib/inftrees.o zlib/infutil.o zlib/trees.o \ zlib/zutil.o zlib/adler32.o diff -rupNP --exclude-from cvs/.ignore cvs/backup.c pool2/backup.c --- cvs/backup.c Wed Feb 4 03:49:36 2004 +++ pool2/backup.c Wed Feb 4 22:11:26 2004 @@ -189,6 +189,7 @@ static int keep_backup(char *fname) backup_dir[--backup_dir_len] = '\0'; if (verbose > 0) rprintf(FINFO, "backup_dir is %s\n", backup_dir); + initialised = 1; } @@ -199,7 +200,7 @@ static int keep_backup(char *fname) if (do_stat(fname, &st)) return 1; #endif - file = make_f...

Through several versions up to and including the current 3.0.9 I experience sporadic, repeating (but not predictably) errors of this form: > rsync: make_bak_dir mkdir "/REPO/backup/XXXX-data1-20120727-040453" failed: File exists (17) > rsync: keep_backup failed: "/REPO/backup/XXXX-data1/data1/A182/tb5178/tb5178.hebb/out.TENT_warn.txt" -> "/REPO/backup/XXXX-data1-20120727-040453/data1/A182/tb5178/tb5178.hebb/out.TENT_warn.txt": No such file or directory (2) > rsync: stat "/REPO/backup/XXXX-data1-20120727-040453/data1/A...

...| `-- c `-- test2 9 directories, 0 files (0)>mv test1/c test1/d root@feral:/tmp/test (0)>rsync -avv --delete -b --backup-dir test2 test1/ test0 building file list ... expand file_list to 4000 bytes, did move done expand file_list to 4000 bytes, did move deleting in . backup_dir is test2 keep_backup c -> test2/c delta-transmission disabled for local transfer or --whole-file ./ d/ total: matches=0 tag_hits=0 false_alarms=0 data=0 wrote 77 bytes read 20 bytes 194.00 bytes/sec total size is 0 speedup is 0.00 root@feral:/tmp/test (0)>tree . |-- test0 | |-- a | |-- b | |-- d | `-...

...p-dir=$ROOT/backup $ROOT/src $ROOT/dst Patch: * only removes file if it was already a device file --- backup.c.gen Mon Feb 21 17:57:58 2005 +++ backup.c Tue May 31 11:33:30 2005 @@ -171,7 +171,7 @@ * We will move the file to be deleted into a parallel directory tree. */ static int keep_backup(char *fname) { - STRUCT_STAT st; + STRUCT_STAT st, bufst; struct file_struct *file; char *buf; int kept = 0; @@ -190,6 +190,12 @@ /* Check to see if this is a device file, or link */ if (IS_DEVICE(file->mode)) { if (am_root &am...

...er 3.0.x, rsync sometimes prints an "Invalid argument" error when moving sockets to the backup directory (--backup-dir): rsync: mknod "/backup/machine/../machine-before-4/var/run/audit_events" failed: Invalid argument (22) The problem appears to be that, at least with sockets, keep_backup() is calling do_mknod() with garbage in the third parameter (dev). When I add some debug output to do_mknod(): printf("mknod pathname=%s, mode=%d, dev=%llu\n", pathname, mode, dev); int mknodres = mknod(pathname, mode, dev); printf("mknod result: %d, errno=%d\n", mknodre...

Running rsync 2.4.7pre1, using the --backup-dir option, I just realized today that file ownerships and permissions of backed up files are not preserved. In other words, if rsync moves an obsolete file to the backup dir, it's ownership seems to revert to root:root, and permissions change, as well. We are also using the -a (archive) option, by the way, which should mean "preserve

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear list members, there are two new rsync-features I made up and would like to discuss with you. If you think these new features might be useful for the whole rsync-community, please give me a note and I'll send you the patches (or post them here). 1.) Setting owner and/or group of backup files. In our servers I'm using rsync to backup

....19 +++ backup.c 25 Jan 2004 09:54:32 -0000 @@ -25,6 +25,7 @@ extern int backup_suffix_len; extern int backup_dir_len; extern char *backup_suffix; extern char *backup_dir; +extern struct file_struct **hlink_list; extern int am_root; extern int preserve_devices; @@ -263,7 +264,7 @@ static int keep_backup(char *fname) } #endif if (!kept && preserve_hard_links && file->link_u.links - && file->F_HEAD != file) { + && hlink_list[file->F_INDEX] != file) { if (verbose > 1) rprintf(FINFO, "%s is a hard link\n", f_name(file)); } ---...

...rsyserr(FERROR, errno, "link %s -> \"%s\"", ^ backup.c(256): remark #981: operands are evaluated in unspecified order full_fname(fname), buf); ^ backup.c(255): remark #981: operands are evaluated in unspecified order rsyserr(FERROR, errno, "keep_backup failed: %s -> \"%s\"", ^ /opt/intel/compilo_9/l_cc_c_9.1.042/bin/icc -c99 -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -c options.c -o options.o icc: Command line remark: option '-W' not supported proto.h(224): remark #310: old-style parameter list (anachronism) void s...