rsync - May 2008 - 3.0.2: make_bak_dir mkdir ...: File exists (17)

Yesterday I upgraded rsync from 2.6.9 to 3.0.2 (as part of upgrading
Fedora 8 to Fedora 9). Today, I received these unexpected errors:

rsync: make_bak_dir mkdir "/backup/server/../server-before-5/var"
failed: File exists (17)
rsync: keep_backup failed:
"/backup/server/var/lib/rpcbind/rpcbind.file"
-> "../server-before-5/var/lib/rpcbind/rpcbind.file": Success (0)
rsync: stat
"/backup/server/../server-before-5/var/lib/rpcbind/rpcbind.file"
failed:
No such file or directory (2)

from a script that had worked flawlessly for years under rsync 2.6.x:

  BKPDIR=server-before-`date +%w`
  cd /backup
  rm -rf $BKPDIR
  mkdir -m 700 $BKPDIR
  cd /backup/server
  rsync -avHx --numeric-ids --delete --delete-excluded \
        --backup --backup-dir=../$BKPDIR \
	--exclude-from=/root/bin/backupserver.excludelist \
        root@server:/ .

Prior to the script being run, these files had been deleted from the
sender side:

  /var/lib/rpcbind/portmap.file
  /var/lib/rpcbind/rpcbind.file

along with the /var/lib/rpcbind directory.

Following the rsync run, the receiver side has:

  /backup/server/var/lib/rpcbind/rpcbind.file
  /backup/server-before-5/var/lib/rpcbind/portmap.file

i.e., only one of the deleted files was moved to the backup directory.

Any ideas?

-- 
Jordan Russell

On Fri, May 16, 2008 at 12:07:47PM -0500, Jordan Russell
wrote:
> rsync: make_bak_dir mkdir "/backup/server/../server-before-5/var"
failed: File exists (17)
> rsync: keep_backup failed:
"/backup/server/var/lib/rpcbind/rpcbind.file" ->
"../server-before-5/var/lib/rpcbind/rpcbind.file": Success (0)
I tried to duplicate your failure, but rsync didn't fail for me.

The above errors indicate that the keep_backup() function tried to
rename the file into the backup dir, got an ENOENT error (which is the
only time it tries to call make_bak_dir()) and the attempt to make the
parent directory of the file failed with an EEXIST error (and then the
errno got reset to 0 due to the outputting of the error message, a bug
that I have fixed).  Is it possible that the file rpcbind.file caused an
ETXTBSY errno when rsync tried to rename it?  The only way I can see the
above happening is if the rename() call got ETXTBSY, tried to remove the
destination file (which didn't exist), and then returned the ENOENT
error from the unlink() instead of the ETXTBSY error from the rename().
That would lead to the above deceptive series of messages.  I have fixed
that too.

Is the backup problem reproducible?  If so, please try the latest
nightly tar file (or git checkout) and see what error you get.

..wayne..