search for: jiangyiwen

On 2018/12/13 3:09, David Miller wrote: > From: jiangyiwen <jiangyiwen at huawei.com> > Date: Wed, 12 Dec 2018 17:29:31 +0800 > >> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h >> index 1d57ed3..2292f30 100644 >> --- a/include/uapi/linux/virtio_vsock.h >> +++ b/include/uapi/linux/vir...

On 2018/12/13 3:09, David Miller wrote: > From: jiangyiwen <jiangyiwen at huawei.com> > Date: Wed, 12 Dec 2018 17:29:31 +0800 > >> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h >> index 1d57ed3..2292f30 100644 >> --- a/include/uapi/linux/virtio_vsock.h >> +++ b/include/uapi/linux/vir...

On 2018/11/7 14:20, Jason Wang wrote: > > On 2018/11/6 ??2:41, jiangyiwen wrote: >> On 2018/11/6 12:00, Jason Wang wrote: >>> On 2018/11/5 ??3:47, jiangyiwen wrote: >>>> Guest receive mergeable rx buffer, it can merge >>>> scatter rx buffer into a big buffer and then copy >>>> to user space. >>>> >>>...

On 2018/11/6 11:32, Jason Wang wrote: > > On 2018/11/6 ??11:17, jiangyiwen wrote: >> On 2018/11/6 10:41, Jason Wang wrote: >>> On 2018/11/6 ??10:17, jiangyiwen wrote: >>>> On 2018/11/5 17:21, Jason Wang wrote: >>>>> On 2018/11/5 ??3:43, jiangyiwen wrote: >>>>>> Now vsock only support send/receive small packet, it...

On 2018/11/6 11:32, Jason Wang wrote: > > On 2018/11/6 ??11:17, jiangyiwen wrote: >> On 2018/11/6 10:41, Jason Wang wrote: >>> On 2018/11/6 ??10:17, jiangyiwen wrote: >>>> On 2018/11/5 17:21, Jason Wang wrote: >>>>> On 2018/11/5 ??3:43, jiangyiwen wrote: >>>>>> Now vsock only support send/receive small packet, it...

On 2018/11/7 21:32, Jason Wang wrote: > > On 2018/11/7 ??3:11, jiangyiwen wrote: >> On 2018/11/7 14:18, Jason Wang wrote: >>> On 2018/11/6 ??2:30, jiangyiwen wrote: >>>>> Seems duplicated with the one used by vhost-net. >>>>> >>>>> In packed virtqueue implementation, I plan to move this to vhost.c. >>>&...

On 2018/11/7 14:18, Jason Wang wrote: > > On 2018/11/6 ??2:30, jiangyiwen wrote: >>> Seems duplicated with the one used by vhost-net. >>> >>> In packed virtqueue implementation, I plan to move this to vhost.c. >>> >> Yes, this code is full copied from vhost-net, if it can be packed into >> vhost.c, it would be great. >&g...

On 2018/11/7 14:18, Jason Wang wrote: > > On 2018/11/6 ??2:30, jiangyiwen wrote: >>> Seems duplicated with the one used by vhost-net. >>> >>> In packed virtqueue implementation, I plan to move this to vhost.c. >>> >> Yes, this code is full copied from vhost-net, if it can be packed into >> vhost.c, it would be great. >&g...

On 2018/11/6 12:00, Jason Wang wrote: > > On 2018/11/5 ??3:47, jiangyiwen wrote: >> Guest receive mergeable rx buffer, it can merge >> scatter rx buffer into a big buffer and then copy >> to user space. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> >> --- >> include/linux/virtio_vsock.h | 9 ++++...

On 2018/11/6 12:00, Jason Wang wrote: > > On 2018/11/5 ??3:47, jiangyiwen wrote: >> Guest receive mergeable rx buffer, it can merge >> scatter rx buffer into a big buffer and then copy >> to user space. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> >> --- >> include/linux/virtio_vsock.h | 9 ++++...

Batch sending rx buffer can improve total bandwidth. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 9600133..a4bf0a1 100644 --- a/drivers/vhost/vsock.c +++ b/drivers/vhost/vsock.c @@ -151,9 +151,11 @@ static...

Batch sending rx buffer can improve total bandwidth. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 9600133..a4bf0a1 100644 --- a/drivers/vhost/vsock.c +++ b/drivers/vhost/vsock.c @@ -151,9 +151,11 @@ static...

On 2018/12/13 13:59, David Miller wrote: > From: jiangyiwen <jiangyiwen at huawei.com> > Date: Thu, 13 Dec 2018 11:11:48 +0800 > >> I hope Host can fill fewer bytes into rx virtqueue, so >> I keep structure virtio_vsock_mrg_rxbuf_hdr one byte >> alignment. > > The question is if this actully matters. > > Do you k...

On 2018/11/15 15:04, Michael S. Tsirkin wrote: > On Thu, Nov 15, 2018 at 11:56:03AM +0800, jiangyiwen wrote: >> Hi Stefan, Michael, Jason and everyone, >> >> Several days ago, I discussed with jason about "Vsock over Virtio-net". >> This idea has two advantages: >> First, it can use many great features of virtio-net, like batching, >> mergeable rx buffe...

On 2018/11/15 15:04, Michael S. Tsirkin wrote: > On Thu, Nov 15, 2018 at 11:56:03AM +0800, jiangyiwen wrote: >> Hi Stefan, Michael, Jason and everyone, >> >> Several days ago, I discussed with jason about "Vsock over Virtio-net". >> This idea has two advantages: >> First, it can use many great features of virtio-net, like batching, >> mergeable rx buffe...

On 2018/11/6 10:41, Jason Wang wrote: > > On 2018/11/6 ??10:17, jiangyiwen wrote: >> On 2018/11/5 17:21, Jason Wang wrote: >>> On 2018/11/5 ??3:43, jiangyiwen wrote: >>>> Now vsock only support send/receive small packet, it can't achieve >>>> high performance. As previous discussed with Jason Wang, I revisit the >>>>...

On 2018/11/6 10:41, Jason Wang wrote: > > On 2018/11/6 ??10:17, jiangyiwen wrote: >> On 2018/11/5 17:21, Jason Wang wrote: >>> On 2018/11/5 ??3:43, jiangyiwen wrote: >>>> Now vsock only support send/receive small packet, it can't achieve >>>> high performance. As previous discussed with Jason Wang, I revisit the >>>>...

On 2018/12/12 23:37, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, >> it will merge big packet into rx vq. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> > > I feel this approach jumps into making interface changes for > optimizations too quickly. Fo...

On 2018/12/12 23:37, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, >> it will merge big packet into rx vq. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> > > I feel this approach jumps into making interface changes for > optimizations too quickly. Fo...

...buffer. It will fill a fixed size(PAGE_SIZE) everytime to compact with small packet and big packet. In addition, it also add one optimizations copied from virtio-net.c. - Skb_page_frag_refill() which can use high order page and reduce the stress of page allocator. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- include/linux/virtio_vsock.h | 3 ++ net/vmw_vsock/virtio_transport.c | 112 +++++++++++++++++++++++++++++++-------- 2 files changed, 92 insertions(+), 23 deletions(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index e223e26..bf84418 10064...