jiangyiwen
2018-Nov-07 07:11 UTC
[PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host
On 2018/11/7 14:18, Jason Wang wrote:> > On 2018/11/6 ??2:30, jiangyiwen wrote: >>> Seems duplicated with the one used by vhost-net. >>> >>> In packed virtqueue implementation, I plan to move this to vhost.c. >>> >> Yes, this code is full copied from vhost-net, if it can be packed into >> vhost.c, it would be great. >> > > If you try to reuse vhost-net, you don't even need to care about this :) > > Thanks > > > . >Hi Jason, Thank your advice, I will consider your idea. But I don't know what's stefan's suggestion? It seems that he doesn't care much about this community. :( I still hope this community can have some vitality.
Jason Wang
2018-Nov-07 13:32 UTC
[PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host
On 2018/11/7 ??3:11, jiangyiwen wrote:> On 2018/11/7 14:18, Jason Wang wrote: >> On 2018/11/6 ??2:30, jiangyiwen wrote: >>>> Seems duplicated with the one used by vhost-net. >>>> >>>> In packed virtqueue implementation, I plan to move this to vhost.c. >>>> >>> Yes, this code is full copied from vhost-net, if it can be packed into >>> vhost.c, it would be great. >>> >> If you try to reuse vhost-net, you don't even need to care about this:) >> >> Thanks >> >> >> . >> > Hi Jason, > > Thank your advice, I will consider your idea. But I don't know > what's stefan's suggestion? It seems that he doesn't care much > about this community.:(I think not. He is probably busy these days.> > I still hope this community can have some vitality. >Let's wait for few more days for the possible comments from Stefan or Michael. But I do prefer to unify the virtio networking datapath which will be easier to be extended and maintained. Thanks
jiangyiwen
2018-Nov-08 01:56 UTC
[PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host
On 2018/11/7 21:32, Jason Wang wrote:> > On 2018/11/7 ??3:11, jiangyiwen wrote: >> On 2018/11/7 14:18, Jason Wang wrote: >>> On 2018/11/6 ??2:30, jiangyiwen wrote: >>>>> Seems duplicated with the one used by vhost-net. >>>>> >>>>> In packed virtqueue implementation, I plan to move this to vhost.c. >>>>> >>>> Yes, this code is full copied from vhost-net, if it can be packed into >>>> vhost.c, it would be great. >>>> >>> If you try to reuse vhost-net, you don't even need to care about this:) >>> >>> Thanks >>> >>> >>> . >>> >> Hi Jason, >> >> Thank your advice, I will consider your idea. But I don't know >> what's stefan's suggestion? It seems that he doesn't care much >> about this community.:( > > > I think not. He is probably busy these days. > > >> >> I still hope this community can have some vitality. >> > > Let's wait for few more days for the possible comments from Stefan or Michael. But I do prefer to unify the virtio networking datapath which will be easier to be extended and maintained. > > Thanks > > > . >Hi Jason, Actually vsock use virtio-net as transport path should be a better idea, I will try to consider the new idea. Thanks, Yiwen.
Maybe Matching Threads
- [PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host
- [PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host
- [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host
- [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host
- [PATCH 0/5] VSOCK: support mergeable rx buffer in vhost-vsock