search for: jeffm

Hi all - Here''s my current error handling patchset, against 3.1-rc8. Almost all of this patchset is preparing for actual error handling. Before we start in on that work, I''m trying to reduce the surface we need to worry about. It turns out that there is a ton of code that returns an error code but never actually reports an error. The patchset has grown to 65 patches. 46 of them

This fixes the following warning: drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used uninitialized in this function The conditions that govern when queue is set aren't apparent to gcc. Setting queue = NULL clears the warning. Signed-off-by: Jeff Mahoney <jeffm at suse.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -1006,7 +1006,7 @@ struct virtqueue *vring_create_virtqueue const char *name) { struct virtqueue *vq; - void *qu...

This fixes the following warning: drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used uninitialized in this function The conditions that govern when queue is set aren't apparent to gcc. Setting queue = NULL clears the warning. Signed-off-by: Jeff Mahoney <jeffm at suse.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -1006,7 +1006,7 @@ struct virtqueue *vring_create_virtqueue const char *name) { struct virtqueue *vq; - void *qu...

...loc(). Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Arjan <arjan@infradead.org> Cc: Chris Mason <chris.mason@oracle.com> Cc: Yan Zheng <zheng.yan@oracle.com> Cc: Sven Wegener <sven.wegener@stealer.net> Cc: Josef Bacik <jbacik@redhat.com> Cc: Jeff Mahoney <jeffm@suse.com> --- diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 7c3cd24..09ef5d6 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -944,14 +944,17 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf, if (count == 0) goto out_nolock; + pages = kmalloc(nrptr...

...Product: xorg Version: 7.5 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org ReportedBy: jeffm at suse.com QAContact: xorg-team at lists.x.org Created an attachment (id=38722) --> (https://bugs.freedesktop.org/attachment.cgi?id=38722) Xorg.0.log Under normal operation, the display locks up. The keyboard becomes nonresponsive, but the mouse (and cursor movement) still works. T...

...s/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used >> uninitialized in this function >> >> The conditions that govern when queue is set aren't apparent to gcc. >> >> Setting queue = NULL clears the warning. >> >> Signed-off-by: Jeff Mahoney <jeffm at suse.com> > > Which gcc version produces this warning? > I do not seem to see it with gcc 5.3.1. gcc version 4.8.5 (SUSE Linux) > Also - use uninitialized_var then? If it were a fast path, sure, but otherwise the use of uninitialized_var just makes similar issues harder to deb...

...s/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used >> uninitialized in this function >> >> The conditions that govern when queue is set aren't apparent to gcc. >> >> Setting queue = NULL clears the warning. >> >> Signed-off-by: Jeff Mahoney <jeffm at suse.com> > > Which gcc version produces this warning? > I do not seem to see it with gcc 5.3.1. gcc version 4.8.5 (SUSE Linux) > Also - use uninitialized_var then? If it were a fast path, sure, but otherwise the use of uninitialized_var just makes similar issues harder to deb...

...loc(). Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Arjan <arjan@infradead.org> Cc: Chris Mason <chris.mason@oracle.com> Cc: Yan Zheng <zheng.yan@oracle.com> Cc: Sven Wegener <sven.wegener@stealer.net> Cc: Josef Bacik <jbacik@redhat.com> Cc: Jeff Mahoney <jeffm@suse.com> Cc: Tao Ma <tao.ma@oracle.com> --- diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 7c3cd24..e7b0d81 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -944,14 +944,19 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf, if (count == 0) goto...

...Directories browseable = no writable = yes #[profiles] # path = /home/samba/profiles # writeable = yes # browseable = no # create mask = 0600 # directory mask = 0700 [netlogon] path = /home/netlogon read only = yes write list = jeffm

Hi all - The following 9 patches add more error handling to the btrfs code: - Add btrfs_panic - Catch locking failures in {set,clear}_extent_bit - Push up set_extent_bit errors to callers - Push up lock_extent errors to callers - Push up clear_extent_bit errors to callers - Push up unlock_extent errors to callers - Make pin_down_extent return void - Push up btrfs_pin_extent errors to

...wing warning: > drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used > uninitialized in this function > > The conditions that govern when queue is set aren't apparent to gcc. > > Setting queue = NULL clears the warning. > > Signed-off-by: Jeff Mahoney <jeffm at suse.com> Which gcc version produces this warning? I do not seem to see it with gcc 5.3.1. Also - use uninitialized_var then? > --- > > drivers/virtio/virtio_ring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/virtio/virtio_ring.c > ++...

...ccordingly. Debian/Ubuntu with AppArmor applied will also need a similar patch. Maintainers of btrfs under those distributions should build on this patch or, alternatively, alter their package descriptions to add -DREMOVE_SUID_PATH to the compiler command line. Signed-off-by: Jeff Mahoney <jeffm@suse.com> - --- compat.h | 15 +++++++++++++++ file.c | 5 +++++ 2 files changed, 20 insertions(+) - --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ b/compat.h 2008-02-06 16:46:13.000000000 -0500 @@ -0,0 +1,15 @@ +#ifndef _COMPAT_H_ +#define _COMPAT_H_ + + +/* + * Even if AppArmor...

This patch actually frees the hb set when the cluster dir is removed. fs/ocfs2/cluster/nodemanager.c | 1 + 1 files changed, 1 insertion(+) Signed-off-by: Jeff Mahoney <jeffm at suse.com> diff -ruNpX ../dontdiff linux-2.6.16-rc4.ocfs2-staging1/fs/ocfs2/cluster/nodemanager.c linux-2.6.16-rc4.ocfs2-staging2/fs/ocfs2/cluster/nodemanager.c --- linux-2.6.16-rc4.ocfs2-staging1/fs/ocfs2/cluster/nodemanager.c 2006-02-21 11:44:38.000000000 -0500 +++ linux-2.6.16-rc4.ocfs2-st...

Commit 699b6faa2ab283219914501d5117f8a93c7e441b allowed btrfs ACLs to be selectable, but put the option in the main fs/Kconfig, and didn''t make it depend on btrfs. This patch moves the option and adds the dependency. Signed-off-by: Jeff Mahoney <jeffm@suse.com> --- fs/Kconfig | 13 ------------- fs/btrfs/Kconfig | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 6198082..ef81718 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -51,19 +51,6 @@ source "fs/xfs/Kconfig&...

...| 12 ------------ fs/ocfs2/cluster/Makefile | 3 +-- fs/ocfs2/cluster/disk_heartbeat.c | 8 ++------ fs/ocfs2/cluster/disk_heartbeat.h | 2 ++ fs/ocfs2/cluster/nodemanager.c | 7 +++++++ 5 files changed, 12 insertions(+), 20 deletions(-) Signed-off-by: Jeff Mahoney <jeffm at suse.com> diff -ruNpX ../dontdiff linux-2.6.16-rc4.ocfs2-staging1/fs/Kconfig linux-2.6.16-rc4.ocfs2-staging2/fs/Kconfig --- linux-2.6.16-rc4.ocfs2-staging1/fs/Kconfig 2006-02-21 11:44:53.000000000 -0500 +++ linux-2.6.16-rc4.ocfs2-staging2/fs/Kconfig 2006-02-21 11:44:53.000000000 -0500 @@ -35...

...quorum.c | 82 +++++++++++++++++++++++++++++++++++++--- fs/ocfs2/cluster/quorum.h | 13 ++---- fs/ocfs2/cluster/tcp.c | 36 +++++------------ fs/ocfs2/cluster/tcp_internal.h | 12 ----- 7 files changed, 117 insertions(+), 48 deletions(-) Signed-off-by: Jeff Mahoney <jeffm at suse.com> diff -ruNpX dontdiff linux-2.6.15-staging1/fs/ocfs2/cluster/heartbeat.c linux-2.6.15-staging2/fs/ocfs2/cluster/heartbeat.c --- linux-2.6.15-staging1/fs/ocfs2/cluster/heartbeat.c 2006-01-08 18:23:29.376721976 -0500 +++ linux-2.6.15-staging2/fs/ocfs2/cluster/heartbeat.c 2006-01-08 18:...

Hello everyone, Btrfs v0.14 is now available for download. Please note the disk format has changed, and it is not compatible with older versions of Btrfs. For downloads and documention, please see the Btrfs project page: http://btrfs.wiki.kernel.org The oss.oracle.com Btrfs project page will soon start redirecting here. v0.14 has a few performance fixes and closes some races that could have

http://bugs.freedesktop.org/show_bug.cgi?id=26980 Summary: GT230M/nouveau: X server hangs spontaneously Product: xorg Version: 7.5 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org

The following series of patches comprises the bulk of our outstanding changes for Ocfs2. Aside from the usual set of cleanups and fixes that were inappropriate for 2.6.25, there are a few highlights: The '/sys/o2cb' directory has been moved to '/sys/fs/o2cb'. The new location meshes better with modern sysfs layout. A symbolic link has been placed in the old location so as to

...com> Jeff Garzik <jgarzik@redhat.com> Jeff Kirsher <jeffrey.kirsher@intel.com> Jeff Kirsher <jeffrey.r.kirsher@intel.com> Jeff Kirsher <jeffrey.t.kirsher@intel.com> Jeff Layton <jlayton@redhat.com> Jeff Layton <jlayton@samba.org> Jeff Mahoney <jeffm@suse.com> Jeff Moyer <jmoyer@redhat.com> Jeff Pieper <jeffrey.e.pieper@intel.com> Jeff Pieper <jeffrey.e.pieper@intel.com> Jeff Pieper <jeffrey.e.pieper@intel.com> Jeff Skirvin <jeffrey.d.skirvin@intel.com> Jeff Westfahl <jeff.westfahl@ni.com>...