Jeff Mahoney
2006-Feb-21 16:57 UTC
[Ocfs2-devel] [PATCH 07/14] ocfs2: actually free hb set on cluster removal
This patch actually frees the hb set when the cluster dir is removed. fs/ocfs2/cluster/nodemanager.c | 1 + 1 files changed, 1 insertion(+) Signed-off-by: Jeff Mahoney <jeffm at suse.com> diff -ruNpX ../dontdiff linux-2.6.16-rc4.ocfs2-staging1/fs/ocfs2/cluster/nodemanager.c linux-2.6.16-rc4.ocfs2-staging2/fs/ocfs2/cluster/nodemanager.c --- linux-2.6.16-rc4.ocfs2-staging1/fs/ocfs2/cluster/nodemanager.c 2006-02-21 11:44:38.000000000 -0500 +++ linux-2.6.16-rc4.ocfs2-staging2/fs/ocfs2/cluster/nodemanager.c 2006-02-21 11:44:38.000000000 -0500 @@ -701,6 +701,7 @@ static void o2nm_cluster_group_drop_item BUG_ON(o2nm_single_cluster != cluster); o2nm_single_cluster = NULL; + o2hb_free_hb_set(cluster->cl_group.default_groups[1]); for (i = 0; cluster->cl_group.default_groups[i]; i++) { killme = &cluster->cl_group.default_groups[i]->cg_item; cluster->cl_group.default_groups[i] = NULL;
Christoph Hellwig
2006-Feb-21 18:39 UTC
[Ocfs2-devel] [PATCH 07/14] ocfs2: actually free hb set on cluster removal
On Tue, Feb 21, 2006 at 11:57:31AM -0500, Jeff Mahoney wrote:> > This patch actually frees the hb set when the cluster dir is removed.shouldn't this as a fix be first in the series before your new features? In fact for future postings it would be nice if you sent a [PATCH x/n] series for fixes, and a second [PATCH x/n series for features.
Apparently Analagous Threads
- [PATCH 14/14] ocfs2: include disk heartbeat in ocfs2_nodemanager to avoid userspace changes
- [PATCH 01/11] ocfs2: event-driven quorum
- [PATCH 1/1] ocfs2/cluster: Make fence method configurable
- ERROR: failed to setup guest info [3.0.23c]
- [RFC: 2.6 patch] fs/ocfs2/: remove unused exports