search for: irpgo

Jake and I have been integrating IRPGO on PS4, and we've identified 3 remaining work items. - Driver changes We'd like to make IRPGO the default on PS4. We also think that it would be beneficial to make IRPGO the default PGO on all platforms (coverage would continue to use FE instr as it does currently, of course). In previou...

...8:56 PM, Xinliang David Li <davidxl at google.com <mailto:davidxl at google.com>> wrote: >> > >> > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com <mailto:chisophugis at gmail.com>> wrote: >> > Jake and I have been integrating IRPGO on PS4, and we've identified 3 remaining work items. >> > >> > Sean, thanks for the write up. It matches very well with what we think as well. >> >> + 1 >> >> >> > - Driver changes >> > >> > We'd like to make IRPGO the...

...:56 PM, Xinliang David Li <davidxl at google.com> >>>>> wrote: >>>>> > >>>>> > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> >>>>> wrote: >>>>> > Jake and I have been integrating IRPGO on PS4, and we've identified >>>>> 3 remaining work items. >>>>> > >>>>> > Sean, thanks for the write up. It matches very well with what we >>>>> think as well. >>>>> >>>>> + 1 >>>>> &...

...google.com> >>>>>>> wrote: >>>>>>> > >>>>>>> > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> >>>>>>> wrote: >>>>>>> > Jake and I have been integrating IRPGO on PS4, and we've >>>>>>> identified 3 remaining work items. >>>>>>> > >>>>>>> > Sean, thanks for the write up. It matches very well with what we >>>>>>> think as well. >>>>>>> >&gt...

...liang David Li <davidxl at google.com <mailto:davidxl at google.com>> wrote: >>> > >>> > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com <mailto:chisophugis at gmail.com>> wrote: >>> > Jake and I have been integrating IRPGO on PS4, and we've identified 3 remaining work items. >>> > >>> > Sean, thanks for the write up. It matches very well with what we think as well. >>> >>> + 1 >>> >>> >>> > - Driver changes >>> > >>> &...

On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> wrote: > Jake and I have been integrating IRPGO on PS4, and we've identified 3 > remaining work items. > > > - Driver changes > > We'd like to make IRPGO the default on PS4. We also think that it would be > beneficial to make IRPGO the default PGO on all platforms (coverage would > continue to use FE instr as it d...

On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> wrote: > Jake and I have been integrating IRPGO on PS4, and we've identified 3 > remaining work items. > Sean, thanks for the write up. It matches very well with what we think as well. > > > - Driver changes > > We'd like to make IRPGO the default on PS4. We also think that it would be > beneficial to make IRPGO...

...id Li <davidxl at google.com> >>>>>> wrote: >>>>>> > >>>>>> > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> >>>>>> wrote: >>>>>> > Jake and I have been integrating IRPGO on PS4, and we've identified >>>>>> 3 remaining work items. >>>>>> > >>>>>> > Sean, thanks for the write up. It matches very well with what we >>>>>> think as well. >>>>>> >>>>>> +...

...3, 2016, at 8:56 PM, Xinliang David Li <davidxl at google.com <mailto:davidxl at google.com>> wrote: > > > > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com <mailto:chisophugis at gmail.com>> wrote: > > Jake and I have been integrating IRPGO on PS4, and we've identified 3 remaining work items. > > > > Sean, thanks for the write up. It matches very well with what we think as well. > > + 1 > > > > - Driver changes > > > > We'd like to make IRPGO the default on PS4. We also think that i...

On Wed, May 25, 2016 at 12:12 PM, Sean Silva <chisophugis at gmail.com> wrote: > > > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> wrote: > >> Jake and I have been integrating IRPGO on PS4, and we've identified 3 >> remaining work items. >> >> >> - Driver changes >> >> We'd like to make IRPGO the default on PS4. We also think that it would >> be beneficial to make IRPGO the default PGO on all platforms (coverage >> would...

...dant Kumar <vsk at apple.com> wrote: > > > On May 23, 2016, at 8:56 PM, Xinliang David Li <davidxl at google.com> > wrote: > > > > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> > wrote: > > Jake and I have been integrating IRPGO on PS4, and we've identified 3 > remaining work items. > > > > Sean, thanks for the write up. It matches very well with what we think > as well. > > + 1 > > > > - Driver changes > > > > We'd like to make IRPGO the default on PS4. We also think...

> On May 23, 2016, at 8:56 PM, Xinliang David Li <davidxl at google.com> wrote: > > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> wrote: > Jake and I have been integrating IRPGO on PS4, and we've identified 3 remaining work items. > > Sean, thanks for the write up. It matches very well with what we think as well. + 1 > - Driver changes > > We'd like to make IRPGO the default on PS4. We also think that it would be beneficial to make IRPGO the def...

...om> wrote: > > > On Wed, May 25, 2016 at 12:12 PM, Sean Silva <chisophugis at gmail.com> > wrote: > >> >> >> On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> >> wrote: >> >>> Jake and I have been integrating IRPGO on PS4, and we've identified 3 >>> remaining work items. >>> >>> >>> - Driver changes >>> >>> We'd like to make IRPGO the default on PS4. We also think that it would >>> be beneficial to make IRPGO the default PGO on all platfor...

...gt; wrote: > >> >> > On May 23, 2016, at 8:56 PM, Xinliang David Li <davidxl at google.com> >> wrote: >> > >> > On Mon, May 23, 2016 at 8:23 PM, Sean Silva <chisophugis at gmail.com> >> wrote: >> > Jake and I have been integrating IRPGO on PS4, and we've identified 3 >> remaining work items. >> > >> > Sean, thanks for the write up. It matches very well with what we think >> as well. >> >> + 1 >> >> >> > - Driver changes >> > >> > We'd like to...

...quot;FE". Maybe "source"? And instead of "IR", "llvm-ir" or something? > It's a bit ugly because the meaning of -fprofile-instr-generate becomes context-sensitive. But, (1) it doesn't break existing common workflows and (2) it makes it easier to ship IRPGO. The big caveat here is that we'll need to wait a bit and see if our internal users are OK with this. > > One alternative is to introduce a separate driver flag for IRPGO. This might not work well for Sony's existing users. I'd be interested in any feedback about this approach....

> On Jun 2, 2016, at 5:30 PM, Sean Silva <chisophugis at gmail.com> wrote: > > This also means that if the consensus is that -fprofile-instr-generate should really change its meaning to mean IRPGO, I’m open to having this internal patch on our side. > > Yeah, it sounds like someone is going to have to keep a "private patch" to change the default. At that point doing a switch on the triple in upstream seems preferable though :/ I don’t see why a private patch would be neede...

...he downside is 'Clang' is clearly tied to Clang, but not any other FEs. David > > > It's a bit ugly because the meaning of -fprofile-instr-generate becomes > context-sensitive. But, (1) it doesn't break existing common workflows and > (2) it makes it easier to ship IRPGO. The big caveat here is that we'll > need to wait a bit and see if our internal users are OK with this. > > > > One alternative is to introduce a separate driver flag for IRPGO. This > might not work well for Sony's existing users. I'd be interested in any > feedbac...

There is some misunderstanding about the intention of this flag. The purpose of the flag is not to turn on profile instrumentation (which already has -fprofile-instr-generate or -fprofile-generate for it), but to select which instrumentors to use for PGO (IR or FE). I prefer fewer flags too, but sharing flags for completely different purpose does not seem like the right thing to do. David On

On Fri, Jun 24, 2016 at 1:44 AM Eric Christopher via llvm-dev < llvm-dev at lists.llvm.org> wrote: > > > On Thu, Jun 2, 2016, 6:41 PM Xinliang David Li via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> >> Sounds fine to me, though I am not a fan of using unstable in the option. >> I think a more meaningful way (that capture the essence of the

On Sun, Jun 26, 2016 at 10:21 PM, Dean Michael Berris <dberris at google.com> wrote: > > > On Mon, Jun 27, 2016 at 2:53 PM Xinliang David Li <davidxl at google.com> > wrote: > >> There is some misunderstanding about the intention of this flag. The >> purpose of the flag is not to turn on profile instrumentation (which >> already has