search for: interactive_loop

https://bugzilla.mindrot.org/show_bug.cgi?id=2238 Bug ID: 2238 Summary: sftp exits on bad tab completion Product: Portable OpenSSH Version: 6.6p1 Hardware: All OS: OpenBSD Status: NEW Severity: minor Priority: P5 Component: sftp Assignee: unassigned-bugs at mindrot.org

...to add 'init_prng();' to the main() of sftp.c. Why sftp is caring about such things boggles my mind. =) Scp sure does not nor does sftp-server, and it was my impression (by glacing at the code) that sftp.c pretty much piggy backing ontop of ssh like scp. Looks to be somewhere in the interactive_loop() code. - Ben

...RENAME, REMOTE }, + { "rm", I_RM, REMOTE }, + { "rmdir", I_RMDIR, REMOTE }, + { "symlink", I_SYMLINK, REMOTE }, + { "version", I_VERSION, NOARGS }, + { "!", I_SHELL, NOARGS }, + { "?", I_HELP, NOARGS }, + { NULL, -1, -1} }; int interactive_loop(int fd_in, int fd_out, char *file1, char *file2); @@ -1231,13 +1241,194 @@ return ("sftp> "); } +/* + * Before Asking to be included: + * XXX Support Quoting in file completion + * XXX Fix MAXARG to be more dynamic + * XXX Better column display of multi-matches + * XXX Kill the...

...RENAME, REMOTE }, + { "rm", I_RM, REMOTE }, + { "rmdir", I_RMDIR, REMOTE }, + { "symlink", I_SYMLINK, REMOTE }, + { "version", I_VERSION, NOARGS }, + { "!", I_SHELL, NOARGS }, + { "?", I_HELP, NOARGS }, + { NULL, -1, -1} }; int interactive_loop(int fd_in, int fd_out, char *file1, char *file2); @@ -1344,13 +1357,237 @@ return ("sftp> "); } +void +complete_display(char **list, u_int len) +{ + u_int y, m = 0, width = 80, columns = 1, colspace = 0; + struct winsize ws; + + /* Count entries for sort and find longest filename...

...warning: assignment makes pointer from integer without a cast sftp-int.c: In function `sftp_completion': sftp-int.c:986: warning: implicit declaration of function `rl_completion_matches' sftp-int.c:986: warning: assignment makes pointer from integer without a cast sftp-int.c: In function `interactive_loop': sftp-int.c:1080: warning: assignment from incompatible pointer type *** Error code 1 libedit doesn't seem to have either of rl_completion_append_character or rl_completion_display_matches_hook. ------- You are receiving this mail because: ------- You are on the CC list for the bug,...

...OpenSSH-4.1p1 under the following environment: CPU: i386 family OS: FreeBSD 4.11-RELEASE Compiler: gcc-2.95.4 (/usr/bin/gcc) ---- libedit: (located at /usr/lib/) Building fails with the following messages: ---------- gcc -g -O2 -Wall ...... -DHAVE_CONFIG_H -c sftp.c sftp.c: In function `interactive_loop': sftp.c:1247: too many arguments to function `el_init' sftp.c:1251: `H_SETSIZE' undeclared (first use in this function) sftp.c:1251: (Each undeclared identifier is reported only once sftp.c:1251: for each function it appears in.) sftp.c:1251: warning: passing arg 2 of `history' mak...

...o.6 #1 0x0000000000404dd2 in parse_args (conn=0x13fbc0c0, cmd=<value optimized out>, pwd=0x7fff330ac518, err_abort=0) at sftp.c:1145 #2 parse_dispatch_command (conn=0x13fbc0c0, cmd=<value optimized out>, pwd=0x7fff330ac518, err_abort=0) at sftp.c:1300 #3 0x0000000000406327 in interactive_loop (conn=0x13fbc0c0, file1=<value optimized out>, file2=<value optimized out>) at sftp.c:1990 #4 0x0000000000406913 in main (argc=<value optimized out>, argv=0x13fbc030) at sftp.c:2273 (gdb) The problem appears to be that argv[0] is NULL, and there is no check for this prior...

...another channel into the same connection. After the user has quit the sftp prompt, the client returns to the original ssh with possible shell prompt or whatever. The actual implementation is rather simple: The client basically forks another process and runs a slightly modified version of the sftp interactive_loop(). A little bit of hacking is needed so that the primary ssh2_channel won't take the input/output while the sftp session is active. The forking ensures that clientloop.c's select(2) is performed normally so that the forwarded connections still work. I can provide the patches if needed but...

https://bugzilla.mindrot.org/show_bug.cgi?id=1990 Corentin Delcourt <codl at codl.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |codl at codl.fr --- Comment #8 from Corentin Delcourt <codl at codl.fr> --- Note that Arch Linux's

Things that are still outstanding: 1) Solaris/Redhat/HPUX session.c patch. I've not seen a ya or na on Kevin's pam patch from the Solaris group. 2) Odd Redhat/Debian scp/ssh issues. .. I'm baffled, and I can't replicate the bug. Nor have I seen anything remotely like it reported. 3) SCO.. Is it happy yet for compiling? =) Completed: 1) mdoc2man.pl .. Commited into