http://bugzilla.mindrot.org/show_bug.cgi?id=200 ------- Additional Comments From dtucker at zip.com.au 2002-06-12 00:21 ------- I tried it on NetBSD/sparc 1.5.2. The first problem was obvious: gcc [flags] -c sftp-int.c sftp-int.c:32: readline/readline.h: No such file or directory sftp-int.c:33: readline/history.h: No such file or directory *** Error code 1 readline.h and history.h are in /usr/include/. Fixing that and moving on, I got gcc [flags] -c sftp-int.c sftp-int.c: In function `rl_remote_match': sftp-int.c:901: `rl_completion_append_character' undeclared (first use in this function) sftp-int.c:901: (Each undeclared identifier is reported only once sftp-int.c:901: for each function it appears in.) sftp-int.c: In function `rl_remote_list': sftp-int.c:930: warning: implicit declaration of function `rl_display_match_list' sftp-int.c:931: warning: implicit declaration of function `rl_forced_update_display' sftp-int.c: In function `glob_match': sftp-int.c:942: `rl_completion_display_matches_hook' undeclared (first use in this function) sftp-int.c:948: warning: implicit declaration of function `rl_filename_completion_function' sftp-int.c:948: warning: assignment makes pointer from integer without a cast sftp-int.c: In function `sftp_completion': sftp-int.c:986: warning: implicit declaration of function `rl_completion_matches' sftp-int.c:986: warning: assignment makes pointer from integer without a cast sftp-int.c: In function `interactive_loop': sftp-int.c:1080: warning: assignment from incompatible pointer type *** Error code 1 libedit doesn't seem to have either of rl_completion_append_character or rl_completion_display_matches_hook. ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
http://bugzilla.mindrot.org/show_bug.cgi?id=200 ------- Additional Comments From mouring at eviladmin.org 2002-06-12 01:19 ------- NetBSD is wrong in not putting it in <readline/*.h>. Even their CVS tree admits to it: "Standard location of readline headers is /usr/include/readline/, so install them there. readline.h of libedit had to move to subdirectory 'readline', due to the way BSD makefiles work; this is better than potentially fragile Makefile hacks" Hmm.. From readline.h on NetBSD (cvs) extern int rl_completion_append_character; No history.h (looks like history.h and readline.h were merged.. BAD NetBSD, BAD). But rl_completion_display_matches_hook looks like it needs to be fleshed out in libedit unless someone can tell me a more portable way of handling glob_match() when switching between local, remote, and no globing support. I should grab the OpenBSD patch that was recently submited, but not commited yet. ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.