search for: instructionutil

...). Within LLVM, there are five other similar functions defined. I think it's time to define/declare this function in one place. Define in include/llvm/IR/Instructions.h as an inline function? Declare in include/llvm/IR/Instructions.h and define in lib/IR/Instructions.cpp? New files? (e.g., IR/InstructionUtils.h and .cpp?) Other suggesctions? I suggest taking the implementation from Analysis/Delinearization.cpp, and create IR/InstructionUtils.h and .cpp. They can then be used to consolidate other Instruction helper functions to one place. Objections? Alternatives? Thanks, Hideki ------...

...her similar > functions defined. > > I think it's time to define/declare this function in one place. > > Define in include/llvm/IR/Instructions.h as an inline function? > Declare in include/llvm/IR/Instructions.h and define in lib/IR/Instructions.cpp? > New files? (e.g., IR/InstructionUtils.h and .cpp?) > Other suggesctions? > > I suggest taking the implementation from Analysis/Delinearization.cpp, > and create IR/InstructionUtils.h and .cpp. They can then be used to > consolidate other Instruction helper functions to one place. What other instruction h...

...er similar > functions defined. > > I think it's time to define/declare this function in one place. > > Define in include/llvm/IR/Instructions.h as an inline function? > Declare in include/llvm/IR/Instructions.h and define in lib/IR/Instructions.cpp? > New files? (e.g., IR/InstructionUtils.h and .cpp?) > Other suggesctions? > > I suggest taking the implementation from Analysis/Delinearization.cpp, > and create IR/InstructionUtils.h and .cpp. They can then be used to > consolidate other Instruction helper functions to one place. What other instruction...