Displaying 3 results from an estimated 3 matches for "instructionutils".
2018 Feb 06
2
6 separate instances of static getPointerOperand(). Time to consolidate?
...). Within LLVM, there are
five other similar functions defined.
I think it's time to define/declare this function in one place.
Define in include/llvm/IR/Instructions.h as an inline function?
Declare in include/llvm/IR/Instructions.h and define in lib/IR/Instructions.cpp?
New files? (e.g., IR/InstructionUtils.h and .cpp?)
Other suggesctions?
I suggest taking the implementation from Analysis/Delinearization.cpp, and create
IR/InstructionUtils.h and .cpp. They can then be used to consolidate other
Instruction helper functions to one place.
Objections? Alternatives?
Thanks,
Hideki
-------...
2018 Feb 06
0
6 separate instances of static getPointerOperand(). Time to consolidate?
...her similar
> functions defined.
>
> I think it's time to define/declare this function in one place.
>
> Define in include/llvm/IR/Instructions.h as an inline function?
> Declare in include/llvm/IR/Instructions.h and define in lib/IR/Instructions.cpp?
> New files? (e.g., IR/InstructionUtils.h and .cpp?)
> Other suggesctions?
>
> I suggest taking the implementation from Analysis/Delinearization.cpp,
> and create IR/InstructionUtils.h and .cpp. They can then be used to
> consolidate other Instruction helper functions to one place.
What other instruction he...
2018 Feb 06
1
6 separate instances of static getPointerOperand(). Time to consolidate?
...er similar
> functions defined.
>
> I think it's time to define/declare this function in one place.
>
> Define in include/llvm/IR/Instructions.h as an inline function?
> Declare in include/llvm/IR/Instructions.h and define in lib/IR/Instructions.cpp?
> New files? (e.g., IR/InstructionUtils.h and .cpp?)
> Other suggesctions?
>
> I suggest taking the implementation from Analysis/Delinearization.cpp,
> and create IR/InstructionUtils.h and .cpp. They can then be used to
> consolidate other Instruction helper functions to one place.
What other instruction...