search for: inet_ntop

I found that inet_ntop.c was depending on the return value of sprintf to return an int, but on SunOS4 it returns a char *. Snprintf is preferred anyway, so here's a patch to change the calls to use snprintf. Applies cleanly to the current CVS, and it was the only patch I need to apply to get 2.9p1 to build on SunOS...

http://bugzilla.mindrot.org/show_bug.cgi?id=847 Summary: Including arpa/nameser.h in inet_ntop.c can cause compile problems Product: Portable OpenSSH Version: 3.8p1 Platform: All OS/Version: SunOS Status: NEW Severity: normal Priority: P3 Component: Build system AssignedTo: openssh-bu...

To whoever it may help, My flavor of Solaris 2.7 was not able to compile rsync 2.5.5 with the vanilla "./configure; make". Three functions where missing : inet_ntop, inet_pton, inet_addr There are replacement inet_ntop and inet_pton in the distribution tree, so it's easy to change the Makefile and have them compiled and included by a simple "make". However, the inet_addr is missing on the system, so I had to write a replacement. Here is the (ve...

http://bugzilla.mindrot.org/show_bug.cgi?id=847 dtucker at zip.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED ------- Comment #6 from dtucker at zip.com.au 2006-10-07 11:36 ------- Change all RESOLVED bug to CLOSED with the exception

...* Try to push the appropriate streams modules, as described * in Solaris pts(7). @@ -112,7 +111,6 @@ openpty(int *amaster, int *aslave, char # ifndef __hpux ioctl(*aslave, I_PUSH, "ttcompat"); # endif /* __hpux */ -#endif /* HAVE_CYGWIN */ return (0); Index: openbsd-compat/inet_ntop.c =================================================================== RCS file: /cvs/openssh_cvs/openbsd-compat/inet_ntop.c,v retrieving revision 1.9 diff -p -u -r1.9 inet_ntop.c --- openbsd-compat/inet_ntop.c 24 Nov 2003 02:33:34 -0000 1.9 +++ openbsd-compat/inet_ntop.c 24 Feb 2005 11:30:30 -0000...

...struct br_mdb_entry *e) SPRINT_BUF(abuf); if (e->addr.proto == htons(ETH_P_IP)) - fprintf(f, "bridge %s port %s group %s\n", ll_index_to_name(ifindex), + fprintf(f, "bridge %s port %s group %s %s\n", ll_index_to_name(ifindex), ll_index_to_name(e->ifindex), - inet_ntop(AF_INET, &e->addr.u.ip4, abuf, sizeof(abuf))); + inet_ntop(AF_INET, &e->addr.u.ip4, abuf, sizeof(abuf)), + (e->state & MDB_PERMANENT) ? "permanent" : "temp"); else - fprintf(f, "bridge %s port %s group %s\n", ll_index_to_name(ifindex), + fp...

.../samba/netcmd/dns.py", line >> 225, in print_serverinfo >>     dns_addr_array_string(serverinfo.aipServerAddrs)) >>   File >> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line >> 157, in dns_addr_array_string >>     addr = inet_ntop(AF_INET, x) >> >> I'm not experiencing any DNS issues so I believe this may be a bug with >> the move to python3 Am I correct? > Yes, you are very likely correct. > > Does the attached patch help? > > If you can confirm this at > https://bugzilla.samba.org/sh...

..._CHECK_FUNC(getaddrinfo) isn't enough to test for getaddrinfo. Best to AC_TRY_LINK so the #define takes effect. -- albert chin (china@thewrittenword.com) -- snip snip --- configure.in.orig Thu Jan 3 19:03:54 2002 +++ configure.in Thu Jan 3 19:09:17 2002 @@ -273,7 +273,18 @@ AC_CHECK_FUNCS(inet_ntop, , AC_LIBOBJ(lib/inet_ntop)) AC_CHECK_FUNCS(inet_pton, , AC_LIBOBJ(lib/inet_pton)) -AC_CHECK_FUNCS(getaddrinfo, , AC_LIBOBJ(lib/getaddrinfo)) +# Tru64 UNIX has getaddrinfo() but has it renamed in libc as +# something else so we must include <netdb.h> to get the +# redefinition. +AC_MSG_C...

A build of rsync-2.6.9pre2 on DEC Alpha OSF/1 4.0 failed because of an undeclared variable at lib/inet_ntop.c:84: memcpy(dst, tmp, len + 1); len is not declared; the code looks like the third argument should instead be the value strlen(tmp) + 1 I made that change, restarted the build and validation, and got this report: ----- daemon-gzip-download rsyncd.log ends FAIL daemon-gzip-download -----...

...e 3.0.8 (the same in 3.1) we have this around line 300 in socket.c: break; } freeaddrinfo(res0); if (s < 0) { char buf[2048]; for (res = res0, j = 0; res; res = res->ai_next, j++) { if (errnos[j] == 0) continue; if (inet_ntop(res->ai_family, res->ai_addr->sa_data + 2, buf, sizeof buf) == NULL) strlcpy(buf, "*inet_ntop failed*", sizeof buf); rsyserr(FERROR, errnos[j], "failed to connect to %s (%s)", h, buf); } s = -1; } res0 is freed but keeps...

..."/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line 225, in print_serverinfo     dns_addr_array_string(serverinfo.aipServerAddrs))   File "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line 157, in dns_addr_array_string     addr = inet_ntop(AF_INET, x) I'm not experiencing any DNS issues so I believe this may be a bug with the move to python3 Am I correct? Ubuntu 16.04, samba 4.10.3. Thanks. -James

...g for off_t... yes checking for size_t... yes checking for pid_t... yes checking type of array argument to getgroups... gid_t checking for struct stat.st_rdev... yes checking for ino_t... yes checking for socklen_t... yes checking for errno in errno.h... yes checking for connect... yes checking for inet_ntop in -lresolv... yes configure: Looking in libraries: -lresolv checking for inet_ntop... yes checking for inet_pton... yes checking for getaddrinfo... yes checking for getnameinfo... yes checking for struct sockaddr.sa_len... no checking for strcasecmp... yes checking whether utime accepts a null arg...

...library, daemon, and C tools). Among directly and indirectly modules used previous (and now no more), they are: cycle-check dev-ino dup3 dup3-tests fcntl-safer fcntl-safer-tests filevercmp filevercmp-tests fts getaddrinfo getaddrinfo-tests hostent i-ring i-ring-tests inet_ntop inet_ntop-tests isatty isatty-tests openat-safer openat-safer-tests opendirat ptsname_r ptsname_r-tests servent ttyname_r ttyname_r-tests Some of the removed modules are still used pulled indirectly as dependency of other modules. There should be no behaviour change on recen...

...+++ configure Thu Jun 7 14:13:40 2001 @@ -3184,7 +3184,7 @@ fi -for ac_func in arc4random atexit b64_ntop bcopy bindresvport_sa clock fchown fchmod freeaddrinfo futimes gai_strerror getcwd getaddrinfo getgrouplist getnameinfo getrlimit getrusage getttyent getusershell glob inet_aton inet_ntoa inet_ntop innetgr login_getcapbool md5_crypt memmove mkdtemp on_exit openpty realpath rresvport_af setdtablesize setenv setegid seteuid setlogin setproctitle setresgid setreuid setrlimit setsid sigaction sigvec snprintf strerror strlcat strlcpy strmode strsep strtok_r sysconf tcgetpgrp utimes vsnprintf vhang...

...lib/python3.5/site-packages/samba/netcmd/dns.py", line > 225, in print_serverinfo >     dns_addr_array_string(serverinfo.aipServerAddrs)) >   File > "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line > 157, in dns_addr_array_string >     addr = inet_ntop(AF_INET, x) > > I'm not experiencing any DNS issues so I believe this may be a bug with > the move to python3 Am I correct? Yes, you are very likely correct. Does the attached patch help? If you can confirm this at https://bugzilla.samba.org/show_bug.cgi?id=13965 it can get into th...

...AC_CONFIG_LIBOBJ_DIR([lib]) + # We must decide this before testing the compiler. # Please allow this to default to yes, so that your users have more @@ -488,8 +492,7 @@ AC_DEFINE_UNQUOTED(ICONV_CONST, $am_cv_proto_iconv_arg1, dnl AC_MSG_NOTICE([Looking in libraries: $LIBS]) -AC_CHECK_FUNCS(inet_ntop, , [AC_LIBOBJ(lib/inet_ntop)]) -AC_CHECK_FUNCS(inet_pton, , [AC_LIBOBJ(lib/inet_pton)]) +AC_REPLACE_FUNCS([inet_ntop inet_pton]) AC_HAVE_TYPE([struct addrinfo], [#include <netdb.h>]) AC_HAVE_TYPE([struct sockaddr_storage], [#include <sys/types.h> @@ -521,9 +524,9 @@ if test x"$...

...ddrinfo function Arjen, I am trying to merge the windows_port branch with trunk and I have some issues. First, getaddrinfo seems to be supported on Win32 platforms only since Windows XP. So I can compile binaries for Win32 but we will loose Win NT/2000/98 compatibility here. Second, it seems that inet_ntop is supported only since Windows Vista. Which remove Windows XP from the compatibility list. Of course we can try to provide equivalent functions but is this commit really worth the extra work ? Moreover, what will be the impact of this commit on other old systems ? Maybe we could simply revert thi...

...+{ + struct sockaddr_in *addr = (struct sockaddr_in *) sa; + struct sockaddr_in6 *addr6 = (struct sockaddr_in6 *) sa; + union { + char straddr[INET_ADDRSTRLEN]; + char straddr6[INET6_ADDRSTRLEN]; + } u; + int r; + char *str; + + switch (addr->sin_family) { + case AF_INET: + if (inet_ntop (AF_INET, &addr->sin_addr, + u.straddr, sizeof u.straddr) == NULL) { + nbdkit_error ("inet_ntop: %m"); + return -1; + } + r = asprintf (&str, "%s:%d", u.straddr, ntohs (addr->sin_port)); + if (r == -1) { + nbdkit_error (&qu...

...ous (and now no more), they are: > > cycle-check > dev-ino > dup3 > dup3-tests > fcntl-safer > fcntl-safer-tests > filevercmp > filevercmp-tests > fts > getaddrinfo > getaddrinfo-tests > hostent > i-ring > i-ring-tests > inet_ntop > inet_ntop-tests > isatty > isatty-tests > openat-safer > openat-safer-tests > opendirat > ptsname_r > ptsname_r-tests > servent > ttyname_r > ttyname_r-tests > > Some of the removed modules are still used pulled indirectly as > depe...

...drs failed\n"); + return 1; + } + + curp = ifap; + while (curp != NULL) { + if ((curp->ifa_addr != NULL) && + (curp->ifa_addr->sa_family == family)) { + if (family == AF_INET) { + struct sockaddr_in *addr = + (struct sockaddr_in *) curp->ifa_addr; + + str = inet_ntop(family, &addr->sin_addr, + tmp, 50); + if (str == NULL) { + strcpy(buffer, "inet_ntop failed\n"); + error = 1; + goto getaddr_done; + } + if (offset == 0) + strcpy(buffer, tmp); + else + strcat(buffer, tmp); + strcat(buffer, ";"); +...