openssh bugs - Apr 2004 - [Bug 847] Including arpa/nameser.h in inet_ntop.c can cause compile problems

http://bugzilla.mindrot.org/show_bug.cgi?id=847

           Summary: Including arpa/nameser.h in inet_ntop.c can cause
                    compile problems
           Product: Portable OpenSSH
           Version: 3.8p1
          Platform: All
        OS/Version: SunOS
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Build system
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: mindrot at ee.lbl.gov


When compiling under SunOS 4.1.4, it looks like arpa/nameser.h is
included twice (see bug.txt attachment).
 
Removing the include doesn't cause problems under Solaris 5.7 or
FreeBSD 4.8-RELEASE. I suspect it's not really needed at all.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=847





------- Additional Comments From mindrot at ee.lbl.gov  2004-04-21 12:50 -------
Created an attachment (id=607)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=607&action=view)
compilation errors




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=847





------- Additional Comments From mindrot at ee.lbl.gov  2004-04-21 12:51 -------
Created an attachment (id=608)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=608&action=view)
propsed patch




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=847

mindrot at ee.lbl.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Attachment #608|propsed patch               |proposed patch
        description|                            |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=847

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



------- Additional Comments From dtucker at zip.com.au  2004-04-21 13:17 -------
There's still a chance that some platform, somewhere needs it.  Does the
system
<arpa/nameser.h> define either _ARPA_NAMESER_H_ or __NAMESER?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=847





------- Additional Comments From tim at multitalents.net  2004-04-21 13:20
-------
Craig,

Use cc -H to see where the extra arpa/nameser.h is coming from.
I think you find it's not from OpenSSH.

Even if it was, why are your system headers not protecting themselvs from
multiple includes?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.