search for: have_tcgetpgrp

...: other Status: NEW Severity: normal Priority: P2 Component: Build system AssignedTo: openssh-unix-dev at mindrot.org ReportedBy: wendyp at cray.com when foregroundproc() got put into progressmeter.c, the return line got changed from #ifdef HAVE_TCGETPGRP return ((ctty_pgrp = tcgetpgrp(STDOUT_FILENO)) != -1 && ctty_pgrp == pgrp); #else return ((ioctl(STDOUT_FILENO, TIOCGPGRP, &ctty_pgrp) != -1 && ctty_pgrp == pgrp)); #endif to return ((ioctl(STDOUT_FILENO, TIOCGPGRP, &am...

...'s probably needed for other systems, too. Does anybody know of other systems? Otherwise I'll send a patch which defines it only for Cygwin. But especially, I don't see a reason why the good old foregroundproc() function unconditionally uses ioctl(TIOCGPGRP) now instead of testing for HAVE_TCGETPGRP as before, when the function was in scp.c. Worse, the test for tcgetpgrp has been removed from configure.ac. This definitely is a showstopper for Cygwin. I reverted the patch in my local sandbox already and it builds again. I'd like to know if I should send the patch or if it's not need...

https://bugzilla.samba.org/show_bug.cgi?id=2130 ------- Additional Comments From lukem@NetBSD.org 2004-12-08 03:06 ------- Created an attachment (id=828) --> (https://bugzilla.samba.org/attachment.cgi?id=828&action=view) rsync-progress.patch -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA

...t save_errno = errno; - - progressmeter(0); - mysignal(SIGALRM, updateprogressmeter); - alarm(PROGRESSTIME); - errno = save_errno; -} - -static int -foregroundproc(void) -{ - static pid_t pgrp = -1; - int ctty_pgrp; - - if (pgrp == -1) - pgrp = getpgrp(); + int save_errno = errno; -#ifdef HAVE_TCGETPGRP - return ((ctty_pgrp = tcgetpgrp(STDOUT_FILENO)) != -1 && - ctty_pgrp == pgrp); -#else - return ((ioctl(STDOUT_FILENO, TIOCGPGRP, &ctty_pgrp) != -1 && - ctty_pgrp == pgrp)); -#endif -} -void -progressmeter(int flag) -{ - static const char prefixes[] = " KMGTP"; -...

http://bugzilla.mindrot.org/show_bug.cgi?id=651 ------- Additional Comments From vikashb at comparexafrica.co.za 2003-12-30 16:39 ------- tried openssh-SNAP-20031223 does not compile: (cd openbsd-compat && make) gcc -g -O2 -Wall -Wpointer-arith -Wno-uninitialized -I. -I.. -I. -I./.. -I/usr/local/ssl/include -Dftruncate=chsize -I/usr/local/include -DHAVE_CONFIG_H -c

...ID 1 #define HAVE_SETGROUPS 1 #define HAVE_SETREUID 1 #define HAVE_SETRLIMIT 1 #define HAVE_SETSID 1 #define HAVE_SETVBUF 1 #define HAVE_SIGACTION 1 #define HAVE_SNPRINTF 1 #define HAVE_SOCKETPAIR 1 #define HAVE_STRERROR 1 #define HAVE_STRLCAT 1 #define HAVE_STRLCPY 1 #define HAVE_SYSCONF 1 #define HAVE_TCGETPGRP 1 #define HAVE_TRUNCATE 1 #define HAVE_UTIMES 1 #define HAVE_VHANGUP 1 #define HAVE_VSNPRINTF 1 #define HAVE_WAITPID 1 #define HAVE_DIRNAME 1 #define HAVE_LIBGEN_H 1 #define HAVE_GETTIMEOFDAY 1 #define HAVE_TIME 1 #define HAVE_ENDUTENT 1 #define HAVE_GETUTENT 1 #define HAVE_GETUTID 1 #define HAVE_G...

..._H 1 #define HAVE_SYS_STAT_H 1 /* #undef HAVE_SYS_STREAM_H */ #define HAVE_SYS_STROPTS_H 1 /* #undef HAVE_SYS_STRTIO_H */ /* #undef HAVE_SYS_SYSLOG_H */ #define HAVE_SYS_SYSMACROS_H 1 /* #undef HAVE_SYS_TIMERS_H */ #define HAVE_SYS_TIME_H 1 #define HAVE_SYS_TYPES_H 1 #define HAVE_SYS_UN_H 1 #define HAVE_TCGETPGRP 1 #define HAVE_TCSENDBREAK 1 #define HAVE_TIME 1 #define HAVE_TIME_H 1 /* #undef HAVE_TMPDIR_H */ #define HAVE_TRUNCATE 1 #define HAVE_TTYENT_H 1 #define HAVE_UNISTD_H 1 #define HAVE_UNSETENV 1 #define HAVE_UPDWTMP 1 #define HAVE_UPDWTMPX 1 /* #undef HAVE_USERSEC_H */ /* #undef HAVE_UTIL_H */ #defi...

...#define HAVE_STRUCT_TIMEVAL 1 #define HAVE_SYSCONF 1 #define HAVE_SYS_CDEFS_H 1 #define HAVE_SYS_ERRLIST 1 #define HAVE_SYS_MMAN_H 1 #define HAVE_SYS_NERR 1 #define HAVE_SYS_SELECT_H 1 #define HAVE_SYS_STAT_H 1 #define HAVE_SYS_SYSMACROS_H 1 #define HAVE_SYS_TIME_H 1 #define HAVE_SYS_UN_H 1 #define HAVE_TCGETPGRP 1 #define HAVE_TCSENDBREAK 1 #define HAVE_TIME 1 #define HAVE_TIME_H 1 #define HAVE_TIME_IN_UTMP 1 #define HAVE_TIME_IN_UTMPX 1 #define HAVE_TRUNCATE 1 #define HAVE_TV_IN_UTMPX 1 #define HAVE_TYPE_IN_UTMP 1 #define HAVE_TYPE_IN_UTMPX 1 #define HAVE_UINTXX_T 1 #define HAVE_UNISTD_H 1 #define HAVE_UN...