rsync - Dec 2004 - [Bug 2130] suppressing progress bar when not the foreground process

https://bugzilla.samba.org/show_bug.cgi?id=2130





------- Additional Comments From lukem@NetBSD.org  2004-12-08 03:06 -------
Created an attachment (id=828)
 --> (https://bugzilla.samba.org/attachment.cgi?id=828&action=view)
rsync-progress.patch


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2130





------- Additional Comments From wayned@samba.org  2004-12-14 12:01 -------
Created an attachment (id=843)
 --> (https://bugzilla.samba.org/attachment.cgi?id=843&action=view)
My version of the patch to progress.c

I'm considering this change, and I think it looks good with a couple changes
to
the progress.c part of the patch:

- Make use of the HAVE_GETPGRP define.
- Don't skip the output if tcgetpgrp() returns -1 (as it will
  if output is redirected to a file).

Is it safe to assume that if a system has getpgrp() that it also has
tcgetpgrp()?  That's what both our patches are currently doing, and it seems
reasonable to me.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2130





------- Additional Comments From lukem@NetBSD.org  2004-12-15 03:47 -------
I've treated having getpgrp() as having tcgetpgrp() in my own code.

However, it may be safer to add a separate autoconf check, and only enable this
functionality  #if HAVE_GETPGRP && HAVE_TCGETPGRP.



-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.