search for: guestfs_upload

This is a further, more comprehensive fix for https://bugzilla.redhat.com/show_bug.cgi?id=788641 The guestfish 'edit' command (aka 'emacs', 'vi') suffered from the same problems as virt-edit and more. It could have failed and left a partially overwritten file, and it didn't preserve permissions etc from the original file. These three patches fix all this. The first

This two-part patch implements the 'hexedit' command described here: http://rwmj.wordpress.com/2010/09/18/new-feature-guestfish-hexedit/#content The first part implements two new APIs for partial writing and reading of files. These are modelled after guestfs_upload and guestfs_download but allow you to specify an offset and (for download only) a size: int guestfs_download_offset (guestfs_h *g, const char *remotefilename, const char *filename, int64_t offset, int64_t size); int guestfs_upload_offset (guestfs_h *g, const char *filename, const char *remot...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...rogress; Cancellable], (let md5 = Digest.to_hex (Digest.file "COPYING.LIB") in [InitScratchFS, Always, TestOutput ( [["upload_offset"; "../../COPYING.LIB"; "/upload_offset"; "0"]; @@ -5957,7 +5971,8 @@ error occurs. See also C<guestfs_upload>, C<guestfs_pwrite>."); - ("download_offset", (RErr, [Dev_or_Path "remotefilename"; FileOut "filename"; Int64 "offset"; Int64 "size"], []), 274, [Progress], + ("download_offset", (RErr, [Dev_or_Path "remotefilename&q...

The first patch preserves file mode, UID, GID and SELinux context across edited files. The second patch adds a useful new command in guestfish ('llz') which shows SELinux context (like 'ls -laZ') that was useful when debugging this. Rich.

...te (g, "/hello", message, strlen (message)) == -1) > exit (EXIT_FAILURE); > if (guestfs_mkdir (g, "/foo") == -1) > exit (EXIT_FAILURE); > > /* This one uploads the local file /etc/resolv.conf into > * the disk image. > */ > if (guestfs_upload (g, "/etc/resolv.conf", "/foo/resolv.conf") == -1) > exit (EXIT_FAILURE); > > /* Because we wrote to the disk and we want to detect write > * errors, call guestfs_shutdown. You don't need to do this: > * guestfs_close will do it implicitly. &...

[Please remember to post all questions on the mailing list] On Thu, Mar 08, 2012 at 09:41:19PM +0700, Tho Huynh wrote: > Can I mount the guest's file system into a folder/path (mountpoint) > in the host machine using guestfish? No, but you don't need to. > And accessing that folder equal to accessing the guest's file > system. What I'm trying to do is to copy a file

Hi, this series does a couple of code reorganizations/refactoring in code used by tools: the windows path handling code, and the two types of file editing (using editor, and using perl expression). There's still a code duplication between the two variants of file editing, but it is just within a single source, and can be easily solved now (planning as next step). Pino Toscano (13): edit:

Hi ,all : thanks for helping me ! I am using libguestfs-1.28.1 on ubuntu 12.04 to manage vm disk created by KVM. I downloaded libguestfs-1.28.1.tar.gz ,and then executed (1) ./autogen.sh (2) ./configure (3) make (4) make check .there is the error. /usr/Libvmi/libguestfs-1.28.1/run --test guest-aux/make-fedora-img.pl md_create: feature 'mdadm' is not available in this

https://bugzilla.redhat.com/show_bug.cgi?id=836710 https://bugzilla.redhat.com/show_bug.cgi?id=836913 There are at least two related bugs going on: (1) Linux sync(2) system call doesn't send a write barrier to the disk, so in effect it doesn't force the hard disk to flush its cache. libguestfs used sync(2) to force changes to disk. We didn't expect that qemu was caching anything

...t;; "$top_srcdir/COPYING"; "/upload_offset"; "0"]; ["checksum"; "md5"; "/upload_offset"]], md5), [] ]); shortdesc = "upload a file from the local machine with offset"; @@ -8880,17 +8884,19 @@ See also C<guestfs_upload>, C<guestfs_pwrite>." }; proc_nr = Some 274; progress = true; cancellable = true; tests = - (let md5 = Digest.to_hex (Digest.file "COPYING.LIB") in + (let md5 = Digest.to_hex (Digest.file "COPYING") in let offset = string_of_int 100...

...t;; "$top_srcdir/COPYING"; "/upload_offset"; "0"]; ["checksum"; "md5"; "/upload_offset"]], md5), [] ]); shortdesc = "upload a file from the local machine with offset"; @@ -9023,17 +9027,19 @@ See also C<guestfs_upload>, C<guestfs_pwrite>." }; proc_nr = Some 274; progress = true; cancellable = true; tests = - (let md5 = Digest.to_hex (Digest.file "COPYING.LIB") in + (let md5 = Digest.to_hex (Digest.file "COPYING") in let offset = string_of_int 100...

...longdesc = "\ -Download file C<remotefilename> and save it as C<filename> +Download file F<remotefilename> and save it as F<filename> on the local machine. -C<filename> can also be a named pipe. +F<filename> can also be a named pipe. See also C<guestfs_upload>, C<guestfs_cat>." }; @@ -4813,7 +4813,7 @@ To get the checksums for many files, use C<guestfs_checksums_out>." }; ]; shortdesc = "unpack tarfile to directory"; longdesc = "\ -This command uploads and unpacks local file C<tarfile> into...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

If we want to permit more than 255 drives to be added, then we will have to add the disks to the same virtio-scsi target using different unit (LUN) numbers. Unfortunately SCSI LUN enumeration in the Linux is not deterministic (eg. two disks with target=0, lun=[0,1] can be enumerated as /dev/sda or /dev/sdb randomly). Dealing with that will require some very complex device name translation on the

...read_create (&test_thread, NULL, start_test_thread, &data); - if (r != 0) { - fprintf (stderr, "pthread_create: %s\n", strerror (r)); - exit (EXIT_FAILURE); - } + if (r != 0) + error (EXIT_FAILURE, r, "pthread_create"); /* Do the upload. */ op_error = guestfs_upload (g, dev_fd, "/upload"); @@ -126,15 +122,11 @@ main (int argc, char *argv[]) /* Kill the test thread and clean up. */ r = pthread_cancel (test_thread); - if (r != 0) { - fprintf (stderr, "pthread_cancel: %s\n", strerror (r)); - exit (EXIT_FAILURE); - } + if (r !=...

Tested with 'make check-release'. tests/parallel (in check-slow) failed, although it does regularly and that seems to be because of libvirt. Rich.

..."; FileOut "filename"], []; + style = RErr, [String (Dev_or_Path, "remotefilename"); String (FileOut, "filename")], []; progress = true; cancellable = true; tests = [ InitScratchFS, Always, TestResultString ( @@ -2752,7 +2752,7 @@ See also C<guestfs_upload>, C<guestfs_cat>." }; { defaults with name = "checksum"; added = (1, 0, 2); - style = RString "checksum", [String "csumtype"; Pathname "path"], []; + style = RString "checksum", [String (PlainString, "csumtype&quot...

Very large but mechanical change to the generator. Rich.

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be