search for: guestfs_pwrite

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...(let md5 = Digest.to_hex (Digest.file "COPYING.LIB") in [InitScratchFS, Always, TestOutput ( [["upload_offset"; "../../COPYING.LIB"; "/upload_offset"; "0"]; @@ -5957,7 +5971,8 @@ error occurs. See also C<guestfs_upload>, C<guestfs_pwrite>."); - ("download_offset", (RErr, [Dev_or_Path "remotefilename"; FileOut "filename"; Int64 "offset"; Int64 "size"], []), 274, [Progress], + ("download_offset", (RErr, [Dev_or_Path "remotefilename"; FileOut "filen...

...YING"; "/upload_offset"; "0"]; ["checksum"; "md5"; "/upload_offset"]], md5), [] ]); shortdesc = "upload a file from the local machine with offset"; @@ -8880,17 +8884,19 @@ See also C<guestfs_upload>, C<guestfs_pwrite>." }; proc_nr = Some 274; progress = true; cancellable = true; tests = - (let md5 = Digest.to_hex (Digest.file "COPYING.LIB") in + (let md5 = Digest.to_hex (Digest.file "COPYING") in let offset = string_of_int 100 in - let size = st...

...YING"; "/upload_offset"; "0"]; ["checksum"; "md5"; "/upload_offset"]], md5), [] ]); shortdesc = "upload a file from the local machine with offset"; @@ -9023,17 +9027,19 @@ See also C<guestfs_upload>, C<guestfs_pwrite>." }; proc_nr = Some 274; progress = true; cancellable = true; tests = - (let md5 = Digest.to_hex (Digest.file "COPYING.LIB") in + (let md5 = Digest.to_hex (Digest.file "COPYING") in let offset = string_of_int 100 in - let size = st...

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

This changes the proposed API slightly. Previously 'mount-local' generating a 'mounted' event when the filesystem was ready, and from the 'mounted' event you had to effectively do a fork. Now, 'mount-local' just initializes the mountpoint and you have to call 'mount-local-run' to enter the FUSE main loop. Between these calls you can do a fork or whatever

...uot;; Int64 "offset"], []; + style = RBufferOut "content", [String (Pathname, "path"); Int "count"; Int64 "offset"], []; protocol_limit_warning = true; tests = [ InitISOFS, Always, TestResult ( @@ -5082,7 +5082,7 @@ See also C<guestfs_pwrite>, C<guestfs_pread_device>." }; { defaults with name = "part_init"; added = (1, 0, 78); - style = RErr, [Device "device"; String "parttype"], []; + style = RErr, [String (Device, "device"); String (PlainString, "parttype&quot...

Very large but mechanical change to the generator. Rich.

...ified then it is created with a \"hole\" before C<offset>. The size of the data written is implicit in the size of the -source C<filename>. +source F<filename>. Note that there is no limit on the amount of data that can be uploaded with this call, unlike with C<guestfs_pwrite>, @@ -9005,10 +9005,10 @@ See also C<guestfs_upload>, C<guestfs_pwrite>." }; ]); shortdesc = "download a file to the local machine with offset and size"; longdesc = "\ -Download file C<remotefilename> and save it as C<filename> +Downl...

Split up the huge generator/actions.ml into several smaller files. Rich.

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

...c/guestfs.h:1084: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1pwrite': com_redhat_et_libguestfs_GuestFS.c:7610: warning: pointer targets in passing argument 3 of 'guestfs_pwrite' differ in signedness ../src/guestfs.h:879: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1lvm_1set_1filter': com_redhat_et_libguestfs_GuestFS.c:7785: warning: passi...

...c/guestfs.h:1094: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1pwrite': com_redhat_et_libguestfs_GuestFS.c:7685: warning: pointer targets in passing argument 3 of 'guestfs_pwrite' differ in signedness ../src/guestfs.h:887: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1lvm_1set_1filter': com_redhat_et_libguestfs_GuestFS.c:7860: warning: passi...

...c/guestfs.h:1080: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1pwrite': com_redhat_et_libguestfs_GuestFS.c:7610: warning: pointer targets in passing argument 3 of 'guestfs_pwrite' differ in signedness ../src/guestfs.h:875: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1lvm_1set_1filter': com_redhat_et_libguestfs_GuestFS.c:7785: warning: passi...

Since v4: - More tests have been converted. - Testing local guests fixed. - Drop no-exec-stack test.

...stfs.h:1084:12: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1pwrite': com_redhat_et_libguestfs_GuestFS.c:7610:3: warning: pointer targets in passing argument 3 of 'guestfs_pwrite' differ in signedness ../src/guestfs.h:879:12: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1lvm_1set_1filter': com_redhat_et_libguestfs_GuestFS.c:7785:3: warning:...

...stfs.h:1094:12: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1pwrite': com_redhat_et_libguestfs_GuestFS.c:7685:3: warning: pointer targets in passing argument 3 of 'guestfs_pwrite' differ in signedness ../src/guestfs.h:887:12: note: expected 'const char *' but argument is of type 'jbyte *' com_redhat_et_libguestfs_GuestFS.c: In function 'Java_com_redhat_et_libguestfs_GuestFS__1lvm_1set_1filter': com_redhat_et_libguestfs_GuestFS.c:7860:3: warning:...

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.