search for: get_utf8_argv

OK since this approach makes sense I'll shoot with my questions :) 1. Where should get_utf8_argv go and is the name of this function OK? Right now the function is inside llvm::sys::fs namespace because I need access to Windows.h, should I leave it there. 2. get_utf8_argv allocates new char** representing utf8 argv, should I deallocate this inside driver.cpp, use std::vector<std::string>...

On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > OK since this approach makes sense I'll shoot with my questions :) > 1. Where should get_utf8_argv go and is the name of this function OK? Right > now the function is inside llvm::sys::fs namespace because I need access to > Windows.h, should I leave it there. I don't think it belongs there as it has nothing to do with the file system. However, I'm not familiar enough to know of...

On Tue, Sep 20, 2011 at 11:52 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > I spent some more time on this. My idea was to use functionality from > llvm::sys::fs like file_status instead of stat struct, but as it turns out > this is not really possible. file_status structure is not a replacement for > stat, nor are there functions inside llvm::sys::fs that can replace

get_utf8_argv() function calls LoadLibrary to load msvcrt.dll, but doesn't call FreeLibrary() if it returns an error. Currently both flac.exe and metaflac.exe exit immediately if get_utf8_argv() fails, so it's not a big problem. But IMHO it's better no to have leaked resources anyway. --------------...

That's how I understand how flac.exe works with unicode under Windows: There's a flag win_utf8_io_codepage that is equal either to CP_ACP or to CP_UTF8. Initially it's equal to CP_ACP. Then flac.exe/metaflac.exe call get_utf8_argv() that do some things and sets win_utf8_io_codepage to CP_UTF8 on success. This is the only way to set this flag to CP_UTF8. The programs continue to work only if get_utf8_argv() succeeds, so we know that win_utf8_io_codepage is always set to CP_UTF8. Actually, there's a code in metaflac/opera...

...bably? On Wed, Sep 21, 2011 at 1:41 AM, Aaron Ballman <aaron at aaronballman.com>wrote: > On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> > wrote: > > OK since this approach makes sense I'll shoot with my questions :) > > 1. Where should get_utf8_argv go and is the name of this function OK? > Right > > now the function is inside llvm::sys::fs namespace because I need access > to > > Windows.h, should I leave it there. > > I don't think it belongs there as it has nothing to do with the file > system. However, I'...

...? > > On Wed, Sep 21, 2011 at 1:41 AM, Aaron Ballman <aaron at aaronballman.com> wrote: > On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > > OK since this approach makes sense I'll shoot with my questions :) > > 1. Where should get_utf8_argv go and is the name of this function OK? Right > > now the function is inside llvm::sys::fs namespace because I need access to > > Windows.h, should I leave it there. > > I don't think it belongs there as it has nothing to do with the file > system. However, I'm not fa...

...On Wed, Sep 21, 2011 at 1:41 AM, Aaron Ballman <aaron at aaronballman.com> wrote: >> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: >> > OK since this approach makes sense I'll shoot with my questions :) >> > 1. Where should get_utf8_argv go and is the name of this function OK? Right >> > now the function is inside llvm::sys::fs namespace because I need access to >> > Windows.h, should I leave it there. >> >> I don't think it belongs there as it has nothing to do with the file >> system. How...

...21, 2011 at 1:41 AM, Aaron Ballman <aaron at aaronballman.com>wrote: > >> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> >> wrote: >> > OK since this approach makes sense I'll shoot with my questions :) >> > 1. Where should get_utf8_argv go and is the name of this function OK? >> Right >> > now the function is inside llvm::sys::fs namespace because I need access >> to >> > Windows.h, should I leave it there. >> >> I don't think it belongs there as it has nothing to do with the file >...

...21, 2011 at 1:41 AM, Aaron Ballman <aaron at aaronballman.com> wrote: >>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: >>> > OK since this approach makes sense I'll shoot with my questions :) >>> > 1. Where should get_utf8_argv go and is the name of this function OK? Right >>> > now the function is inside llvm::sys::fs namespace because I need access to >>> > Windows.h, should I leave it there. >>> >>> I don't think it belongs there as it has nothing to do with the file >&...

...Aaron Ballman <aaron at aaronballman.com>wrote: >> >>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> >>> wrote: >>> > OK since this approach makes sense I'll shoot with my questions :) >>> > 1. Where should get_utf8_argv go and is the name of this function OK? >>> Right >>> > now the function is inside llvm::sys::fs namespace because I need >>> access to >>> > Windows.h, should I leave it there. >>> >>> I don't think it belongs there as it has nothing...

...aron at aaronballman.com>wrote: >>> >>>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> >>>> wrote: >>>> > OK since this approach makes sense I'll shoot with my questions :) >>>> > 1. Where should get_utf8_argv go and is the name of this function OK? >>>> Right >>>> > now the function is inside llvm::sys::fs namespace because I need >>>> access to >>>> > Windows.h, should I leave it there. >>>> >>>> I don't think it belongs...

...1:41 AM, Aaron Ballman <aaron at aaronballman.com> wrote: >>>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: >>>> > OK since this approach makes sense I'll shoot with my questions :) >>>> > 1. Where should get_utf8_argv go and is the name of this function OK? Right >>>> > now the function is inside llvm::sys::fs namespace because I need access to >>>> > Windows.h, should I leave it there. >>>> >>>> I don't think it belongs there as it has nothing to do wit...

....com>wrote: >>>> >>>>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> >>>>> wrote: >>>>> > OK since this approach makes sense I'll shoot with my questions :) >>>>> > 1. Where should get_utf8_argv go and is the name of this function OK? >>>>> Right >>>>> > now the function is inside llvm::sys::fs namespace because I need >>>>> access to >>>>> > Windows.h, should I leave it there. >>>>> >>>>> I don...

...Aaron Ballman <aaron at aaronballman.com>wrote: >> >>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> >>> wrote: >>> > OK since this approach makes sense I'll shoot with my questions :) >>> > 1. Where should get_utf8_argv go and is the name of this function OK? >>> Right >>> > now the function is inside llvm::sys::fs namespace because I need >>> access to >>> > Windows.h, should I leave it there. >>> >>> I don't think it belongs there as it has nothing...

...he build. > > These patches change the UTF-8 mode into a runtime choice. The larger patch removes the now obsolete "Release (UTF8)" configuration options from the project files. The smaller patch makes the utf-8 library use ANSI codepage by default. When frontends call the "get_utf8_argv" function it changes Unicode conversion codepage from ANSI to UTF-8. As far as I can see this solves possible issues. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_patches.zip Type: application/x-zip-compressed Size: 4740 bytes Desc: not availab...

...ron Ballman <aaron at aaronballman.com> wrote: >>>>> On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: >>>>> > OK since this approach makes sense I'll shoot with my questions :) >>>>> > 1. Where should get_utf8_argv go and is the name of this function OK? Right >>>>> > now the function is inside llvm::sys::fs namespace because I need access to >>>>> > Windows.h, should I leave it there. >>>>> >>>>> I don't think it belongs there as it has n...

If anybody wants to know: current flac.exe is not compatible with Windows 2000. The only reason for this is the following line from get_utf8_argv() function from src/share/win_utf8_io/win_utf8_io.c: if (wgetmainargs(&wargc, &wargv, &wenv, 1, &i) != 0) return 1; Windows 2000 has slightly older version of msvcrt.dll, and this check always fails. I found an explanation about it here: http://lists.gnu.org/archive/html/tiny...

...n_utf8_io.h b/include/share/win_utf8_io.h index b48e85e..b689db0 100644 --- a/include/share/win_utf8_io.h +++ b/include/share/win_utf8_io.h @@ -10,7 +10,7 @@ extern "C" { #include <stdio.h> #include <sys/stat.h> #include <stdarg.h> - +#include <windows.h> int get_utf8_argv(int *argc, char ***argv); @@ -25,6 +25,7 @@ int chmod_utf8(const char *filename, int pmode); int utime_utf8(const char *filename, struct utimbuf *times); int unlink_utf8(const char *filename); int rename_utf8(const char *oldname, const char *newname); +HANDLE WINAPI CreateFile_utf8(const char...

Hi all, The latest pre-release is here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz but there will probably need to be at least one more. I've tested this on x86_64-linux powerpc-linux i386-openbsd5.2 i386-freebsd9 The majority of changes since the last pre-release is the addition of Janne Hyv?rinen's utf8 I/O functionality. Janne's