flac dev - Aug 2015 - [PATCH] always call FreeLibrary()

get_utf8_argv() function calls LoadLibrary to load msvcrt.dll,
but doesn't call FreeLibrary() if it returns an error.

Currently both flac.exe and metaflac.exe exit immediately
if get_utf8_argv() fails, so it's not a big problem. But IMHO
it's better no to have leaked resources anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: win_utf_io.patch
Type: application/octet-stream
Size: 1407 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20150808/ea501fdf/attachment.obj

lvqcl wrote:
> get_utf8_argv() function calls LoadLibrary to load msvcrt.dll,
> but doesn't call FreeLibrary() if it returns an error.
> 
> Currently both flac.exe and metaflac.exe exit immediately
> if get_utf8_argv() fails, so it's not a big problem. But IMHO
> it's better no to have leaked resources anyway.
Applied. Thanks.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/