search for: get_predata

Hi Mike Find enclosed the patch with the fastart implementation for vorbis (for the moment). Now is based on size in bytes and the buffers are sent all together with pre_data. Hope you like it. At least is the smallest one: :-) -rw-r--r-- 1 gallir gallir 5486 2003-01-21 01:29 update3c.diff -rw-r--r-- 1 gallir gallir 10014 2003-01-19 20:14 update3b.diff -rw-r--r--

Hi Mike, find the patch for faststart that takes in account different logical streams. I tried with ices' playlist, it works just fine [*]. I could be still further optimised, but it will make the code less clear (for example, I could check for has_paredata before checking for serailno, which saves a couple of calls and also will avoid any change in format_mp3.[ch]). <p>[*]

...r > serailno, which saves a couple of calls and also will avoid any change in > format_mp3.[ch]). > <p>There's already too much format-specific knowledge in the core, this get_serialno() thing has no chance of going in. The right way to do this is to move it all entirely into get_predata(), and have a default implementation of that (for mp3 to use, for example, as well as any other formats that get added in the future) that only does the 'faststart' stuff. The vorbis implementation will obviously need to do more than just this one thing. It also needs to be defaulted...

...e buffers are sent all together with > pre_data. > > Hope you like it. At least is the smallest one: :-) Ricardo, This is much improved. There are a few things to clean up (comments, for instance, since we're not targetting C99), plus actually writing the generic implementation for get_predata() (which at the moment only mp3 will use), but the design looks fine. I'm unlikely to have time to finish off these last details and merge to cvs this week, and I'm out of the country next week, so it could be a while until this gets to cvs - but don't think that I've forgotten...

On Tuesday 21 January 2003 10:38, Michael Smith shaped the electrons to shout: > This is much improved. There are a few things to clean up (comments, > for instance, since we're not targetting C99), plus actually writing > the generic implementation for get_predata() (which at the moment only > mp3 will use), but the design looks fine. I'm unlikely to have time to Hope you read this message before leaving the country... In order to implement a generic get_data function, which has to check for teh faststart_queue, and other fields, I must move the fo...