Hi Mike
Find enclosed the patch with the fastart implementation for vorbis (for
the moment).
Now is based on size in bytes and the buffers are sent all together with
pre_data.
Hope you like it. At least is the smallest one: :-)
-rw-r--r-- 1 gallir gallir 5486 2003-01-21 01:29 update3c.diff
-rw-r--r-- 1 gallir gallir 10014 2003-01-19 20:14 update3b.diff
-rw-r--r-- 1 gallir gallir 10014 2003-01-19 16:52 update3a.diff
-rw-r--r-- 1 gallir gallir 6116 2003-01-18 22:00 update3.diff
<p>Regards,
--
ricardo galli GPG id C8114D34
-------------- next part --------------
A non-text attachment was scrubbed...
Name: update3c.diff
Type: text/x-diff
Size: 5679 bytes
Desc: update3c.diff
Url :
http://lists.xiph.org/pipermail/icecast-dev/attachments/20030121/b1fa8f3e/update3c.bin
On Tuesday 21 January 2003 11:37, Ricardo Galli wrote:> Hi Mike > Find enclosed the patch with the fastart implementation for vorbis (for > the moment). > Now is based on size in bytes and the buffers are sent all together with > pre_data. > > Hope you like it. At least is the smallest one: :-)Ricardo, This is much improved. There are a few things to clean up (comments, for instance, since we're not targetting C99), plus actually writing the generic implementation for get_predata() (which at the moment only mp3 will use), but the design looks fine. I'm unlikely to have time to finish off these last details and merge to cvs this week, and I'm out of the country next week, so it could be a while until this gets to cvs - but don't think that I've forgotten it because of that. Mike --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Tuesday 21 January 2003 10:38, Michael Smith shaped the electrons to shout:> Ricardo, > > This is much improved. There are a few things to clean up (comments,Thanks.> for instance, since we're not targetting C99), plus actually writingYup, there is a couple, bad C++ custom. I will change them.> the generic implementation for get_predata() (which at the moment only > mp3 will use), but the design looks fine. I'm unlikely to have time to > finish off these last details and merge to cvs this week, and I'm out > of the country next week, so it could be a while until this gets to cvs > - but don't think that I've forgotten it because of that.So, don't commit this patch, I'will post a new one with the generic get_predata today or tomorrow. <p><p> -- ricardo galli GPG id C8114D34 --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Tuesday 21 January 2003 10:38, Michael Smith shaped the electrons to shout:> This is much improved. There are a few things to clean up (comments, > for instance, since we're not targetting C99), plus actually writing > the generic implementation for get_predata() (which at the moment only > mp3 will use), but the design looks fine. I'm unlikely to have time toHope you read this message before leaving the country... In order to implement a generic get_data function, which has to check for teh faststart_queue, and other fields, I must move the following fields: long faststart_size; /* If > 0, max bytes in queue */ refbuf_queue_t *faststart_queue; long faststart_queue_size; /* In bytes */ from the _state structure (which differs according to the format) to format_plugin_t. If don't agree tell me as soon as you can please. <p> -- ricardo galli GPG id C8114D34 --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.