Displaying 4 results from an estimated 4 matches for "gerey".
Did you mean:
garey
2019 Sep 12
2
NaN sanity check not present in tree.
Hi, I'm still Yves.
This other fix
<https://chromium-review.googlesource.com/c/chromium/src/+/1061499/> never
made it to opus repository.
It seems safe and sane enough to be applied to opus master branch.
What do you think?
--
Warm regards,
Yves
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
2019 Sep 10
2
Int overflow fix not present in tree.
Hi! I'm Yves, bit fiddler, hoping to roll a fresh version of libopus into
chromium.
This fix
<https://chromium-review.googlesource.com/c/chromium/src/+/1072869/> never
made it to opus repository.
Was it intentional? If so, what is the rational?
If not, could the fix be applied on the libopus master branch?
Thanks for the amazing work!
--
Warm regards,
Yves
-------------- next part
2019 Sep 10
0
Int overflow fix not present in tree.
Hi Yves,
At that time, the issue wasn't reproducible in opus master, but there had
been some significant changes since the last tagged release that made it
hard to pinpoint a single patch to cherry pick to Chromium, hence this
local fix.
Cheers,
Felicia
On Tue, Sep 10, 2019 at 7:56 AM Yves Gerey <yvesg at google.com> wrote:
> Hi! I'm Yves, bit fiddler, hoping to roll a fresh version of libopus into
> chromium.
>
> This fix
> <https://chromium-review.googlesource.com/c/chromium/src/+/1072869/> never
> made it to opus repository.
>
> Was it intentiona...
2019 Sep 23
0
NaN sanity check not present in tree.
...1 and should definitely never be NaN.
So either the patch does nothing (in which case we don't need it), or it
does something and there's something much scarier going on than NaNs. In
the latter case, I think more investigation is required.
Cheers,
Jean-Marc
On 9/12/19 1:00 PM, Yves Gerey wrote:
> Hi, I'm still Yves.
>
> This other fix
> <https://chromium-review.googlesource.com/c/chromium/src/+/1061499/> never
> made it to opus repository.
>
> It seems safe and sane enough to be applied to opus master branch.
> What do you think?
>
> --
&...