search for: free_page_hinting

...to > document another flag that's pretty similar. I mean, do we need a flag at all as long as there is no user? Introducing a flag and documenting it if nobody uses it does not sound like a work I will enjoy :) We can simply document "VIRTIO_BALLOON_F_MUST_TELL_HOST does not apply to FREE_PAGE_HINTING" and "with FREE_PAGE_HINTING, the guest can reuse pages any time, without waiting for a response/ack from the hypervisor". Thoughts? -- Thanks, David / dhildenb

...to > document another flag that's pretty similar. I mean, do we need a flag at all as long as there is no user? Introducing a flag and documenting it if nobody uses it does not sound like a work I will enjoy :) We can simply document "VIRTIO_BALLOON_F_MUST_TELL_HOST does not apply to FREE_PAGE_HINTING" and "with FREE_PAGE_HINTING, the guest can reuse pages any time, without waiting for a response/ack from the hypervisor". Thoughts? -- Thanks, David / dhildenb

...NG I think you really must wait for host to use the hint. But with VIRTIO_BALLOON_F_FREE_PAGE_HINT it depends on how host uses it. Something to think about, I'm not sure what is the best thing to do here. > We can simply document "VIRTIO_BALLOON_F_MUST_TELL_HOST does not apply > to FREE_PAGE_HINTING" and "with FREE_PAGE_HINTING, the guest can reuse > pages any time, without waiting for a response/ack from the hypervisor". > > Thoughts? > > -- > Thanks, > > David / dhildenb

On Thu, Apr 16, 2020 at 3:13 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Thu, Apr 16, 2020 at 12:30:38PM -0700, Alexander Duyck wrote: > > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > > > If we have free page hinting or page reporting enabled we should disable it > > if the pages are poisoned or initialized on free and we

On Wednesday, February 5, 2020 12:50 AM, Michael S. Tsirkin wrote: > > Michael, any clue on which event we have to wait with > > VIRTIO_BALLOON_F_MUST_TELL_HOST? IMHO, I don't think > > VIRTIO_BALLOON_F_MUST_TELL_HOST applies to > > VIRTIO_BALLOON_F_FREE_PAGE_HINT and we'd better document that. It > introduces complexity with no clear benefit. > > I meant

On Wednesday, February 5, 2020 12:50 AM, Michael S. Tsirkin wrote: > > Michael, any clue on which event we have to wait with > > VIRTIO_BALLOON_F_MUST_TELL_HOST? IMHO, I don't think > > VIRTIO_BALLOON_F_MUST_TELL_HOST applies to > > VIRTIO_BALLOON_F_FREE_PAGE_HINT and we'd better document that. It > introduces complexity with no clear benefit. > > I meant

On 04.02.20 09:40, Michael S. Tsirkin wrote: > On Tue, Feb 04, 2020 at 09:35:21AM +0100, David Hildenbrand wrote: >>>>> I would say reverting probably makes sense. I'm not sure there is much >>>>> value to having a shrinker running deflation when you are actively trying >>>>> to increase the balloon. It would make more sense to wait until you are

On 04.02.20 09:40, Michael S. Tsirkin wrote: > On Tue, Feb 04, 2020 at 09:35:21AM +0100, David Hildenbrand wrote: >>>>> I would say reverting probably makes sense. I'm not sure there is much >>>>> value to having a shrinker running deflation when you are actively trying >>>>> to increase the balloon. It would make more sense to wait until you are

On Thu, Apr 16, 2020 at 04:52:42PM -0700, Alexander Duyck wrote: > On Thu, Apr 16, 2020 at 3:13 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Thu, Apr 16, 2020 at 12:30:38PM -0700, Alexander Duyck wrote: > > > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > > > > > If we have free page hinting or page reporting

There were apparently good reasons for moving away from OOM notifier callback: https://lkml.org/lkml/2018/7/12/314 https://lkml.org/lkml/2018/8/2/322 In particular the OOM notifier is worse than the shrinker because: 1. It is last-resort, which means the system has already gone through heroics to prevent OOM. Those heroic reclaim efforts are expensive and impact application performance.

There were apparently good reasons for moving away from OOM notifier callback: https://lkml.org/lkml/2018/7/12/314 https://lkml.org/lkml/2018/8/2/322 In particular the OOM notifier is worse than the shrinker because: 1. It is last-resort, which means the system has already gone through heroics to prevent OOM. Those heroic reclaim efforts are expensive and impact application performance.

On Mon, Feb 3, 2020 at 1:22 PM Alexander Duyck < alexander.h.duyck at linux.intel.com> wrote: > On Mon, 2020-02-03 at 12:32 -0800, Tyler Sanderson wrote: > > There were apparently good reasons for moving away from OOM notifier > > callback: > > https://lkml.org/lkml/2018/7/12/314 > > https://lkml.org/lkml/2018/8/2/322 > > > > In particular the OOM

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> If we have free page hinting or page reporting enabled we should disable it if the pages are poisoned or initialized on free and we cannot notify the hypervisor. Fixes: 5d757c8d518d ("virtio-balloon: add support for providing free page reports to host") Signed-off-by: Alexander Duyck <alexander.h.duyck at

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> If we have free page hinting or page reporting enabled we should disable it if the pages are poisoned or initialized on free and we cannot notify the hypervisor. Fixes: 5d757c8d518d ("virtio-balloon: add support for providing free page reports to host") Signed-off-by: Alexander Duyck <alexander.h.duyck at

On 03.02.20 17:18, Alexander Duyck wrote: > On Mon, 2020-02-03 at 08:11 -0500, Michael S. Tsirkin wrote: >> On Thu, Jan 30, 2020 at 11:59:46AM -0800, Tyler Sanderson wrote: >>> >>> On Thu, Jan 30, 2020 at 7:31 AM Wang, Wei W <wei.w.wang at intel.com> wrote: >>> >>> On Thursday, January 30, 2020 11:03 PM, David Hildenbrand wrote: >>>

On 03.02.20 17:18, Alexander Duyck wrote: > On Mon, 2020-02-03 at 08:11 -0500, Michael S. Tsirkin wrote: >> On Thu, Jan 30, 2020 at 11:59:46AM -0800, Tyler Sanderson wrote: >>> >>> On Thu, Jan 30, 2020 at 7:31 AM Wang, Wei W <wei.w.wang at intel.com> wrote: >>> >>> On Thursday, January 30, 2020 11:03 PM, David Hildenbrand wrote: >>>

On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free pages by sending a new cmd > id to the guest via the free_page_report_cmd_id configuration register. > > When the guest starts

On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free pages by sending a new cmd > id to the guest via the free_page_report_cmd_id configuration register. > > When the guest starts

This patch series is separated from the previous "Virtio-balloon Enhancement" series. The new feature, VIRTIO_BALLOON_F_FREE_PAGE_VQ, implemented by this series enables the virtio-balloon driver to report hints of guest free pages to the host. It can be used to accelerate live migration of VMs. Here is an introduction of this usage: Live migration needs to transfer the VM's memory