search for: flush_queu

...flushing the queues. If the len gets corrupted, the crypting will crash the program (segm fault). In general, I think the program needs a checksum to see that it does not decrypt corrupted packets. Since it uses UDP, the packets can get corrupted. After that, I had a look to the add_queue() and flush_queue() funcs. Need to so some more work here. flush_queue() will call recv() for more packets that are in the queue. It sometimes ends up with calls for packets that do not exist or have negative lengths. I do not trust the pointer fiddling in flush_queue(). If it is flushed, where do q->header and...

Hi tinc list members, There were some problems with Ivo's email adresses (both zarq@iname.com and zarq@spark.icicle.dhs.org) so I resent the stuff to the mailling list. ============================================= Hi Ivo, Hier is een oplossing voor een bugje in flush_queue(), en ook wat andere troepjes zoals een tincd scheduler. Dit werkt wat beter, omdat de scheduler een afzonderlijk programma is, en niet meecrashed als tincd down gaat. Heb alleen nog wel het gevoel dat de ping test in het tincsched soms wat al te snel denkt dat er geen verbinding is, ik ga er nog...

.../virtio_pmem.c > +++ b/drivers/nvdimm/virtio_pmem.c > @@ -19,7 +19,7 @@ static int init_vq(struct virtio_pmem *vpmem) > { > /* single vq */ > vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > - host_ack, "flush_queue"); > + virtio_pmem_host_ack, "flush_queue"); > if (IS_ERR(vpmem->req_vq)) > return PTR_ERR(vpmem->req_vq); > > diff --git a/drivers/nvdimm/virtio_pmem.h b/drivers/nvdimm/virtio_pmem.h > index 6e4...

On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver

On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver

...alize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) IMHO, you don't gain much by splitting off this function... > +{ > + struct virtqueue *vq; > + > + /* single vq */ > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vq)) > + return PTR_ERR(vq); I'm personally not a fan of chained assignments... I think I'd just drop the 'vq' variable and operate on vpmem->req_vq directly. > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem...

...alize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) IMHO, you don't gain much by splitting off this function... > +{ > + struct virtqueue *vq; > + > + /* single vq */ > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vq)) > + return PTR_ERR(vq); I'm personally not a fan of chained assignments... I think I'd just drop the 'vq' variable and operate on vpmem->req_vq directly. > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem...

...0c 100644 --- a/drivers/nvdimm/virtio_pmem.c +++ b/drivers/nvdimm/virtio_pmem.c @@ -19,7 +19,7 @@ static int init_vq(struct virtio_pmem *vpmem) { /* single vq */ vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, - host_ack, "flush_queue"); + virtio_pmem_host_ack, "flush_queue"); if (IS_ERR(vpmem->req_vq)) return PTR_ERR(vpmem->req_vq); diff --git a/drivers/nvdimm/virtio_pmem.h b/drivers/nvdimm/virtio_pmem.h index 6e47521be158..998efbc7660c 100644...

..., but I don't want to muddy the waters by committing anything significant when there's still a crash going on. crash 1: ==28913== Invalid read of size 8 ==28913== at 0x412150: list_unlink_node (list.c:97) ==28913== by 0x412278: list_delete_node (list.c:111) ==28913== by 0x407143: flush_queue (net_packet.c:451) ==28913== by 0x40E2AE: ans_key_h (protocol_key.c:239) ==28913== by 0x40BC58: receive_request (protocol.c:157) ==28913== by 0x405B87: receive_meta (meta.c:138) ==28913== by 0x406867: handle_meta_connection_data (net.c:225) ==28913== by 0x4C0FAC0: event_base_loop (e...

...that - maybe it would be better to have the 3 in one struct. > > > > > > +{ > > > + struct virtqueue *vq; > > > + > > > + /* single vq */ > > > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > > > + host_ack, "flush_queue"); > > > + if (IS_ERR(vq)) > > > + return PTR_ERR(vq); > > > > I'm personally not a fan of chained assignments... I think I'd just > > drop the 'vq' variable and operate on vpmem->req_vq directly. > > +1 Will drop extra vq. &gt...

...q_list are used only for the vq. Saying that - maybe it would be better to have the 3 in one struct. > > > +{ > > + struct virtqueue *vq; > > + > > + /* single vq */ > > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > > + host_ack, "flush_queue"); > > + if (IS_ERR(vq)) > > + return PTR_ERR(vq); > > I'm personally not a fan of chained assignments... I think I'd just > drop the 'vq' variable and operate on vpmem->req_vq directly. +1 > > > + > > + spin_lock_init(&vpmem-&gt...

...IO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + /* single vq */ > + vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vpmem->req_vq)) > + return PTR_ERR(vpmem->req_vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_p...

...IO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + /* single vq */ > + vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vpmem->req_vq)) > + return PTR_ERR(vpmem->req_vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_p...

...t; > + /* Initialize virt queue */ > > > +static int init_vq(struct virtio_pmem *vpmem) > > > +{ > > > + /* single vq */ > > > + vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > > > + host_ack, "flush_queue"); > > > + if (IS_ERR(vpmem->req_vq)) > > > + return PTR_ERR(vpmem->req_vq); > > > + > > > + spin_lock_init(&vpmem->pmem_lock); > > > + INIT_LIST_HEAD(&vpmem->req_list); > > > + > >...

...VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + struct virtqueue *vq; > + > + /* single vq */ > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vq)) > + return PTR_ERR(vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_probe(struct virtio_device *vdev) > +{ > + int err = 0; >...

...VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + struct virtqueue *vq; > + > + /* single vq */ > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vq)) > + return PTR_ERR(vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_probe(struct virtio_device *vdev) > +{ > + int err = 0; >...

...id_table[] = { > + { VIRTIO_ID_PMEM, VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + /* single vq */ > + vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vpmem->req_vq)) > + return PTR_ERR(vpmem->req_vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_probe(struct virtio_device *vdev) >...

...id_table[] = { > + { VIRTIO_ID_PMEM, VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + /* single vq */ > + vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vpmem->req_vq)) > + return PTR_ERR(vpmem->req_vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_probe(struct virtio_device *vdev) >...

...VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + struct virtqueue *vq; > + > + /* single vq */ > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); > + if (IS_ERR(vq)) > + return PTR_ERR(vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); > + > + return 0; > +}; > + > +static int virtio_pmem_probe(struct virtio_device *vdev) > +{ > + int err = 0; >...

...id_table[] = { > + { VIRTIO_ID_PMEM, VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > + /* Initialize virt queue */ > +static int init_vq(struct virtio_pmem *vpmem) > +{ > + /* single vq */ > + vpmem->req_vq = virtio_find_single_vq(vpmem->vdev, > + host_ack, "flush_queue"); Nit: Wrong indentation of parameters. > + if (IS_ERR(vpmem->req_vq)) > + return PTR_ERR(vpmem->req_vq); > + > + spin_lock_init(&vpmem->pmem_lock); > + INIT_LIST_HEAD(&vpmem->req_list); I would initialize the locks in the virtio_pmem_probe() directly,...