search for: flac_min

...adjust for compilers that can't understand using LLU suffix for uint64_t literals */ #ifdef _MSC_VER #define FLAC__U64L(x) x @@ -547,7 +539,7 @@ FLAC__bool FLAC__bitreader_skip_bits_no_crc(FLAC__BitReader *br, unsigned bits) FLAC__uint32 x; if(n != 0) { - m = min(8-n, bits); + m = flac_min(8-n, bits); if(!FLAC__bitreader_read_raw_uint32(br, &x, m)) return false; bits -= m; diff --git a/src/libFLAC/bitwriter.c b/src/libFLAC/bitwriter.c index 7da4b15..44914d1 100644 --- a/src/libFLAC/bitwriter.c +++ b/src/libFLAC/bitwriter.c @@ -37,6 +37,7 @@ #include <string.h>...

...different condition; something like (…) || (defined(__clang__) && (__clang_major__ > 3 || \ (__clang_major__ == 3 && __clang_minor__ >= 9))) 2. Min and max macros I'm also surprised by the degree of variation here. flac_max uses a statement expression. flac_min relies on some preprocessor magic and the __COUNTER__ macro instead. For non-gcc-4.3+ it falls back MIN and MAX from sys/param.h which probably satisfies this dependency for most users who use configure, but which does not cache its arguments but evaluate them twice, at least on my system. But for...

Hi, I couldn't figure out how to file a bug in the bugtracker at sourceforge. So I send a report this way. Building FLAC from git for Android fails with the following message: utils.c: In function 'get_console_width': utils.c:181:17: error: storage size of 'w' isn't known utils.c:181:17: warning: unused variable 'w' [-Wunused-variable] make[3]: *** [utils.o]

...oder->protected_->do_qlp_coeff_prec_search) { > min_qlp_coeff_precision = FLAC__MIN_QLP_COEFF_PRECISION; > /* try to ensure a 32-bit datapath throughout for > 16bps(+1bps for side channel) or less */ > if(subframe_bps <= 17) { > max_qlp_coeff_precision = flac_min(32 - subframe_bps - > lpc_order, FLAC__MAX_QLP_COEFF_PRECISION); > max_qlp_coeff_precision = > flac_max(max_qlp_coeff_precision, min_qlp_coeff_precision); > } > else > max_qlp_coeff_precision = FLAC__MAX_QLP_COEFF_PRECISION; > } > else { > mi...

...f(encoder->protected_->do_qlp_coeff_prec_search) { min_qlp_coeff_precision = FLAC__MIN_QLP_COEFF_PRECISION; - /* try to ensure a 32-bit datapath throughout for 16bps(+1bps for side channel) or less */ - if(subframe_bps <= 17) { - max_qlp_coeff_precision = flac_min(32 - subframe_bps - lpc_order, FLAC__MAX_QLP_COEFF_PRECISION); + /* try to keep qlp coeff precision such that only 32-bit math is required for decode of <=16bps streams */ + if(subframe_bps <= 16) { + max_qlp_coeff_precision = flac_min(32 - subframe_bps - FLAC__bitmat...

Hi all, Anyone know anything about Windows Universal Platform? Someone raised an issue on github: https://github.com/xiph/flac/issues/32 The `flac_max`/`flac_min` issue is resolved, but the WUP one is not. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

...OBJ_FORMAT) -d OBJ_FORMAT_$(OBJ_FORMAT) -i$(srcdir)/ $< -o $@ diff --git a/src/libFLAC/include/private/macros.h b/src/libFLAC/include/private/macros.h index b9989e1..5104dc9 100644 --- a/src/libFLAC/include/private/macros.h +++ b/src/libFLAC/include/private/macros.h @@ -57,4 +57,10 @@ #define flac_min(a,b) __min(a,b) #endif +#if !defined(__cplusplus) && defined(_MSC_VER) +#ifndef inline +#define inline __inline +#endif +#endif + #endif diff --git a/src/libFLAC/lpc.c b/src/libFLAC/lpc.c index e3842c5..02cda9a 100644 --- a/src/libFLAC/lpc.c +++ b/src/libFLAC/lpc.c @@ -38,6 +38,7 @@ #i...