search for: flac_ip

...C__FileDecoder *decoder_ = 0; static file_info_struct file_info_; @@ -188,7 +193,6 @@ void FLAC_XMMS__play_file(char *filename) { FILE *f; - gchar *ret; wide_samples_in_reservoir_ = 0; audio_error_ = false; @@ -219,10 +223,8 @@ return; } - ret = flac_format_song_title(filename); - flac_ip.set_info(ret, file_info_.length_in_msec, file_info_.sample_rate * file_info_.channels * file_info_.bits_per_sample, file_info_.sample_rate, file_info_.channels); - - g_free(ret); + file_info_.title = flac_format_song_title(filename); + flac_ip.set_info(file_info_.title, file_info_.length_in_msec, f...

...ible (samples decoded from last reset or for whole life of decoder). So i samples_decoded set to 0 in stream_decoder_reset. Against stream_decoder.c 205a206,207 > if (decoder->guts) > decoder->guts->samples_decoded = 0; Second problem: Visual plugins are slow. It's caused by flac_ip.add_vis_pcm, it gets too many samples (4.5Ksamples) at one call. Solution is in calling this with only 512samples. Against plugin.c 301,305c301,312 < flac_ip.add_vis_pcm(flac_ip.output->written_time(), file_info_.sample_format, file_info_.channels, bytes, reservoir_); < while(flac...

...C__FileDecoder *decoder_ = 0; static file_info_struct file_info_; @@ -188,7 +193,6 @@ void FLAC_XMMS__play_file(char *filename) { FILE *f; - gchar *ret; wide_samples_in_reservoir_ = 0; audio_error_ = false; @@ -219,10 +223,8 @@ return; } - ret = flac_format_song_title(filename); - flac_ip.set_info(ret, file_info_.length_in_msec, file_info_.sample_rate * file_info_.channels * file_info_.bits_per_sample, file_info_.sample_rate, file_info_.channels); - - g_free(ret); + file_info_.title = flac_format_song_title(filename); + flac_ip.set_info(file_info_.title, file_info_.length_in_msec, f...

...emicolon at end of struct or union plugin.c:77: error: syntax error before '}' token plugin.c:77: warning: type defaults to `int' in declaration of `file_info_struct' plugin.c:77: warning: data definition has no type or storage class plugin.c:97: error: syntax error before "flac_ip" plugin.c:97: warning: type defaults to `int' in declaration of `flac_ip' plugin.c:99: warning: initialization makes integer from pointer without a cast plugin.c:100: warning: excess elements in scalar initializer plugin.c:100: warning: (near initialization for `flac_ip') plugi...

On Fri, Nov 08, 2002 at 12:39:52PM -0800, Josh Coalson wrote: > --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > I have few notes: > > > > It seems there is changed API in CVS again. So, what about adding > > function like > > unsigned FLAC__format_frame_size(const FLAC__Frame *frame) > > which returns size of the frame in bytes. This

...or union > plugin.c:77: error: syntax error before '}' token > plugin.c:77: warning: type defaults to `int' in declaration of > `file_info_struct' > plugin.c:77: warning: data definition has no type or storage class > plugin.c:97: error: syntax error before "flac_ip" > plugin.c:97: warning: type defaults to `int' in declaration of > `flac_ip' > plugin.c:99: warning: initialization makes integer from pointer > without > a cast > plugin.c:100: warning: excess elements in scalar initializer > plugin.c:100: warning: (near initi...

....orig 2002-11-14 08:59:20.000000000 +0100 +++ src/plugin_xmms/plugin.c 2002-11-14 14:33:38.000000000 +0100 @@ -404,7 +404,7 @@ unsigned target_sample = (unsigned)(distance * (double)file_info_.total_samples); if(FLAC__file_decoder_seek_absolute(decoder_, (FLAC__uint64)target_sample)) { flac_ip.output->flush(file_info_.seek_to_in_sec * 1000); - bh_index_last_w = bh_index_last_o = file_info_.seek_to_in_sec * 1000 / BITRATE_HIST_SEGMENT_MSEC % BITRATE_HIST_SIZE; + bh_index_last_w = bh_index_last_o = flac_ip.output->output_time() / BITRATE_HIST_SEGMENT_MSEC % BITRATE_HIST_SIZE;...

...FLAC/format.h" + #include "plugin.h" + + #define min(x,y) ((x)<(y)?(x):(y)) + #define min3(x,y,z) (min(x,y)<(z)?min(x,y):(z)) + #define min4(x,y,z,w) (min3(x,y,z)<(w)?min3(x,y,z):(w)) + + static gchar *icy_name = NULL; + static gint icy_metaint = 0; + + extern InputPlugin flac_ip; + + #undef DEBUG_UDP + + /* Static udp channel functions */ + static int udp_establish_listener (gint *sock); + static int udp_check_for_data(gint sock); + + static char *flac_http_get_title(char *url); + + static gboolean prebuffering, going, eof = FALSE; + static gint sock, rd_index, wr_inde...

--- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > On Sat, Nov 09, 2002 at 06:02:33PM +0100, Miroslav Lichvar wrote: > > On Fri, Nov 08, 2002 at 07:12:35PM -0800, Josh Coalson wrote: > > > Yeah, it's useful, so now there is a > > > FLAC__seekable_stream_decoder_get_decode_position() and > > > FLAC__file_decoder_get_decode_position(). I

...in.c:77: error: syntax error before '}' token > > plugin.c:77: warning: type defaults to `int' in declaration of > > `file_info_struct' > > plugin.c:77: warning: data definition has no type or storage class > > plugin.c:97: error: syntax error before "flac_ip" > > plugin.c:97: warning: type defaults to `int' in declaration of > > `flac_ip' > > plugin.c:99: warning: initialization makes integer from pointer > > without > > a cast > > plugin.c:100: warning: excess elements in scalar initializer > >...

...v1.0.2 > [libxmms-shn.so]") Ah, I see. My first guess at what is happening is that both plugins are stomping on each other's global symbols. Looking at flac/src/plugin_xmms/plugin.c, it looks like the only one it could be is get_iplugin_info(): InputPlugin *get_iplugin_info() { flac_ip.description = g_strdup_printf("FLAC Player v%s", FLAC__VERSION_STRING); return &flac_ip; } I copied the basic plugin design from another plugin (I think it was XMMS' WAVE reader). I'm not familiar enough with XMMS' plugin implementation yet but looking at it...

...ata, void *client_data); static void error_callback_(const void *decoder, FLAC__StreamDecoderErrorStatus status, void *client_data); -static void init_decoder_func_tables(); +static void init_decoder_func_tables(void); static decoder_t source_to_decoder_type (const char *source); InputPlugin flac_ip = @@ -181,7 +181,7 @@ static const decoder_funcs_t* DECODER_FU static decoder_funcs_t const * decoder_func_table_; -InputPlugin *get_iplugin_info() +InputPlugin *get_iplugin_info(void) { flac_ip.description = g_strdup_printf("Reference FLAC Player v%s", FLAC__VERSION_STRING); re...

...s_decoded and function > stream_decoder_frame_sync_, which compare it against whole length of > stream. ok, I made the fix, plus there was another place that variable was being set incorrectly. both fixes are in CVS now. > Second problem: Visual plugins are slow. It's caused by > flac_ip.add_vis_pcm, > it gets too many samples (4.5Ksamples) at one call. Solution is in > calling > this with only 512samples. Against plugin.c > actually, there are two versions of the playback loop, controlled by a #define currently. can you try compiling with RESERVOIR_TEST defined and s...

...Inputstring: %s; Error: %s", string, strerror(errno)); #endif break; diff --git a/src/plugin_xmms/http.c b/src/plugin_xmms/http.c index 2f31576c..4bb81870 100644 --- a/src/plugin_xmms/http.c +++ b/src/plugin_xmms/http.c @@ -61,8 +61,6 @@ static gint icy_metaint = 0; extern InputPlugin flac_ip; -#undef DEBUG_UDP - /* Static udp channel functions */ static int udp_establish_listener (gint *sock); static int udp_check_for_data(gint sock); @@ -573,7 +571,7 @@ static int http_connect (gchar *url_, gboolean head, guint64 offset) if (!strncmp(line, "icy-metaint:", 12))...

...Inputstring: %s; Error: %s", string, strerror(errno)); #endif break; diff --git a/src/plugin_xmms/http.c b/src/plugin_xmms/http.c index 05f7300e..161d1b3d 100644 --- a/src/plugin_xmms/http.c +++ b/src/plugin_xmms/http.c @@ -61,8 +61,6 @@ static gint icy_metaint = 0; extern InputPlugin flac_ip; -#undef DEBUG_UDP - /* Static udp channel functions */ static int udp_establish_listener (gint *sock); static int udp_check_for_data(gint sock); @@ -573,7 +571,7 @@ static int http_connect (gchar *url_, gboolean head, guint64 offset) if (!strncmp(line, "icy-metaint:", 12))...

Hi Erik, I've found a middleground for the problem of setting default CFLAGS. I've gone back to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script (i.e., the user hasn't specified anything) and then proceed to set them to the defaults as before. This has been suggested before: https://lists.gnu.org/archive/html/autoconf/2006-04/msg00022.html In

Dear FLAC devs, I would like to get some of our patches merged into master. Most of them deal with adhering to GNU conventions, respectively not overriding flags/variables that are up to the user to set. For instance, honoring $(htmldir) is important, as we have installation paths for the documentation that differ from what is currently coded in the various Makefile.am's. Regards David