Displaying 4 results from an estimated 4 matches for "flac__streamdecoderinitstatus".
Did you mean:
flac__streamdecodeinitstatus
2014 Apr 07
3
Patch to fix compiler warnings and error status collisions
...s/pull requests.
The attached patch fixes all Clang compilation warnings.
Note, some of these warnings were real problems. There is the potential for API users to misinterpret the state being returned since the return variable was of type FLAC__StreamDecoderState, but the value being returned was FLAC__StreamDecoderInitStatus. When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was returned in this case it was indistinguishable from FLAC__STREAM_DECODER_OGG_ERROR.
Is there somewhere that I can push the patch so that it can easily be pulled into the repository or does one of the maintainers just apply the patch an...
2013 Jun 05
1
[PATCH] Disable FLAC__bitreader_read_rice_signed_block_asm_ia32_bswap.
...ned_block.
---
src/libFLAC/stream_decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libFLAC/stream_decoder.c b/src/libFLAC/stream_decoder.c
index f987c27..37934de 100644
--- a/src/libFLAC/stream_decoder.c
+++ b/src/libFLAC/stream_decoder.c
@@ -400,7 +400,7 @@ static FLAC__StreamDecoderInitStatus init_stream_internal_(
#ifdef FLAC__CPU_IA32
FLAC__ASSERT(decoder->private_->cpuinfo.type == FLAC__CPUINFO_TYPE_IA32);
#ifdef FLAC__HAS_NASM
-#if 1 /*@@@@@@ OPT: not clearly faster, needs more testing */
+#if 0 /*@@@@@@ OPT: seems to be slower than FLAC__bitreader_read_rice_signed_block...
2014 Apr 07
0
Patch to fix compiler warnings and error status collisions
...Clang compilation warnings.
I'll check this out.
> Note, some of these warnings were real problems. There is the
> potential for API users to misinterpret the state being returned
> since the return variable was of type FLAC__StreamDecoderState,
> but the value being returned was FLAC__StreamDecoderInitStatus.
> When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was
> returned in this case it was indistinguishable from
> FLAC__STREAM_DECODER_OGG_ERROR.
Problem is this patch changes the ABI because FLAC__StreamDecodeInitStatus
disappears from the API.
Is there some way this can be fixed...
2014 Apr 07
2
Patch to fix compiler warnings and error status collisions
...t;
> I'll check this out.
>
>> Note, some of these warnings were real problems. There is the
>> potential for API users to misinterpret the state being returned
>> since the return variable was of type FLAC__StreamDecoderState,
>> but the value being returned was FLAC__StreamDecoderInitStatus.
>> When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was
>> returned in this case it was indistinguishable from
>> FLAC__STREAM_DECODER_OGG_ERROR.
>
> Problem is this patch changes the ABI because FLAC__StreamDecodeInitStatus
> disappears from the API.
>
>...