search for: flac__streamdecodeinitstatus

...;> but the value being returned was FLAC__StreamDecoderInitStatus. >> When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was >> returned in this case it was indistinguishable from >> FLAC__STREAM_DECODER_OGG_ERROR. > > Problem is this patch changes the ABI because FLAC__StreamDecodeInitStatus > disappears from the API. > > Is there some way this can be fixed without chaning the API/ABI? FLAC__StreamDecodeInitStatus is still there. It is simply another name for FLAC__StreamDecoderState. The API does not change here, other than the numerical value of the enums. However, the bug...

Hi, I am new around here, so I am not sure of all your procedures for submitting patches/pull requests. The attached patch fixes all Clang compilation warnings. Note, some of these warnings were real problems. There is the potential for API users to misinterpret the state being returned since the return variable was of type FLAC__StreamDecoderState, but the value being returned was

...C__StreamDecoderState, > but the value being returned was FLAC__StreamDecoderInitStatus. > When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was > returned in this case it was indistinguishable from > FLAC__STREAM_DECODER_OGG_ERROR. Problem is this patch changes the ABI because FLAC__StreamDecodeInitStatus disappears from the API. Is there some way this can be fixed without chaning the API/ABI? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/