search for: flac__bitwriter_write_zeroes

...ome issues. Not sure if >> this is the right place to submit patches, but someone suggested this on >> the apparently dead SourceForge patch tracker. >> >> The first two are quite straight forward: >> >> - The ICL patch fixes a typo in bitmath.h and adds >> FLAC__bitwriter_write_zeroes to the external declarations in bitwriter.c. >> - The Ogg patch replaces the check for FLAC_API_SUPPORTS_OGG_FLAC in >> stream_decoder.c with FLAC__HAS_OGG to fix compilation with Ogg support. >> >> The _lseeki64 patch probably is a little more controversial. The problem &gt...

Hi all, I tried 1.3.0pre4 with ICL on Windows and found some issues. Not sure if this is the right place to submit patches, but someone suggested this on the apparently dead SourceForge patch tracker. The first two are quite straight forward: - The ICL patch fixes a typo in bitmath.h and adds FLAC__bitwriter_write_zeroes to the external declarations in bitwriter.c. - The Ogg patch replaces the check for FLAC_API_SUPPORTS_OGG_FLAC in stream_decoder.c with FLAC__HAS_OGG to fix compilation with Ogg support. The _lseeki64 patch probably is a little more controversial. The problem is that fseeki64 and ftelli64 are no...

...26:9: warning: called from here [-Winline] ok &= FLAC__bitwriter_write_raw_uint32(bw, 0x80 | (FLAC__uint32)((val>>6)&0x3F), 8); ^ Would it be better to remove the inline keyword from the declaration of FLAC__bitwriter_write_raw_uint32 (and by extension, remove inline from FLAC__bitwriter_write_zeroes and add it to FLAC__bitwriter_write_unary_unsigned)? I suspect that the cache misses caused by code bloat from so much inlining would outweigh the comparable function call overhead, but performance testing would be necessary to confirm this. Best, Evan

...on declaration: MIN > > "bitwriter.c", line 316: reference to static identifier "bitwriter_grow_" in extern inline function > > cc: acomp failed for bitwriter.c > > gmake[4]: *** [bitwriter.lo] Error 1 > > Either bitwriter_grow_ can be made non-static or FLAC__bitwriter_write_zeroes not inline or > also static to work around this. > > The attached patch fixes the issue. Not sure about this patch. Can you please make sure that your C compiler is in the C99 mode and you have optimisation turned on and try again.

...-#define FLaC__INLINE -#endif - struct FLAC__BitWriter { uint32_t *buffer; uint32_t accum; /* accumulator; bits are right-justified; when full, accum is appended to buffer */ @@ -270,7 +266,7 @@ void FLAC__bitwriter_release_buffer(FLAC__BitWriter *bw) (void)bw; } -FLaC__INLINE FLAC__bool FLAC__bitwriter_write_zeroes(FLAC__BitWriter *bw, unsigned bits) +inline FLAC__bool FLAC__bitwriter_write_zeroes(FLAC__BitWriter *bw, unsigned bits) { unsigned n; @@ -308,7 +304,7 @@ FLaC__INLINE FLAC__bool FLAC__bitwriter_write_zeroes(FLAC__BitWriter *bw, unsign return true; } -FLaC__INLINE FLAC__bool FLAC__bitwrite...

...IN >>> "bitwriter.c", line 316: reference to static identifier "bitwriter_grow_" in extern inline function >>> cc: acomp failed for bitwriter.c >>> gmake[4]: *** [bitwriter.lo] Error 1 >> >> Either bitwriter_grow_ can be made non-static or FLAC__bitwriter_write_zeroes not inline or >> also static to work around this. >> >> The attached patch fixes the issue. > > Not sure about this patch. > > Can you please make sure that your C compiler is in the C99 mode and > you have optimisation turned on and try again. > > From m...

...on Windows and found some issues. Not sure if > this is the right place to submit patches, but someone suggested this on > the apparently dead SourceForge patch tracker. > > The first two are quite straight forward: > > - The ICL patch fixes a typo in bitmath.h and adds > FLAC__bitwriter_write_zeroes to the external declarations in bitwriter.c. > - The Ogg patch replaces the check for FLAC_API_SUPPORTS_OGG_FLAC in > stream_decoder.c with FLAC__HAS_OGG to fix compilation with Ogg support. > > The _lseeki64 patch probably is a little more controversial. The problem > is that fse...

...; On 25.5.2013 10:54, Erik de Castro Lopo wrote: >> Robert Kausch wrote: >>> I tried 1.3.0pre4 with ICL on Windows and found some issues. >>> The first two are quite straight forward: >>> >>> - The ICL patch fixes a typo in bitmath.h and adds >>> FLAC__bitwriter_write_zeroes to the external declarations in bitwriter.c. >>> - The Ogg patch replaces the check for FLAC_API_SUPPORTS_OGG_FLAC in >>> stream_decoder.c with FLAC__HAS_OGG to fix compilation with Ogg support. >>> >>> The _lseeki64 patch probably is a little more controversial....

...warning: implicit function declaration: MIN > "bitwriter.c", line 316: reference to static identifier "bitwriter_grow_" in extern inline function > cc: acomp failed for bitwriter.c > gmake[4]: *** [bitwriter.lo] Error 1 Either bitwriter_grow_ can be made non-static or FLAC__bitwriter_write_zeroes not inline or also static to work around this. The attached patch fixes the issue. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Do-not-make-functions-static-which-are-used-by-inlin.patch Type: application/octet-stream Size: 1440 bytes Desc: not availabl...

...g bitreader.c: In function 'FLAC__bitreader_skip_bits_no_crc': bitreader.c:494:4: warning: implicit declaration of function 'MIN' [-Wimplicit-function-declaration] bitreader.c:494:4: warning: nested extern declaration of 'MIN' [-Wnested-externs] bitwriter.c: In function 'FLAC__bitwriter_write_zeroes': bitwriter.c:277:3: warning: implicit declaration of function 'MIN' [-Wimplicit-function-declaration] bitwriter.c:277:3: warning: nested extern declaration of 'MIN' [-Wnested-externs] fixed.c: In function 'FLAC__fixed_compute_best_predictor': fixed.c:241:2: warning: imp...

2013/5/15 Ulrich Klauer <ulrich at chirlu.de> > Felix Homann wrote: > > > Yes, HAVE_SYS_PARAM_H is set in config.h: > > OK ... Yet still I don't see how a change in > src/libFLAC/include/private/macros.h could affect src/flac/utils.c in > any way. > > Anyone got an idea? I haven't spend too much attention to the errors when bisecting, sorry! The

Hi all, The latest pre-release is here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz but there will probably need to be at least one more. I've tested this on x86_64-linux powerpc-linux i386-openbsd5.2 i386-freebsd9 The majority of changes since the last pre-release is the addition of Janne Hyv?rinen's utf8 I/O functionality. Janne's

...ORDS_TO_BITS((bw)->words) + (bw)->bits) -#ifdef min -#undef min -#endif -#define min(x,y) ((x)<(y)?(x):(y)) - /* adjust for compilers that can't understand using LLU suffix for uint64_t literals */ #ifdef _MSC_VER #define FLAC__U64L(x) x @@ -288,7 +284,7 @@ FLaC__INLINE FLAC__bool FLAC__bitwriter_write_zeroes(FLAC__BitWriter *bw, unsign return false; /* first part gets to word alignment */ if(bw->bits) { - n = min(FLAC__BITS_PER_WORD - bw->bits, bits); + n = flac_min(FLAC__BITS_PER_WORD - bw->bits, bits); bw->accum <<= n; bits -= n; bw->bits += n; diff --git a/src/...