search for: finish_transfer

I've run into a bug in the IO handling when reading a file. Suppose I have a file that lives on an NFS filesystem. That filesystem is NOT being exported with auth=0 permissions. So, if I try to access a file as root, it successfully opens the file, but subsequent reads fail with EACCES. This produces a destination file full of null bytes. I noticed this with 2.5.7, but checked 2.6.2 as

...le size at the source and destination. I have looked at the source code and have an alternative suggestion to the way -partial works. I am looking for comment on if people think this is a valid suggestion or am I missing something. 1) In cleanup.c the function _exit_cleanup will call finish_transfer regardless of the code the function receives as a parameter. (see errcode.h for the codes it could receive) 2) Suggest a new function is written to adjust the name of the file the temp file is written to, to be the correct name plus a know extension. This achieves the requirement that the or...

...few cases, the ownership of the files is left as root/other (uid 0, gid 1). I can not replicate the problem, but I suspect the file was modified (or removed) while rsync was running (the rsync take ~30 minutes). I checked the code, and noticed that before "rsync" commit the temp file (finish_transfer @ rsync.c), it changes the file attributes (using 'set_file_Attrs'). However, it does not check if the file attributes were updated succesfully. As a result, it may leave files with the wrong timestamp/ownership or permission. My suggested solution is to modify set_file_perms- return 0 for...

We're using rsync to update the tables on our email relays, and very occasionally we get an error in the logs saying that a table has the wrong permissions. This is because of race conditions in finish_transfer() which mean that it does not update files atomically. This makes rsync not entirely safe to use in our situation, where the files being synced are frequently opened for short periods :-( The specific problems are: (1) The permissions on the file are fixed as the last operation. They should be fi...

...rsync.c:206: dereferencing pointer to incomplete type rsync.c:208: dereferencing pointer to incomplete type rsync.c:152: warning: `change_uid' might be used uninitialized in this function rsync.c:152: warning: `change_gid' might be used uninitialized in this function rsync.c: In function `finish_transfer': rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 I really do not want to use an RPMs, I have searched but only found one person with the same problem - no answers, though. Any help would be greatly appreciated. Thanks Matt

...ot;%s checksum does not match remote checksum\n", + full_fname (fnametmp)); + recv_ok = 0; + } + } + if ((recv_ok && (!delay_updates || !partialptr)) || inplace) { finish_transfer(fname, fnametmp, file, recv_ok, 1); if (partialptr != fname && fnamecmp == partialptr) {

https://bugzilla.samba.org/show_bug.cgi?id=5147 Summary: Read-only files that have changed xattrs fail to allow xattr changes Product: rsync Version: 2.6.9 Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned@samba.org

Hallo, I am using rsync to copy remote files into a local directory. I use the following flags: "--remove-sent-files --partial-dir=/tmp --partial --temp-dir=/tmp --backup --suffix=.bak". I need the partial issue since in the final destination I must have only closed and full files. I need to remove the sent files from the destination since I need to avoid transferring the same file

...am sending some compressor patches. I am very new to the rsync source, so here a list of what i did: options.c - added -X and -Z options (-Z is passed thru a server wenn using user@host.foo:/directory) flist.c: extension ".rsc" is added to every file/directory (in -Z mode) rsync.c: finish_transfer() now does the compression when in -Z mode before stating the file. That means the compressed file has the same stat as the uncompressed file. receiver.c: I added two new functions: - storage_decompress: this will decompress an .rsc file to a tmp file, e.g. for calculating sums (note: a delete...

I am rsyncing 1tb of data each day. I am finding in my testing that actually removing the target files each day then rsyncing is faster than doing a compare of the source->target files then rsyncing over the delta blocks. This is because we have a fast link between the two boxes, and that are disk is fairly slow. I am finding that the creation of the temp file (the 'dot file') is

...e rsync.c:206: dereferencing pointer to incomplete type rsync.c:208: dereferencing pointer to incomplete type rsync.c:152: warning: `change_uid' might be used uninitialized in this function rsync.c:152: warning: `change_gid' might be used uninitialized in this function rsync.c: In function `finish_transfer': rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 ================================ cut _____________________________________________________________________ ? ?? ?! ??? ??? ??? - ??! ??? http://avatar.yahoo.co.kr/ ???? ????? ???? ? ??? - ??! ?? http://chat.y...

...er over ssh, I get the message rsync error: unexplained error (code 130) at rsync.c(271) [generator=2.6.9] ERROR: /usr/bin/rsync returned 130 while processing root@undertow:/ I looked at the source for rsync 2.6.9, and line 271 in rsync.c is just a comment. Furthermore, it is in the function void finish_transfer(), so I don't see how it could return 130. Does anybody know in which cases rsync might return 130, and what it means?

...gotcha's? Paul --- a/cleanup.c 2012-04-15 14:14:02.913993934 +0200 +++ b/cleanup.c 2012-04-15 14:13:58.834033097 +0200 @@ -157,8 +157,9 @@ flush_write_file(cleanup_fd_w); close(cleanup_fd_w); } + cleanup_file->modtime = 0; /* solves problem with --partial --update */ finish_transfer(cleanup_new_fname, fname, NULL, NULL, - cleanup_file, 0, !partial_dir); + cleanup_file, 1, !partial_dir); } /* FALLTHROUGH */ On Sun 01 May 2011, Samuel Thibault wrote: > > Hello, > > My rsync script uses both options -u and --partial. This results into > partial...

...te type rsync.c:194: dereferencing pointer to incomplete type rsync.c:198: dereferencing pointer to incomplete type rsync.c:199: dereferencing pointer to incomplete type rsync.c:217: dereferencing pointer to incomplete type rsync.c:219: dereferencing pointer to incomplete type rsync.c: In function `finish_transfer': rsync.c:265: dereferencing pointer to incomplete type *** Error code 1 make: Fatal error: Command failed for target `rsync.o' -----8<------------------------------------------------------------ The machine is a Sun Sparc Ultra 250. here is the "uname -a" output: SunOS suntst...

...For whatever reason, the sender doesn't correctly pick this up and it in turn aborts. People have "worked around" this problem by using "-T", putting the received file in temp space (assuming it's big enough). That allows the receive to complete without error, but then finish_transfer() will get an error in copy_file() copying from the temp space to the destination (which may presumably still fill up). At least this tells you about the error and doesn't blow up, but it always leaves the partially transferred file (in my case, if it fills the small partition, I don't wa...

...6: dereferencing pointer to incomplete type rsync.c:208: dereferencing pointer to incomplete type rsync.c:152: warning: `change_uid' might be used uninitialized in this function rsync.c:152: warning: `change_gid' might be used uninitialized in this function rsync.c: In function `finish_transfer': rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 Some info about the build environment: uname -sr Linux 2.2.20 gcc --version egcs-2.91.66 ls -d /lib/libc* /lib/libc-2.1.2.so /lib/libc.so.6 /lib/libcrypt.so.1 make --version GNU Make versi...

All callers of robust_rename() call copy_file() if EXDEV is received. This patch moves the copy_file() call into robust_rename(). Patch Summary: -12 +1 backup.c -15 +2 rsync.c -9 +33 util.c -------------- next part -------------- patchwork diff util.c --- util.c 2004-02-17 09:58:44.000000000 -0500 +++ util.c 2004-02-17 10:21:22.000000000 -0500 @@ -355,16 +355,40 @@

...ike RSYNC does not set the file timestamp to the original timestamp... In fact, it is set to the current time. So, the next time RSYNC is run, it just copies all the files. Have downloaded the source & tried to figure out what's causing the problem. The timestamp is set properly after finish_transfer(). However, it gets reset after 8 files have been copied; i.e after 8 files have been copied, the time stamp of the 1st copied file is reset... after 9 files, 2nd file get reset, 10 files, 3rd file get reset & so on. Looks like the problem is somewhere in recv_files() / receive_data()... Cou...

...son, the sender doesn't handle this gracefully, and in turn aborts. People have "worked around" this problem by using "-T", putting the received file in temp space (assuming it's big enough). That allows the receive to complete without error (avoiding the abort). Then finish_transfer() will copy the file from the temp space, overwriting the destination file using copy_file(), which usually avoids filling the destination partition. Thus, using "-T" is the only way to transfer into a nearly full partition. However, there is one other problem: if copy_file() fills up t...

...{ + sprintf(fnametmp, "/proc/self/fd/%d", fd2); + } else { + close(fd1); + } if (verbose > 2) rprintf(FINFO,"renaming %s to %s\n",fnametmp,fname); finish_transfer(fname, fnametmp, file); + close(fd2); cleanup_disable(); if (!recv_ok) { -- Hans Eric Sandstr?m MailCORE AB ps. A --lock option to mutually exclude updates to the same file from competing rsyncs would be a nice feature. That would sort of obsolete t...