search for: fbuf

...uint32_t count, uint64_t offset) +sh_pwrite (void *handle, const void *buf, uint32_t count, uint64_t offset, + uint32_t flags) { char *h = handle; - char cbuf[32], obuf[32]; - const char *args[] = { script, "pwrite", h, cbuf, obuf, NULL }; + char cbuf[32], obuf[32], fbuf[32]; + const char *args[] = { script, "pwrite", h, cbuf, obuf, fbuf, NULL }; snprintf (cbuf, sizeof cbuf, "%" PRIu32, count); snprintf (obuf, sizeof obuf, "%" PRIu64, offset); + flags_string (flags, fbuf, sizeof fbuf); switch (call_write (buf, count, arg...

...*data = NULL; size_t len; @@ -395,9 +411,9 @@ sh_pwrite (void *handle, const void *buf, uint32_t count, uint64_t offset, { const char *method = "pwrite"; const char *script = get_script (method); - char *h = handle; + struct sh_handle *h = handle; char cbuf[32], obuf[32], fbuf[32]; - const char *args[] = { script, method, h, cbuf, obuf, fbuf, NULL }; + const char *args[] = { script, method, h->h, cbuf, obuf, fbuf, NULL }; snprintf (cbuf, sizeof cbuf, "%" PRIu32, count); snprintf (obuf, sizeof obuf, "%" PRIu64, offset); @@ -429,8 +445,8 @@...

...000000000 -0400 +++ rsync-2.6.6-nfc/flist.c 2005-10-26 15:18:01.000000000 -0400 @@ -1748,8 +1748,11 @@ * buffer. No size-checking is done because we checked the size when creating * the file_struct entry. */ +#include <stringprep.h> char *f_name_to(struct file_struct *f, char *fbuf) { + char *norm; + if (!f || !f->basename) return NULL; @@ -1760,6 +1763,11 @@ strcpy(fbuf + len + 1, f->basename); } else strcpy(fbuf, f->basename); + + norm = stringprep_utf8_nfkc_normalize(fbuf, -1); +...

https://bugzilla.samba.org/show_bug.cgi?id=13901 Bug ID: 13901 Summary: Empty quotes adds cwd to SRC directories Product: rsync Version: 3.1.3 Hardware: x64 OS: Linux Status: NEW Severity: normal Priority: P5 Component: core Assignee: wayne at opencoder.net Reporter:

https://bugzilla.samba.org/show_bug.cgi?id=12806 Bug ID: 12806 Summary: Deleting in a row of hardlinked snapshots resets file permissions. Product: rsync Version: 3.1.0 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core

...& !am_root && fp->flags & FLAG_OWNED_BY_US) + do_chmod(fname, fp->mode | S_IWUSR); if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS) ret = DR_NOT_EMPTY; } @@ -138,14 +138,13 @@ enum delret delete_item(char *fbuf, uint16 mode, uint16 flags) fbuf, (int)mode, (int)flags); } - if (flags & DEL_NO_UID_WRITE) - do_chmod(fbuf, mode | S_IWUSR); - if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) { /* This only happens on the first call to delete_item() sinc...

...protection exception. rsync-2.6.9 was running fine! I can't figure out why exactly it crashes. I hope that someone on this list can give me a hint on that. This is the debug output (appeared when I tried to copy a local directory to another location): FDBX0302: calling f_name(f = 0x1EA94000, fbuf = ".s.-.~~q.s.-.~~..~~.") from function send_file_name FDBX0303: returning <no value> from f_name FDBX0302: calling f_name(f = 0x1EA93FC8, fbuf = "") from function send_file_name FDBX0303: returning <no value> from f_name FDBX0302: calling f_name(f = 0x1EA93F90, fbuf...

...1 00:18:24.57 0090.7a0a.13f3 (192.168.003.123) [0007] Call start, AP 0014.d1c2.70fe (-32 dBm) Feb 23 20:25:09 192.168.3.123 Jan 1 00:18:26.87 0090.7a0a.13f3 (192.168.003.123) [0008] Number Abufs: 26 Feb 23 20:25:09 192.168.3.123 Jan 1 00:18:26.87 0090.7a0a.13f3 (192.168.003.123) [0009] Number Fbufs: 2 Feb 23 20:25:09 192.168.3.123 Jan 1 00:18:26.88 0090.7a0a.13f3 (192.168.003.123) [000a] Max Number Abufs: 359 Feb 23 20:25:09 192.168.3.123 Jan 1 00:18:26.88 0090.7a0a.13f3 (192.168.003.123) [000b] Max Number Fbufs: 33 Feb 23 20:25:11 192.168.3.123 Jan 1 00:18:29.57 0090.7a0a.13f3 (192.16...

...ist *flist, char *local_name) { int i; int phase = 0; --- 545,551 ---- } ! void generate_files(int f_out, struct file_list *flist, char *local_name) { int i; int phase = 0; *************** *** 584,590 **** } recv_generator(local_name ? local_name : f_name_to(file, fbuf), ! file, i, f); } phase++; --- 586,592 ---- } recv_generator(local_name ? local_name : f_name_to(file, fbuf), ! file, i, f_out); } phase++; *************** *** 594,614 **** if (verbose > 2) rprintf(FINFO,"generate_files phase=%d\n&quo...

...'.' && (dname[1] == '\0' || (dname[1] == '.' && dname[2] == '\0'))) continue; + if (dname[0] == '\0') { + char replaced = 0; + io_error |= IOERR_GENERAL; + if (len > 0) { + replaced = fbuf[len+1]; + fbuf[len+1] = '\0'; + } + rprintf(FINFO, + "cannot send file with empty name %s\n", + full_fname(fbuf)); + if (replaced) + fbuf[len+1] = replaced; + cont...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-December/thread.html#00123 v2: - Document "-" instead of "script=-" and use it in the test; and verify this also works on FreeBSD; and verify that it doesn't depend on the particular behaviour of our wrapper script and should work with installed nbdkit too. - Fix handling of zero flags parameter. -

...O_EXCL, 0600)) < 0) { int save_errno = errno ? errno : EINVAL; /* 0 paranoia */ if (errno == ENOENT && make_bak_dir(backupptr) == 0) { Does make_bak_dir simply need to trap for that error, like: /* Try to find an existing dir, starting from the deepest dir. */ while (1) { if (--p == fbuf) return -1; if (*p == '/') { *p = '\0'; if (mkdir_defmode(fbuf) == 0 || errno == EEXIST) // <-- Trap for EEXIST? break; if (errno != ENOENT) { rsyserr(FERROR, errno, "make_bak_dir mkdir %s failed", full_fname(fbuf)); return -1; } } } Thanks...

...ote_argc=0, f_in_p=0xfffd8ed0, f_out_p=0xfffd8ecc) at main.c:469 #8 0x08065f4b in main (argc=Cannot access memory at address 0x0 ) at main.c:1275 (gdb) p dir_depth $5 = 3695 (gdb) up #1 0x080544c3 in do_delete_pass () at generator.c:548 548 change_local_filter_dir(fbuf, strlen(fbuf), F_DEPTH(file)); (gdb) info local file = (struct file_struct *) 0xf73f738c fbuf = "rsync.include.drive_b\000b" st = {st_dev = 65024, __pad1 = 0, __st_ino = 323281, st_mode = 16877, st_nlink = 3, st_uid = 0, st_gid = 0, st_rdev = 0, __pad2 = 0, st_size = 4096, st_blksiz...

When I added .can_FOO caching in 1.16, I missed the case that the sh plugin itself was calling .can_flush twice in some situations (in order to default .can_fua). Then right after, I regressed it to call .can_zero twice (in order to default .can_fast_zero). I also missed that .thread_model could use better caching, because at the time, I did not add testsuite coverage. Fix that now. Eric Blake

...ward declarations. */ --- 133,139 ---- }; enum delret { ! DR_SUCCESS = 0, DR_FAILURE, DR_AT_LIMIT, DR_NOT_EMPTY, DR_NEWER }; /* Forward declarations. */ *************** *** 160,165 **** --- 161,192 ---- char *what; int ok; + struct stat attrib; + stat(fbuf, &attrib); + if ( (check_point>=0)&&(check_point <= attrib.st_mtime) ) { + //if (!S_ISDIR(mode)) { + if (verbose > 0) { + rprintf(FINFO, "checkpoint: new item (%s), deletion skiped", fbuf); +...

...the printout comes (strings replaced with "..."): (gdb) bt #0 0x9012b760 in malloc_printf () #1 0x90005f5c in free () #2 0x00037fd4 in uncache_tmp_xattrs () at xattrs.c:754 #3 0x00023c08 in make_backup (fname=0xbfffd118 "...") at backup.c:369 #4 0x0000bbb8 in delete_item (fbuf=0xbfffd118 "...", mode=33152, flags=17448) at generator.c:198 #5 0x0000b970 in delete_dir_contents (fname=0xbfffd118 "...", flags=4) at generator.c:304 #6 0x0000bab8 in delete_item (fbuf=0xbfffd118 "...", mode=16832, flags=2) at generator.c:179 #7 0x0000c2a8 in dele...

...changelog it would seem that the delete code has changed.I have a (barely tested) patch for 2.6.3 here: --- rsync-2.6.3.orig/receiver.c 2004-09-21 11:24:06.000000000 +0200 +++ rsync-2.6.3/receiver.c 2005-03-02 15:41:26.000000000 +0100 @@ -93,6 +93,7 @@ int i, j; char *argv[1], fbuf[MAXPATHLEN]; static int deletion_count; + int deletion_test_count; if (cvs_exclude) add_cvs_excludes(); @@ -102,6 +103,38 @@ return; } + /* if --max-delete is specified, check that not too many files will be deleted */ + if...

https://bugzilla.samba.org/show_bug.cgi?id=13445 Bug ID: 13445 Summary: Fuzzy searching in link-dest tries to open regular file as directory Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core

As the start of work to add remote support, I'm taking a close look at the protocol layer in the library. These are some small cleanups. Rich.

...afe environments better 6366301 CREATE with owner_group attribute is not set correctly with NFSv4/ZFS 6373978 want to take lots of snapshots quickly (''zfs snapshot -r'') 6385436 zfs set returns an error, but still sets property value 6393490 libzfs should be a real library 6397148 fbufs debug code should be removed from buf_hash_insert() 6401400 zfs(1) usage output is excessively long 6405330 swap on zvol isn''t added during boot 6405966 Hot Spare support in ZFS 6409228 typo in aclutils.h 6409302 passing a non-root vdev via zpool_create() panics system 6415739 assertion f...