search for: fb

...e: > Hello, > > syzbot found the following crash on: > > HEAD commit: acb1872577b3 Linux 4.18-rc7 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14eb932c400000 > kernel config: https://syzkaller.appspot.com/x/.config?x=2dc0cd7c2eefb46f > dashboard link: https://syzkaller.appspot.com/bug?extid=bd391451452fb0b93039 > compiler: gcc (GCC) 8.0.1 20180413 (experimental) > > Unfortunately, I don't have any reproducer for this crash yet. > > IMPORTANT: if you fix the bug, please add the following tag to t...

...ect pointer. TESTED: compiled: allyesconfig ARCH=x86,arm platforms:i915, rockchip Signed-off-by: Joe Kniss <djmk at google.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 50 +++++++----------- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 20 +++---- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 8 +-- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c...

...ect pointer. TESTED: compiled: allyesconfig ARCH=x86,arm platforms:i915, rockchip Signed-off-by: Joe Kniss <djmk at google.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 50 +++++++----------- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 20 +++---- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 8 +-- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c...

...ect pointer. TESTED: compiled: allyesconfig ARCH=x86,arm platforms:i915, rockchip Signed-off-by: Joe Kniss <djmk at google.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 50 +++++++----------- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 20 +++---- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 8 +-- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 19 +++---- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c...

...immermann <tzimmermann at suse.de> > --- > drivers/gpu/drm/nouveau/dispnv50/wndw.c | 26 +++++++++++------------ > drivers/gpu/drm/nouveau/nouveau_display.c | 14 ++++++------ > drivers/gpu/drm/nouveau/nouveau_display.h | 12 +---------- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 14 ++++++------ > 4 files changed, 28 insertions(+), 38 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c > index ba1399965a1c..4a67a656e007 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c > +++ b/dri...

...;>> --- >>> ? drivers/gpu/drm/nouveau/dispnv50/wndw.c?? | 26 +++++++++++------------ >>> ? drivers/gpu/drm/nouveau/nouveau_display.c | 14 ++++++------ >>> ? drivers/gpu/drm/nouveau/nouveau_display.h | 12 +---------- >>> ? drivers/gpu/drm/nouveau/nouveau_fbcon.c?? | 14 ++++++------ >>> ? 4 files changed, 28 insertions(+), 38 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c >>> b/drivers/gpu/drm/nouveau/dispnv50/wndw.c >>> index ba1399965a1c..4a67a656e007 100644 >>> --- a/d...

...ticularly useful. However, as nouveau interfaces evolve towards the HW capabilities and add support for newer graphics APIs, saying an entire BO has a singular layout becomes less meaningful, so I suspect those fields will be effectively deprecated in favor of the modifier-defined and, for non-FB operations, strictly userspace defined layout. Doing so will be much easier if the modifier support is already in place for applications to start making use of. Thanks, -James On 2/6/20 7:28 AM, Roy Spliet wrote: > (Re-sending to list rather than just to James) > > Is this format mo...

...000000000 00000000000d000d 00000001ffffffff 0000000000000000 [ 46.169369] page dumped because: kasan: bad access detected [ 46.169377] Memory state around the buggy address: [ 46.169383] ffff8803400da500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [ 46.169388] ffff8803400da580: fc fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 46.169394] >ffff8803400da600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 46.169398] ^ [ 46.169403] ffff8803400da680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 46.169408] ffff8803400da700: fb fb fb fb fb...

...000000000 00000000000d000d 00000001ffffffff 0000000000000000 [ 46.169369] page dumped because: kasan: bad access detected [ 46.169377] Memory state around the buggy address: [ 46.169383] ffff8803400da500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [ 46.169388] ffff8803400da580: fc fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 46.169394] >ffff8803400da600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 46.169398] ^ [ 46.169403] ffff8803400da680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 46.169408] ffff8803400da700: fb fb fb fb fb...

...veau/dispnv50/wndw.c | 26 > >>>> +++++++++++------------ > >>>> drivers/gpu/drm/nouveau/nouveau_display.c | 14 ++++++------ > >>>> drivers/gpu/drm/nouveau/nouveau_display.h | 12 +---------- > >>>> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 14 ++++++------ > >>>> 4 files changed, 28 insertions(+), 38 deletions(-) > >>>> > >>>> diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c > >>>> b/drivers/gpu/drm/nouveau/dispnv50/wndw.c > >>>> index ba1399965...

All fields in struct nouveau_framebuffer appear to be obsolete. The data structure can be replaced by struct drm_framebuffer entirely. Patch 1 removes several unused fields from struct nouveau_framebuffer. Patch 2 moves the field vma to struct nouveau_fbdev. The information in vma is only relevant for fbdev emulation, and as such he field is only used there. Patch 3 removes nvbo from struct nouveau_framebuffer. The nouveau buffer object is based on gem, and as such should be stored in obj[0] of struct drm_framebuffer. This also enables the use of...

...s <djmk at google.com> > --- Hi Joe, I'm also looking into adding gem objs to drm_framebuffer in this patch: [PATCH v2 01/22] drm: Add GEM backed framebuffer library https://lists.freedesktop.org/archives/dri-devel/2017-August/149782.html [...] > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index ade319d10e70..f5f011b910b1 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -31,14 +31,9 @@ > > #define DEFAULT_FBDEFIO_DELAY_MS 50 > > -struct drm_fb_cma {...

...nly v4 will work. >> I've taken Tomas' cleanup patches in my tree, and will take James' >> also once they've been fixed up to work on top of the cleanup. > > Thanks! After applying this series locally, I'm hitting a NULL deref loading the nouveau module with fbconsole caused by patch 3/4. I've sent out a trivial fix for review separately. Please have a look, and Ben, feel free to squash it with Thomas's original patch if you prefer. >> >> James, are you happy for me to take the drm_fourcc.h patch that's on >> dri-devel t...

After observing random crashes on Tegra devices when patch "fb/gf100: defer DMA mapping of scratch page to oneinit() hook" was applied, I noticed that moving the 100c10 page allocation to the oneinit() hook resulted in that page being now allocated for Tegra as well, and accesses be made to members of gf100_fb which were not accessible because gk20a_fb_ne...

...much better way to address this, but this fixes the problem I get on AMD Seattle with a GeForce 210 PCIe card: nouveau 0000:02:00.0: enabling device (0000 -> 0003) nouveau 0000:02:00.0: NVIDIA GT218 (0a8280b1) nouveau 0000:02:00.0: bios: version 70.18.a6.00.00 nouveau 0000:02:00.0: fb ctor failed, -14 nouveau: probe of 0000:02:00.0 failed with error -14 v2: replace incorrect comparison of dma_addr_t type var against NULL drivers/gpu/drm/nouveau/nvkm/subdev/fb/nv50.c | 37 ++++++++++++++------ 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/n...

...tly. Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 26 +++++++++++------------ drivers/gpu/drm/nouveau/nouveau_display.c | 14 ++++++------ drivers/gpu/drm/nouveau/nouveau_display.h | 12 +---------- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 14 ++++++------ 4 files changed, 28 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c index ba1399965a1c..4a67a656e007 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c +++ b/drivers/gpu/drm/nouveau/dispnv50/w...

Explicitly declare constants are unsigned long to address the following sparse warnings: warning: constant is so big it is long Signed-off-by: Wambui Karuga <wambui.karugax at gmail.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf108.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm107.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgm200.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp100....

...ffffffff > 0000000000000000 > [?? 46.169369] page dumped because: kasan: bad access detected > > [?? 46.169377] Memory state around the buggy address: > [?? 46.169383]? ffff8803400da500: fc fc fc fc fc fc fc fc fc fc fc fc fc > fc fc fc > [?? 46.169388]? ffff8803400da580: fc fb fb fb fb fb fb fb fb fb fb fb fb > fb fb fb > [?? 46.169394] >ffff8803400da600: fb fb fb fb fb fb fb fb fb fb fb fb fb > fb fb fb > [?? 46.169398]?????????????????????? ^ > [?? 46.169403]? ffff8803400da680: fb fb fb fb fb fb fb fb fb fb fb fb fb > fb fb fb > [?? 46.169408...

...rmann at suse.de> >> --- >> ? drivers/gpu/drm/nouveau/dispnv50/wndw.c?? | 26 +++++++++++------------ >> ? drivers/gpu/drm/nouveau/nouveau_display.c | 14 ++++++------ >> ? drivers/gpu/drm/nouveau/nouveau_display.h | 12 +---------- >> ? drivers/gpu/drm/nouveau/nouveau_fbcon.c?? | 14 ++++++------ >> ? 4 files changed, 28 insertions(+), 38 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c >> b/drivers/gpu/drm/nouveau/dispnv50/wndw.c >> index ba1399965a1c..4a67a656e007 100644 >> --- a/drivers/gpu/drm/nouveau/d...

Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203 Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common code") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 + drivers/gpu/drm/nouveau/...