Karol Herbst
2023-Apr-05 11:04 UTC
[Nouveau] [PATCH] drm/nouveau/fb: add missing sysmen flush callbacks
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203
Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common
code")
Signed-off-by: Karol Herbst <kherbst at redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
index 76678dd60f93f..c4c6f67af7ccc 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
@@ -31,6 +31,7 @@ gf108_fb = {
.init = gf100_fb_init,
.init_page = gf100_fb_init_page,
.intr = gf100_fb_intr,
+ .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
.ram_new = gf108_ram_new,
.default_bigpage = 17,
};
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
index f73442ccb424b..433fa966ba231 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
@@ -77,6 +77,7 @@ gk104_fb = {
.init = gf100_fb_init,
.init_page = gf100_fb_init_page,
.intr = gf100_fb_intr,
+ .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
.ram_new = gk104_ram_new,
.default_bigpage = 17,
.clkgate_pack = gk104_fb_clkgate_pack,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
index 45d6cdffafeed..4dc283dedf8b5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
@@ -59,6 +59,7 @@ gk110_fb = {
.init = gf100_fb_init,
.init_page = gf100_fb_init_page,
.intr = gf100_fb_intr,
+ .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
.ram_new = gk104_ram_new,
.default_bigpage = 17,
.clkgate_pack = gk110_fb_clkgate_pack,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
index de52462a92bf0..90bfff616d35b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
@@ -31,6 +31,7 @@ gm107_fb = {
.init = gf100_fb_init,
.init_page = gf100_fb_init_page,
.intr = gf100_fb_intr,
+ .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
.ram_new = gm107_ram_new,
.default_bigpage = 17,
};
--
2.39.2
Lyude Paul
2023-Apr-07 23:15 UTC
[Nouveau] [PATCH] drm/nouveau/fb: add missing sysmen flush callbacks
Reviewed-by: Lyude Paul <lyude at redhat.com> On Wed, 2023-04-05 at 13:04 +0200, Karol Herbst wrote:> Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203 > Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common code") > Signed-off-by: Karol Herbst <kherbst at redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c > index 76678dd60f93f..c4c6f67af7ccc 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c > @@ -31,6 +31,7 @@ gf108_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gf108_ram_new, > .default_bigpage = 17, > }; > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c > index f73442ccb424b..433fa966ba231 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c > @@ -77,6 +77,7 @@ gk104_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gk104_ram_new, > .default_bigpage = 17, > .clkgate_pack = gk104_fb_clkgate_pack, > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c > index 45d6cdffafeed..4dc283dedf8b5 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c > @@ -59,6 +59,7 @@ gk110_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gk104_ram_new, > .default_bigpage = 17, > .clkgate_pack = gk110_fb_clkgate_pack, > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c > index de52462a92bf0..90bfff616d35b 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c > @@ -31,6 +31,7 @@ gm107_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gm107_ram_new, > .default_bigpage = 17, > };-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
Ben Skeggs
2023-Apr-10 22:05 UTC
[Nouveau] [PATCH] drm/nouveau/fb: add missing sysmen flush callbacks
On Wed, 5 Apr 2023 at 21:05, Karol Herbst <kherbst at redhat.com> wrote:> > Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203 > Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common code") > Signed-off-by: Karol Herbst <kherbst at redhat.com>Oops, that must've gotten lost in a rebase somehow. Reviewed-by: Ben Skeggs <bskeggs at redhat.com>> --- > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c > index 76678dd60f93f..c4c6f67af7ccc 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c > @@ -31,6 +31,7 @@ gf108_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gf108_ram_new, > .default_bigpage = 17, > }; > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c > index f73442ccb424b..433fa966ba231 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c > @@ -77,6 +77,7 @@ gk104_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gk104_ram_new, > .default_bigpage = 17, > .clkgate_pack = gk104_fb_clkgate_pack, > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c > index 45d6cdffafeed..4dc283dedf8b5 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c > @@ -59,6 +59,7 @@ gk110_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gk104_ram_new, > .default_bigpage = 17, > .clkgate_pack = gk110_fb_clkgate_pack, > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c > index de52462a92bf0..90bfff616d35b 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c > @@ -31,6 +31,7 @@ gm107_fb = { > .init = gf100_fb_init, > .init_page = gf100_fb_init_page, > .intr = gf100_fb_intr, > + .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init, > .ram_new = gm107_ram_new, > .default_bigpage = 17, > }; > -- > 2.39.2 >
Maybe Matching Threads
- [RFC v2 3/4] drm/nouveau: Add support for BLCG on Kepler2
- [PATCH 0/3] fb fixes for gk20a/gm20b
- [RFC v2 0/4] Implement full clockgating for Kepler1 and 2
- [RFC v4 0/5] Implement full clockgating for Kepler1 and 2
- [RFC v5 0/5] Implement full clockgating for Kepler1 and 2