search for: externalproject_add

...+make build. > > > > This is possible with CMake using the ExternalProject module: > > > > > http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:ExternalProject > > > > The add_llvm_external_project macro already in LLVM could be taught > > to call ExternalProject_Add instead of add_subdirectory. This could > > create a custom target with dependencies appropriately configured to > > build after Clang. The custom target would run CMake to configure the > > project like an outside build and then launch the build. > > > > IIUC there...

Hi Brad, I have a few questions regarding ExternalProject_Add. For me it doesn't really work as expected. I add the following code to the tools/clang/runtime/CMakeLists.txt to configure compiler-rt as external project: ExternalProject_Add(compiler-rt #DEPENDS clang clang++ llvm-config PREFIX ${CMAKE_BINARY_DIR}/projects/compiler-rt SOURCE...

...just-built-Clang should be a default scenario, like it is in configure+make build. This is possible with CMake using the ExternalProject module: http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:ExternalProject The add_llvm_external_project macro already in LLVM could be taught to call ExternalProject_Add instead of add_subdirectory. This could create a custom target with dependencies appropriately configured to build after Clang. The custom target would run CMake to configure the project like an outside build and then launch the build. IIUC there is a desire for Clang to be able to be built exte...

On Wed, Feb 26, 2014 at 9:58 PM, Brad King <brad.king at kitware.com> wrote: > On 02/26/2014 12:43 PM, Alexey Samsonov wrote: > > Do you think it makes sense to land my ExternalProject_Add patch > > so that others can experiment with it? I can add quit with a > > fatal_error/warning if the build tree rules are generated with Ninja. > > Since it is conditional on LLVM_BUILD_EXTERNAL_COMPILER_RT, yes. > Submitted as r202367. > > > parallelism doesn'...

Hi Brad, Thanks for investigating this. Do you think it makes sense to land my ExternalProject_Add patch so that others can experiment with it? I can add quit with a fatal_error/warning if the build tree rules are generated with Ninja. However, there is a problem with Unix Makefiles as well: parallelism doesn't work when I run "make check-compiler-rt -j8" in the original build tree...

On Thu, Mar 20, 2014 at 10:12 PM, Greg Fitzgerald <garious at gmail.com> wrote: > > ExternalProject_Add(compiler-rt ...) > > So that was quite the experiment. Looking at > clang/runtime/CMakeLists.txt, I'm not seeing a lot of bang for buck > here, and it looks like this file is prone to bit rot. Could you please elaborate on this? In fact, I don't plan to give up on this experi...

...t solves. For one, it can't be used from > within the monolithic build (unless you have a duplicate llvm build, > or point CompilerRT to a subset of the currently-building LLVM build). > Could you elaborate on this? That's exactly what I'm trying to do now - when I call "ExternalProject_Add(compiler-rt)" from Clang build tree, I use just-built llvm-config to configure it, and set up the paths so that "make compiler-rt" in compiler-rt build tree will build the libraries in the proper locations, where Clang driver expects to find them. Maybe, I don't understand what y...

...d the compiler-rt libraries. > > ExternalProject was originally designed for two purposes: > > * Build third-party dependences on which local development will > not be done > > * Manage a "superbuild" project that has no binaries of its own > but has a bunch of ExternalProject_Add calls to drive set up > of a bunch of build trees. Local development then occurs in > each tree manually. > > Using ExternalProject for a recursive-make-like structure was > only later proposed as a use case. In order to make the build > step always run you need to make it d...

The trouble is that the sanitizer tests are not really compiler-rt tests. The original compiler-rt tests are, but not the sanitizer tests. The sanitizer tests are "compiler-rt tests via clang". The sanitizer runtime is a C++ library requiring only a C++ compiler to build it (and to *unit* test it). The ASan lit tests, however, require clang, because they are testing those C++

On Mon, Feb 24, 2014 at 8:26 PM, Brad King <brad.king at kitware.com> wrote: > On 02/24/2014 10:02 AM, Alexey Samsonov wrote: > > Yes, 2.8.10.2 to be exact. > > Well, the upstream change I made to simplify this feature in > the future: > > ExternalProject: Add option to always run the build step > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=73e5c6ae >

Thank you very much for the feedback! What Chandler said about test-suite totally makes sense to me since it's also excluded from LLVM git monorepo. I will try to land benchmark library to LLVM core repo and update it to the latest version. I have not been doing much CMake/project structure before, but I'll start looking into that next week. I'll reach out to Dominic if anything goes