On Mon, Feb 24, 2014 at 6:57 PM, Brad King <brad.king at kitware.com> wrote:> On 02/24/2014 09:44 AM, Alexey Samsonov wrote: > > ExternalProject_Add_Step(compiler-rt force-rebuild > > DEPENDERS build > [snip] > > doesn't work for Ninja. > > What version of CMake did you use for this test? Also 2.8.10? >Yes, 2.8.10.2 to be exact.> > > Is it a CMake bug? > > Yes, though there have been some changes related to this upstream > since 2.8.10, IIRC. > > I think you can just go with your original "DEPENDERS configure" > approach for now. >"DEPENDERS configure" doesn't help this Ninja issue.> > -Brad > >-- Alexey Samsonov, MSK -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140224/65a743e9/attachment.html>
On 02/24/2014 10:02 AM, Alexey Samsonov wrote:> Yes, 2.8.10.2 to be exact.Well, the upstream change I made to simplify this feature in the future: ExternalProject: Add option to always run the build step http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=73e5c6ae includes a test that touches a file in the external project source. It passes our test suite with the Ninja generator. Please see if you can reproduce this with CMake 'master' from Git: git clone git://cmake.org/cmake.git CMake && mkdir CMake-build && cd CMake-build && ../CMake/bootstrap --parallel=8 && make -j 8 && bin/cmake --version Thanks, -Brad
On Mon, Feb 24, 2014 at 8:26 PM, Brad King <brad.king at kitware.com> wrote:> On 02/24/2014 10:02 AM, Alexey Samsonov wrote: > > Yes, 2.8.10.2 to be exact. > > Well, the upstream change I made to simplify this feature in > the future: > > ExternalProject: Add option to always run the build step > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=73e5c6ae > > includes a test that touches a file in the external project > source. It passes our test suite with the Ninja generator. > > Please see if you can reproduce this with CMake 'master' from > Git: >Yep, I can reproduce it with latest CMake and ninja: $ cmake --version cmake version 3.0.20140225-gcd8c $ ninja --version 1.4.0.git I configure LLVM with -DLLVM_BUILD_EXTERNAL_COMPILER_RT=ON (with applied patches http://llvm-reviews.chandlerc.com/D2868 and http://llvm-reviews.chandlerc.com/D2874) Then I run $ ninja compiler-rt twice. The first run builds the libraries, the second shows only: "ninja: no work to do." message.> > git clone git://cmake.org/cmake.git CMake && > mkdir CMake-build && > cd CMake-build && > ../CMake/bootstrap --parallel=8 && > make -j 8 && > bin/cmake --version > > Thanks, > -Brad > >-- Alexey Samsonov, MSK -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140225/f0efa6bd/attachment.html>