search for: error_report

...filename = virtio_pstore_from_filename(s, s->files[idx]->d_name, > + &rarg->info); > + if (filename == NULL) { > + goto out; > + } > + > + fd = open(filename, O_RDONLY); > + if (fd < 0) { > + error_report("cannot open %s", filename); > + goto out; > + } > + > + if (fstat(fd, &stbuf) < 0) { > + goto out; > + } > + > + rarg->vps = s; > + rarg->elem = elem; > + rarg->info.id = cpu_to_le64...

...filename = virtio_pstore_from_filename(s, s->files[idx]->d_name, > + &rarg->info); > + if (filename == NULL) { > + goto out; > + } > + > + fd = open(filename, O_RDONLY); > + if (fd < 0) { > + error_report("cannot open %s", filename); > + goto out; > + } > + > + if (fstat(fd, &stbuf) < 0) { > + goto out; > + } > + > + rarg->vps = s; > + rarg->elem = elem; > + rarg->info.id = cpu_to_le64...

Hello all, I'm trying to configure a web development & content management application called siteseed under centos 4.1 My centos install is a minimal with httpd, mysql php added via yum. Problem: PHP complains with errors that look like : 10.192.129.12] PHP Notice: Undefined variable: article_comment in /var/www/html/siteseed/index.php on line 112 [client

Hi, This series allows QEMU to use vhost with legacy virtio devices when host and target don't have the same endianness. Only network devices are covered for the moment. I had already posted a series some monthes ago but it never got reviewed. Moreover, the underlying kernel support was entirely re-written and is still waiting to be applied by Michael. I hence post as RFC. The corresponding

Hi, This series allows QEMU to use vhost with legacy virtio devices when host and target don't have the same endianness. Only network devices are covered for the moment. I had already posted a series some monthes ago but it never got reviewed. Moreover, the underlying kernel support was entirely re-written and is still waiting to be applied by Michael. I hence post as RFC. The corresponding

...num(VirtIODevice *vdev, int n, int num) { + /* + * For virtio-1 devices, the number of buffers may only be + * updated if the ring addresses have not yet been set up. + */ + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1) && + vdev->vq[n].vring.desc) { + error_report("tried to modify buffer num for virtio-1 device"); + return; + } /* Don't allow guest to flip queue between existent and * nonexistent states, or to set it to an invalid size. */ @@ -728,7 +744,7 @@ void virtio_queue_set_num(VirtIODevice *vdev, int n, int nu...

...num(VirtIODevice *vdev, int n, int num) { + /* + * For virtio-1 devices, the number of buffers may only be + * updated if the ring addresses have not yet been set up. + */ + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1) && + vdev->vq[n].vring.desc) { + error_report("tried to modify buffer num for virtio-1 device"); + return; + } /* Don't allow guest to flip queue between existent and * nonexistent states, or to set it to an invalid size. */ @@ -728,7 +744,7 @@ void virtio_queue_set_num(VirtIODevice *vdev, int n, int nu...

...#39;int' type (MST) - Add vhost-scsi.h include for DEFINE_PROP_VHOST_SCSI (mst + nab) - Move vhost-scsi related struct members ahead of *cmd_vqs[0] within VirtIOSCSI definition. (paolo + nab) - Fix 4 byte alignment of vhost_scsi_target (MST) - Convert fprintf(stderr, ...) usage to -> error_report() (reported by MST) - Do explict memset of backend before calling VHOST_SCSI_CLEAR_ENDPOINT in vhost_scsi_stop() (reported by MST) - Add support for vhostfd passing in vhost_scsi_add() (reported by MST) - Move net_handle_fd_param() -> monitor_handle_fd_param() for generic usage by net/...

...#39;int' type (MST) - Add vhost-scsi.h include for DEFINE_PROP_VHOST_SCSI (mst + nab) - Move vhost-scsi related struct members ahead of *cmd_vqs[0] within VirtIOSCSI definition. (paolo + nab) - Fix 4 byte alignment of vhost_scsi_target (MST) - Convert fprintf(stderr, ...) usage to -> error_report() (reported by MST) - Do explict memset of backend before calling VHOST_SCSI_CLEAR_ENDPOINT in vhost_scsi_stop() (reported by MST) - Add support for vhostfd passing in vhost_scsi_add() (reported by MST) - Move net_handle_fd_param() -> monitor_handle_fd_param() for generic usage by net/...

...s = qdev_get_parent_bus(DEVICE(vdev)); > > > VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); > > > > > > + /* virtio-1 compliant devices cannot change the aligment */ > > > + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) { > > > + error_report("tried to modify queue alignment for virtio-1 device"); > > > + return; > > > + } > > > /* Check that the transport told us it was going to do this > > > * (so a buggy transport will immediately assert rather than > > >...

...s = qdev_get_parent_bus(DEVICE(vdev)); > > > VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); > > > > > > + /* virtio-1 compliant devices cannot change the aligment */ > > > + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) { > > > + error_report("tried to modify queue alignment for virtio-1 device"); > > > + return; > > > + } > > > /* Check that the transport told us it was going to do this > > > * (so a buggy transport will immediately assert rather than > > >...

..., s->files[idx]->d_name, > > + &rarg->info); > > + if (filename == NULL) { > > + goto out; > > + } > > + > > + fd = open(filename, O_RDONLY); > > + if (fd < 0) { > > + error_report("cannot open %s", filename); > > + goto out; > > + } > > + > > + if (fstat(fd, &stbuf) < 0) { > > + goto out; > > + } > > + > > + rarg->vps = s; > > + rarg->elem = elem; &g...

This is on top of Paolo and Nick's work. Current status: Works now (guest boots fine, no hang any more) with seabios's virtio-scsi disabled. Rebased to latest qemu.org/master Change details are in commit log. TODO: Make seabios happy. Paolo Bonzini (2): virtio-scsi: create VirtIOSCSICommon vhost-scsi: new device supporting the tcm_vhost Linux kernel module hw/Makefile.objs

This is on top of Paolo and Nick's work. Current status: Works now (guest boots fine, no hang any more) with seabios's virtio-scsi disabled. Rebased to latest qemu.org/master Change details are in commit log. TODO: Make seabios happy. Paolo Bonzini (2): virtio-scsi: create VirtIOSCSICommon vhost-scsi: new device supporting the tcm_vhost Linux kernel module hw/Makefile.objs

...rything mod N*qsize as opposed to mod 2^16. So you need a branch there - easiest to do if you do signed math. int nheads = avail - last_avail; /*Check and handle index wrap-around */ if (unlikely(nheads < 0)) { nheads += N_qsize; } if (nheads < 0 || nheads > vdev->vq[i].vring.num) { error_report(...); return -1; } This can only catch bugs if N > 1 > This is an > example of QEMU code that requires that: > > nheads = vring_avail_idx(&vdev->vq[i]) - vdev->vq[i].last_avail_idx; > /* Check it isn't doing strange things with descripto...

...rything mod N*qsize as opposed to mod 2^16. So you need a branch there - easiest to do if you do signed math. int nheads = avail - last_avail; /*Check and handle index wrap-around */ if (unlikely(nheads < 0)) { nheads += N_qsize; } if (nheads < 0 || nheads > vdev->vq[i].vring.num) { error_report(...); return -1; } This can only catch bugs if N > 1 > This is an > example of QEMU code that requires that: > > nheads = vring_avail_idx(&vdev->vq[i]) - vdev->vq[i].last_avail_idx; > /* Check it isn't doing strange things with descripto...

...e *vdev, int n, int align) > BusState *qbus = qdev_get_parent_bus(DEVICE(vdev)); > VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); > > + /* virtio-1 compliant devices cannot change the aligment */ > + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) { > + error_report("tried to modify queue alignment for virtio-1 device"); > + return; > + } > /* Check that the transport told us it was going to do this > * (so a buggy transport will immediately assert rather than > * silently failing to migrate this state) Do w...

...e *vdev, int n, int align) > BusState *qbus = qdev_get_parent_bus(DEVICE(vdev)); > VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); > > + /* virtio-1 compliant devices cannot change the aligment */ > + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) { > + error_report("tried to modify queue alignment for virtio-1 device"); > + return; > + } > /* Check that the transport told us it was going to do this > * (so a buggy transport will immediately assert rather than > * silently failing to migrate this state) Do w...

This is on top of Paolo and Nick's work. Current status: Basically, tcm_vhost + seabios works now. We still have one more issue, vhost_verify_ring_mappings fails. The hotplug also works with the latest tcm_vhost.ko hotplug patch. Asias He (1): disable vhost_verify_ring_mappings check Paolo Bonzini (2): virtio-scsi: create VirtIOSCSICommon vhost-scsi: new device supporting the

...contiguous memory across region boundaries */ - iov->iov_base = vring_map(&mr, desc->addr, desc->len, - desc->flags & VRING_DESC_F_WRITE); + iov->iov_base = vring_map(&mr, desc_addr, len, is_write); if (!iov->iov_base) { error_report("Failed to map descriptor addr %#" PRIx64 " len %u", - (uint64_t)desc->addr, desc->len); + (uint64_t)desc_addr, len); return -EFAULT; } /* The MemoryRegion is looked up again and unref'ed later, leave the...