search for: enable_float

Hi, Optimizes celt_pitch_xcorr for ARM NEON floating point. Changes from RFCv3: - celt_neon_intr.c - removed warnings due to not having constant pointers - Put simpler loop to take care of corner cases. Unrolling using intrinsics was not really mapping well to what was done in celt_pitch_xcorr_arm.s - Makefile.am Removed explicit -O3 optimization - test_unit_mathops.c,

..." = x"ARM"]) AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], @@ -351,9 +350,58 @@ AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], AM_CONDITIONAL([HAVE_SSE4_1], [false]) AM_CONDITIONAL([HAVE_SSE2], [false]) + AS_IF([test x"$enable_intrinsics" = x"yes"],[ -AS_IF([test x"$enable_float" = x"no"], -[AS_IF([test x"$host_cpu" = x"i386" -o x"$host_cpu" = x"i686" -o x"$host_cpu" = x"x86_64"],[ + case $host_cpu in + arm*) + cpu_arm=yes + AC_MSG_CHECKING(if compiler supports ARM NEON intrinsics) +...

..." = x"ARM"]) AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], @@ -351,9 +350,52 @@ AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], AM_CONDITIONAL([HAVE_SSE4_1], [false]) AM_CONDITIONAL([HAVE_SSE2], [false]) + AS_IF([test x"$enable_intrinsics" = x"yes"],[ -AS_IF([test x"$enable_float" = x"no"], -[AS_IF([test x"$host_cpu" = x"i386" -o x"$host_cpu" = x"i686" -o x"$host_cpu" = x"x86_64"],[ + case $host_cpu in + arm*) + cpu_arm=yes + AC_MSG_CHECKING(if compiler supports arm neon intrinsics) +...

..." = x"ARM"]) AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], @@ -351,9 +350,58 @@ AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], AM_CONDITIONAL([HAVE_SSE4_1], [false]) AM_CONDITIONAL([HAVE_SSE2], [false]) + AS_IF([test x"$enable_intrinsics" = x"yes"],[ -AS_IF([test x"$enable_float" = x"no"], -[AS_IF([test x"$host_cpu" = x"i386" -o x"$host_cpu" = x"i686" -o x"$host_cpu" = x"x86_64"],[ + case $host_cpu in + arm*) + cpu_arm=yes + AC_MSG_CHECKING(if compiler supports ARM NEON intrinsics) +...

Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv2: - Changes recommended by Timothy for celt_neon_intr.c everything except, left the unrolled loop still unrolled - configure.ac - use AC_LINK_IFELSE instead of AC_COMPILE_IFELSE - Moved compile flags into Makefile.am - OPUS_ARM_NEON_INR --> typo --> OPUS_ARM_NEON_INTR Viswanath Puttagunta (1): armv7:

Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more in-line with algorithm in celt_pitch_xcorr_arm.s Viswanath Puttagunta

From: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more

...ONDITIONAL([OPUS_ARM_EXTERNAL_ASM], > @@ -351,9 +350,58 @@ AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], > > AM_CONDITIONAL([HAVE_SSE4_1], [false]) > AM_CONDITIONAL([HAVE_SSE2], [false]) > + > AS_IF([test x"$enable_intrinsics" = x"yes"],[ > -AS_IF([test x"$enable_float" = x"no"], > -[AS_IF([test x"$host_cpu" = x"i386" -o x"$host_cpu" = x"i686" -o x"$host_cpu" = x"x86_64"],[ > + case $host_cpu in > + arm*) > + cpu_arm=yes > + AC_MSG_CHECKING(if compiler supports...

...199,25 @@ cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ inline_optimization="No inline ASM for your platform, please send patches" case $host_cpu in + arm64*|aarch64*) + dnl Currently we only have asm for fixed-point + AS_IF([test "$enable_float" != "yes"],[ + cpu_arm64=yes + AC_DEFINE([OPUS_ARM64_ASM], [], [Make use of ARM64 asm optimization]) + AS_GCC_INLINE_ASSEMBLY( + [inline_optimization="ARM64"], + [inline_optimization="disabled"] +...

...199,25 @@ cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ inline_optimization="No inline ASM for your platform, please send patches" case $host_cpu in + arm64*|aarch64*) + dnl Currently we only have asm for fixed-point + AS_IF([test "$enable_float" != "yes"],[ + cpu_arm64=yes + AC_DEFINE([OPUS_ARM64_ASM], [], [Make use of ARM64 asm optimization]) + AS_GCC_INLINE_ASSEMBLY( + [inline_optimization="ARM64"], + [inline_optimization="disabled"] +...

...P support]) +]) + +PKG_CHECK_MODULES([DEPS], [ogg opus ]${openssl}) + +AC_ARG_ENABLE([fixed-point], + AS_HELP_STRING([--enable-fixed-point], [Enable fixed-point calculation]),, + enable_fixed_point=no) +AC_ARG_ENABLE([float], + AS_HELP_STRING([--disable-float], [Disable floating-point API]),, + enable_float=yes) + +AS_IF([test "x$enable_float" = "xno"], + [enable_fixed_point=yes + AC_DEFINE([OP_DISABLE_FLOAT_API], [1], [Disable floating-point API]) + ], + [dnl This only has to be tested for if float API is enabled + AC_SEARCH_LIBS([lrintf], [m], [ + AC_DEFINE([OP_HAVE_L...

...P support]) +]) + +PKG_CHECK_MODULES([DEPS], [ogg opus ]${openssl}) + +AC_ARG_ENABLE([fixed-point], + AS_HELP_STRING([--enable-fixed-point], [Enable fixed-point calculation]),, + enable_fixed_point=no) +AC_ARG_ENABLE([float], + AS_HELP_STRING([--disable-float], [Disable floating-point API]),, + enable_float=yes) + +AS_IF([test "x$enable_float" = "xno"], + [enable_fixed_point=yes + AC_DEFINE([OP_DISABLE_FLOAT_API], [1], [Disable floating-point API]) + ], + [dnl This only has to be tested for if float API is enabled + AC_SEARCH_LIBS([lrintf], [m], [ + AC_DEFINE([OP_HAVE_L...

...support]) +]) + +PKG_CHECK_MODULES([DEPS], [ogg opus ]${openssl}) + +AC_ARG_ENABLE([fixed-point], + AS_HELP_STRING([--enable-fixed-point], [Enable fixed-point calculation]),, + enable_fixed_point=no) +AC_ARG_ENABLE([float], + AS_HELP_STRING([--disable-float], [Disable floating-point API]),, + enable_float=yes) + +AS_IF([test "x$enable_float" = "xno"], + [enable_fixed_point=yes + AC_DEFINE([OP_DISABLE_FLOAT_API], [1], [Disable floating-point API]) + ] +) + +AS_IF([test "x$enable_fixed_point" = "xyes"], + [AC_DEFINE([OP_FIXED_POINT], [1], [Enable fixed-poin...

On 25 November 2014 at 10:11, Viswanath Puttagunta <viswanath.puttagunta at linaro.org> wrote: > > On 25 November 2014 at 09:39, Jonathan Lennox <jonathan at vidyo.com> wrote: > > > > On Nov 25, 2014, at 10:07 AM, Viswanath Puttagunta <viswanath.puttagunta at linaro.org> wrote: > >> > >> > Also is there plans to make the NEON optimisations

...;T') > + AC_MSG_RESULT([no]) > + ]) > + CFLAGS="$save_CFLAGS" > + #Now we know if compiler supports ARM neon intrinsics or not > + > + #Currently we only have intrinsic optimization for floating point > + AS_IF([test x"$enable_float" = x"yes"], > + [ > + AS_IF([test x"$OPUS_ARM_NEON_INTR" = x"1"], > + [ > + OPUS_ARM_NEON_INTR_CPPFLAGS="-mfpu=neon -O3" I don't think you should change the optimization level here.

...this in configure.ac. Can you please point me to where rtcd_support is set to no for armv8 (AAarch64)? Tip of git, starting line 202: 202 case $host_cpu in 203 arm64*|aarch64*) 204 dnl Currently we only have asm for fixed-point 205 AS_IF([test "$enable_float" != "yes"],[ 206 cpu_arm64=yes 207 AC_DEFINE([OPUS_ARM64_ASM], [], [Make use of ARM64 asm optimization]) 208 AS_GCC_INLINE_ASSEMBLY( 209 [inline_optimization="ARM64"], 210 [inline_optim...

...point me to where rtcd_support is set to no for armv8 (AAarch64)? > > > Tip of git, starting line 202: > > 202 case $host_cpu in > 203 arm64*|aarch64*) > 204 dnl Currently we only have asm for fixed-point > 205 AS_IF([test "$enable_float" != "yes"],[ > 206 cpu_arm64=yes > 207 AC_DEFINE([OPUS_ARM64_ASM], [], [Make use of ARM64 asm > optimization]) > 208 AS_GCC_INLINE_ASSEMBLY( > 209 [inline_optimization="ARM64"], > 210...

...}" = x"yes"],[ > inline_optimization="No ASM for your platform, please send patches" > + OPUS_ARM_NEON_INTR_CPPFLAGS= > case $host_cpu in > arm*) > - dnl Currently we only have asm for fixed-point > - AS_IF([test "$enable_float" != "yes"],[ > cpu_arm=yes > - AC_DEFINE([OPUS_ARM_ASM], [], [Make use of ARM asm optimization]) > + AC_DEFINE([OPUS_ARM_ASM], [], [Make use of ARM asm/intrinsic optimization]) Not sure I'm in love with conflating intrinsics with in...

...t;],[ >> inline_optimization="No ASM for your platform, please send patches" >> + OPUS_ARM_NEON_INTR_CPPFLAGS= >> case $host_cpu in >> arm*) >> - dnl Currently we only have asm for fixed-point >> - AS_IF([test "$enable_float" != "yes"],[ >> cpu_arm=yes >> - AC_DEFINE([OPUS_ARM_ASM], [], [Make use of ARM asm optimization]) >> + AC_DEFINE([OPUS_ARM_ASM], [], [Make use of ARM asm/intrinsic optimization]) > > Not sure I'm in love with conflati...

The attached patch cleans up Opus's x86 intrinsics configury. It: * Makes ?enable-intrinsics work with clang and other non-GCC compilers * Enables RTCD for the floating-point-mode SSE code in Celt. * Disables use of RTCD in cases where the compiler targets an instruction set by default. * Enables the SSE4.1 Silk optimizations that apply to the common parts of Silk when Opus is built in