search for: enable_cb_dealyed

...if (kick) >> + virtqueue_enable_cb_delayed(sq->vq); >> + else >> + virtqueue_disable_cb(sq->vq); > > > Since virtqueue_disable_cb() do nothing for event idx. I wonder whether or > not just calling enable_cb_dealyed() is ok here. Good point. > Btw, it does not disable interrupt at all, I propose a patch in the past > which can do more than this: > > https://patchwork.kernel.org/patch/6472601/ Interesting. Yes, let me evaluate that variant. Thanks for reviewing, Willem

...if (kick) >> + virtqueue_enable_cb_delayed(sq->vq); >> + else >> + virtqueue_disable_cb(sq->vq); > > > Since virtqueue_disable_cb() do nothing for event idx. I wonder whether or > not just calling enable_cb_dealyed() is ok here. Good point. > Btw, it does not disable interrupt at all, I propose a patch in the past > which can do more than this: > > https://patchwork.kernel.org/patch/6472601/ Interesting. Yes, let me evaluate that variant. Thanks for reviewing, Willem

...d buffers before queueing new ones. */ > - if (!use_napi) > + if (use_napi) { > + if (kick) > + virtqueue_enable_cb_delayed(sq->vq); > + else > + virtqueue_disable_cb(sq->vq); Since virtqueue_disable_cb() do nothing for event idx. I wonder whether or not just calling enable_cb_dealyed() is ok here. Btw, it does not disable interrupt at all, I propose a patch in the past which can do more than this: https://patchwork.kernel.org/patch/6472601/ Thanks > + } else { > free_old_xmit_skbs(sq); > + } > > /* timestamp packet in software */ > skb_tx_t...

From: Willem de Bruijn <willemb at google.com> Tx napi mode increases the rate of transmit interrupts. Suppress some by masking interrupts while more packets are expected. The interrupts will be reenabled before the last packet is sent. This optimization reduces the througput drop with tx napi for unidirectional flows such as UDP_STREAM that do not benefit from cleaning tx completions in

From: Willem de Bruijn <willemb at google.com> Add napi for virtio-net transmit completion processing. Changes: v1 -> v2: - disable by default - disable unless affinity_hint_set because cache misses add up to a third higher cycle cost, e.g., in TCP_RR tests. This is not limited to the patch that enables tx completion cleaning in rx napi. - use trylock to

From: Willem de Bruijn <willemb at google.com> Add napi for virtio-net transmit completion processing. Changes: v1 -> v2: - disable by default - disable unless affinity_hint_set because cache misses add up to a third higher cycle cost, e.g., in TCP_RR tests. This is not limited to the patch that enables tx completion cleaning in rx napi. - use trylock to