search for: drm_gem

I forgot this change. Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: > Add unlocked variants of drm_gem_un/pin() functions. These new helpers > will take care of GEM dma-reservation locking for DRM drivers. > > VirtIO-GPU driver will use these helpers to pin shmem framebuffers, > preventing them from eviction during scanout. > > Signed-off-by: Dmitry Osipenko <dmitry.osipenko a...

...information */ - struct drm_vma_offset_manager *vma_offset_manager; - - /** - * @max_segment: - * - * Max size for scatter list segments for GEM objects. When - * unset the default (SCATTERLIST_MAX_SEGMENT) is used. - */ - size_t max_segment; + /** @gem_config: Current GEM config */ + struct drm_gem_config gem_config; /** @vram_mm: VRAM MM memory manager */ struct drm_vram_mm *vram_mm; diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h index 337a48321705..74129fb29fb8 100644 --- a/include/drm/drm_gem.h +++ b/include/drm/drm_gem.h @@ -39,6 +39,25 @@ #include <drm/drm_vma_man...

From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This allowing of working against a partially constructed object, which may also be in the process of having its creation fail, can have a range of negative outcomes. A lot of those will depend on...

From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This allowing of working against a partially constructed object, which may also be in the process of having its creation fail, can have a range of negative outcomes. A lot of those will depend on...

Hi, On 14/02/2023 13:59, Christian K?nig wrote: > Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: >> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> >> >> Currently drm_gem_handle_create_tail exposes the handle to userspace >> before the buffer object constructions is complete. This allowing >> of working against a partially constructed object, which may also be in >> the process of having its creation fail, can have a range of negative >> outc...

Hi, On 14/02/2023 13:59, Christian K?nig wrote: > Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: >> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> >> >> Currently drm_gem_handle_create_tail exposes the handle to userspace >> before the buffer object constructions is complete. This allowing >> of working against a partially constructed object, which may also be in >> the process of having its creation fail, can have a range of negative >> outc...

From: Rob Clark <robdclark at chromium.org> Needed in the following patch for cache operations. Signed-off-by: Rob Clark <robdclark at chromium.org> --- drivers/gpu/drm/drm_gem.c | 10 ++++++---- drivers/gpu/drm/drm_gem_vram_helper.c | 6 ++++-- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c...

From: Rob Clark <robdclark at chromium.org> Needed in the following patch for cache operations. Signed-off-by: Rob Clark <robdclark at chromium.org> --- drivers/gpu/drm/drm_gem.c | 10 ++++++---- drivers/gpu/drm/drm_gem_vram_helper.c | 6 ++++-- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c...

From: Rob Clark <robdclark at chromium.org> Needed in the following patch for cache operations. Signed-off-by: Rob Clark <robdclark at chromium.org> --- drivers/gpu/drm/drm_gem.c | 10 ++++++---- drivers/gpu/drm/drm_gem_vram_helper.c | 6 ++++-- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c...

....02.23 um 10:55 schrieb Tvrtko Ursulin: >> >> Hi, >> >> On 14/02/2023 13:59, Christian K?nig wrote: >>> Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: >>>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> >>>> >>>> Currently drm_gem_handle_create_tail exposes the handle to userspace >>>> before the buffer object constructions is complete. This allowing >>>> of working against a partially constructed object, which may also be in >>>> the process of having its creation fail, can have a range o...

....02.23 um 10:55 schrieb Tvrtko Ursulin: >> >> Hi, >> >> On 14/02/2023 13:59, Christian K?nig wrote: >>> Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: >>>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> >>>> >>>> Currently drm_gem_handle_create_tail exposes the handle to userspace >>>> before the buffer object constructions is complete. This allowing >>>> of working against a partially constructed object, which may also be in >>>> the process of having its creation fail, can have a range o...

...be a problem ... > and even when it uses GEM objects, the > code will not initialize the GEM object until after the buffer objects > and the backing TTM objects have been created. ... but the initialization order is. ttm_bo_uses_embedded_gem_object() assumes gem gets initialized first. drm_gem_object_init() init calling drm_vma_node_reset() again is probably the root cause for the breakage. > I tried to fix that by making sure drm_gem_object_init() gets called by > Nouveau before ttm_bo_init(), but the changes are fairly involved and I > was unable to get the GEM reference coun...

.... >>>>> >>>>> No worries, thank you for taking a look anyway! >>>>> >>>>>> >>>>>> Am 20.06.23 um 02:42 schrieb Danilo Krummrich: >>>>>>> [SNIP] >>>>>>> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h >>>>>>> index bbc721870c13..5ec8148a30ee 100644 >>>>>>> --- a/include/drm/drm_gem.h >>>>>>> +++ b/include/drm/drm_gem.h >>>>>>> @@ -36,6 +36,8 @@ >>>>>>> ? #include &lt...

...gt;>>>>> No worries, thank you for taking a look anyway! >>>>>> >>>>>>> >>>>>>> Am 20.06.23 um 02:42 schrieb Danilo Krummrich: >>>>>>>> [SNIP] >>>>>>>> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h >>>>>>>> index bbc721870c13..5ec8148a30ee 100644 >>>>>>>> --- a/include/drm/drm_gem.h >>>>>>>> +++ b/include/drm/drm_gem.h >>>>>>>> @@ -36,6 +36,8 @@ >>>>>>&gt...

GEM's vmap and vunmap interfaces now wrap memory pointers in struct dma_buf_map. Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> --- drivers/gpu/drm/drm_client.c | 18 +++++++++++------- drivers/gpu/drm/drm_gem.c | 28 ++++++++++++++-------------- drivers/gpu/drm/drm_internal.h | 5 +++-- drivers/gpu/drm/drm_prime.c | 14 ++++---------- 4 files changed, 32 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 495f47d23d87..ac0082bed966 1006...

Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> > > Currently drm_gem_handle_create_tail exposes the handle to userspace > before the buffer object constructions is complete. This allowing > of working against a partially constructed object, which may also be in > the process of having its creation fail, can have a range of negative > outcomes. > >...

Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> > > Currently drm_gem_handle_create_tail exposes the handle to userspace > before the buffer object constructions is complete. This allowing > of working against a partially constructed object, which may also be in > the process of having its creation fail, can have a range of negative > outcomes. > >...

Am 20.02.23 um 10:55 schrieb Tvrtko Ursulin: > > Hi, > > On 14/02/2023 13:59, Christian K?nig wrote: >> Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: >>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com> >>> >>> Currently drm_gem_handle_create_tail exposes the handle to userspace >>> before the buffer object constructions is complete. This allowing >>> of working against a partially constructed object, which may also be in >>> the process of having its creation fail, can have a range of negative &...

From: Rob Clark <robdclark at chromium.org> Needed in the following patch for cache operations. Signed-off-by: Rob Clark <robdclark at chromium.org> --- v3: rebased on drm-tip drivers/gpu/drm/drm_gem.c | 8 ++++---- drivers/gpu/drm/drm_internal.h | 4 ++-- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c | 4 +...

From: Rob Clark <robdclark at chromium.org> Needed in the following patch for cache operations. Signed-off-by: Rob Clark <robdclark at chromium.org> --- v3: rebased on drm-tip drivers/gpu/drm/drm_gem.c | 8 ++++---- drivers/gpu/drm/drm_internal.h | 4 ++-- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c | 4 +...